From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B941C001DB for ; Mon, 7 Aug 2023 21:35:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CUuf6RRNtQHlSzjSNAaoexnXqQy3yDgwbrcFOyd+o/c=; b=FY30Xv1F4qunjh DCH85g/OsbKl6bSD2R6dU2BOnwHK7+kXbhIgcw7AY6pAxRkbUph/ydtDx9CNk5eZ4rrgIwnuOwHYz bTRwnbDl4Wjfl8amR+Se1j4T6pQHR4w16YSxGv1VL3iJ5IfttPm24lpEOK+x2pKKZ/DEmlnEBFby9 884fX2HcaIqfMUDu74JF9+rvaLGLSHVeNf3VTtOi9avB/z6EX6Q93bSzF4B5MeoxW/SdqRRbAdP6j kJV87o6tktnrruASKw+QmssN+lFriBjv87mSMoC6f5x7vxzqYRo3XoY3MlPunjdEsBZCR8ZVYGcz9 UjRm85MPCIDLSw6x7niA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qT7sU-000mZA-2R; Mon, 07 Aug 2023 21:35:02 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qT7sR-000mYC-12 for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 21:35:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EAA462263; Mon, 7 Aug 2023 21:34:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C0E3C433C7; Mon, 7 Aug 2023 21:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691444095; bh=2vh5MKnUPvpayE8v3B6yBNfJsLF72v8kjOqfdpQ4ziQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q1w4z8FuPe0YjK1E9yk0PGDEUcr8NUMlvZCIR048M0izDsRTHdLgeB00XlXdOJt3h 9mH+nakIVu2Aev/xlK1SbMGSQi6Et1JjseY7zZuSI6zH2WIts0ZI+KiPvGyC/91iMV JD3/L4YQ7MqkG7g5AT1heuwNO+GF5/l/dUVzNSKb3XM4OyaYRmynLmMBiO63CVY0cV EhxlMgA+96uVg1r1PImuSp3j3hiLAnZZv9gzlgHXUgHLhIp9KkctRMjYSBCPKbCx3V 1jkopuLqsXRPHNIDq4OJQLuJcgclPadDh2SURsnPprtfuoy0k37ngN3T0BJHm5vwi6 c4AujB1SuJ5SA== Date: Mon, 7 Aug 2023 23:34:52 +0200 From: Andi Shyti To: Anton Eliasson Cc: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com Subject: Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support Message-ID: <20230807213452.aev2ubalxvydmxjv@intel.intel> References: <20230803-samsung_tty_pm_ops-v1-1-1ea7be72194d@axis.com> <20230805213824.ol7sr3b52rwrsfs6@intel.intel> <1dbc24c4-b057-0e71-432a-a7d0ce2df2dc@axis.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1dbc24c4-b057-0e71-432a-a7d0ce2df2dc@axis.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_143459_428164_32D61BB5 X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anton, On Mon, Aug 07, 2023 at 11:57:04AM +0200, Anton Eliasson wrote: > On 05/08/2023 23.38, Andi Shyti wrote: > > Hi Anton, > > > > On Thu, Aug 03, 2023 at 01:26:42PM +0200, Anton Eliasson wrote: > > > At least freeze, restore and thaw need to be set in order for the driver > > > to support system hibernation. The existing suspend/resume functions can > > > be reused since those functions don't touch the device's power state or > > > wakeup capability. Use the helper macros SET_SYSTEM_SLEEP_PM_OPS and > > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for symmetry with similar drivers. > > and why do we need hibernation in this device? > > > > Andi > > Hi! > > I wanted to test whether hibernation is possible on our SoC, even though it > is not a common feature on embedded ARM systems. This is the only mainline > driver that I found that needed modification, for my proof-of-concept > anyway, and I couldn't see any harm in the change. Thanks, makes sense, mine was just curiosity, can I know which SoC you are testing that is using the samsung serial device? You can add my r-b, anyway: Reviewed-by: Andi Shyti Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel