From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16360C001B0 for ; Tue, 8 Aug 2023 07:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1BNg8zr5VxrV98AN2w0pxyKbPnA0metbbIegD41D0x8=; b=VGRYQ2a0hlyEb4so38e816Pfb3 Iu/iMtOlfXYQ9+65Hj24BIhM4t/UmjBGM2f9z6VDX0P7A29vIvD578Xlf30X7j/VaTAXII60ewCLL wciekyYsxdk+DMxsZCnKEmF6KY/Uj+v80+GJjnprHz7Tgzd+ZFp1AGOkhk0cXWCfQDSEhq0MP1tYH /LWa+T0noMgT4gqrXyjRBOr+/PKNT+x3M2G/lfquDF8vQzBMoLutbCut6Q/glykKW0T4uqtrHslSV FeLE6bZPWTOiJKSbMwdUWjouLSv3NzF47hp/FPwWyFoxygh6D0Q0QjXnwF3BmoKntXP3/nPoONc4k 3C7yRvVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTHK4-001uBU-0h; Tue, 08 Aug 2023 07:40:08 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTHK1-001uB4-05 for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 07:40:06 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 64D4F62420; Tue, 8 Aug 2023 07:40:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0A0AC433C7; Tue, 8 Aug 2023 07:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691480403; bh=eeHnU9sbaREHfqMBo/78Xdyc8QmRfoP3LwM2oF3Vyok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z+hgCruQm2uu/S7DddPGDxVKQgZvYiSoMBPLPwLN1VBSNtr1u+085A9QUxiiQx+JK ihi46jANzuFJVh09X1hBEsF3bxP2GSt83pj3cuGRAyOe9h6LM9eXBxkutgo1IgrvDL f3yo2TgB2qyRua3/sXAXbwzhVMdhV8sqzKqIYPA1Xj8Or1oo37VODb2bCuePorzrNF 34O/jZcESdCYCDASlx6PMDnfLROZAlprRs/E8YvlwqZEn0AIsxOIgA0BRAWg72/yUq jVSwW/JCR38PnZWOuHI+BA/nUboHh4EBAouw3W1ljvmg6T6MCcVWNqxKj3/kHuX5QR g9kS4Mu6EAj8A== Date: Tue, 8 Aug 2023 08:39:58 +0100 From: Conor Dooley To: Jisheng Zhang Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2 09/10] dt-bindings: net: snps,dwmac: add per channel irq support Message-ID: <20230808-clapper-corncob-0af7afa65752@spud> References: <20230807164151.1130-1-jszhang@kernel.org> <20230807164151.1130-10-jszhang@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230807164151.1130-10-jszhang@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_004005_152486_D42B18DF X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5242722895609339773==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5242722895609339773== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KvLkMguropyELtMw" Content-Disposition: inline --KvLkMguropyELtMw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 08, 2023 at 12:41:50AM +0800, Jisheng Zhang wrote: > The IP supports per channel interrupt, add support for this usage case. >=20 > Signed-off-by: Jisheng Zhang > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Docu= mentation/devicetree/bindings/net/snps,dwmac.yaml > index 5d81042f5634..5a63302ad200 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -109,6 +109,7 @@ properties: > - description: The interrupt that occurs when Rx exits the LPI sta= te > - description: The interrupt that occurs when Safety Feature Corre= ctible Errors happen > - description: The interrupt that occurs when Safety Feature Uncor= rectible Errors happen > + - description: All of the rx/tx per-channel interrupts > =20 > interrupt-names: > minItems: 1 > @@ -118,6 +119,38 @@ properties: > - const: eth_lpi > - const: sfty_ce > - const: sfty_ue > + - const: rx0 > + - const: rx1 > + - const: rx2 > + - const: rx3 > + - const: rx4 > + - const: rx5 > + - const: rx6 > + - const: rx7 > + - const: rx8 > + - const: rx9 > + - const: rx10 > + - const: rx11 > + - const: rx12 > + - const: rx13 > + - const: rx14 > + - const: rx15 > + - const: tx0 > + - const: tx1 > + - const: tx2 > + - const: tx3 > + - const: tx4 > + - const: tx5 > + - const: tx6 > + - const: tx7 > + - const: tx8 > + - const: tx9 > + - const: tx10 > + - const: tx11 > + - const: tx12 > + - const: tx13 > + - const: tx14 > + - const: tx15 I don't think Rob's comment about having added 2 interrupts but 32 interrupt names has been resolved. Did you actually test putting this many interrupts into a node? AFAICT, any more than 6 will cause complaints. Thanks, Conor. --KvLkMguropyELtMw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNHxTgAKCRB4tDGHoIJi 0onpAPsG6snh0PH1bQ597oct8Uh4jQLMK5o7U0UogD2+jX8qKQD+Mew24QNaxdd5 CIffFZC7Y1NgpuTfzG6Dej4xrzYwBAU= =WzEI -----END PGP SIGNATURE----- --KvLkMguropyELtMw-- --===============5242722895609339773== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5242722895609339773==--