From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E102C001DF for ; Tue, 8 Aug 2023 10:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UqUJ6tCLZVtG/3mdetgKrjkuZFLE5JZdTtcf1oHntYs=; b=cgG/vXHqbvg8dKo+Nhz5Ja/1Gh /UiIsPUszTJdzvx2xoltFjbPSqAvdIk0Q+VLcowAroMhHMEXCIUz+I+BRjvSLTPU7lh/rC+eTioqq +S6Y1qaCfPDQi0uKv6ZSJWphDpnAj0jLGm9luIc0QML78hoTMBf+/3RcmzOE417AZoyQPbbtNwOIu t8ubeRMQ6JZ2eGZTymZ15dJnzM+xnTR/qHCKmBid6TbFUyL5vV3qE6rnfNbqCSQ/vjwlROlZg4NU+ aLCiv63L5kOrf3iO5AVnVBLAlVkUyNDNOIaalOmDNuKCJ7ufK49wx7Y4rUSyKDZR7pP3MRYgga2dA YeYChW3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTKG4-002NRS-0q; Tue, 08 Aug 2023 10:48:12 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTKG0-002NPB-38 for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 10:48:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6136F624A7; Tue, 8 Aug 2023 10:48:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3F57C433C8; Tue, 8 Aug 2023 10:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691491687; bh=g4Al6u/oxW9sOdVO40WZiYWYztfE/tWlGU1STUdbHRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rsIaGXcA79+KRvi55vDwZcaycKr5Mc/tVkLjU9fnNOY0UZLyw4vPkks1ugyvNMdZv srirx/T+v64qvDgrub2wSDxGiS/PYNi3uuTSQoz89p7MJQy3+2poNJRzUWKNVWRLpg wQP0U7Mdof49bv8EQ0mxaWPbO00xd64PzEDXDyLSCKUw1N6Kwpdr+2B21tHFn1aTwp E2oma7Au+eu76VP9dHf8q2a11dhwdmCzggYmbElo7c2WGOjSEHsYn3sM6kZdXQeANH EvYNDPEwf6tVZEpntFzO6jB/RyIpiIdleHwr0hQTx3SD77GNmeoiHOgVaKiRK8405H RaOFRZFBn8QcQ== Date: Tue, 8 Aug 2023 11:48:02 +0100 From: Conor Dooley To: Md Danish Anwar Subject: Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property Message-ID: <20230808-unwomanly-generic-67d20f0e51cd@spud> References: <20230807110836.2612730-1-danishanwar@ti.com> <20230807-euphemism-trailing-ef4130dc7437@spud> <910a4a98-712a-5517-5a5b-ffb962f83463@ti.com> MIME-Version: 1.0 In-Reply-To: <910a4a98-712a-5517-5a5b-ffb962f83463@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_034809_115412_EB9B72A0 X-CRM114-Status: GOOD ( 22.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: srk@ti.com, devicetree@vger.kernel.org, Conor Dooley , linux-omap@vger.kernel.org, vigneshr@ti.com, Mathieu Poirier , Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, MD Danish Anwar , nm@ti.com, Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7850094687610250871==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7850094687610250871== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RzfM45YTf9+4RvqO" Content-Disposition: inline --RzfM45YTf9+4RvqO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 08, 2023 at 03:14:31PM +0530, Md Danish Anwar wrote: > Hi Conor, >=20 > On 07/08/23 8:09 pm, Conor Dooley wrote: > > On Mon, Aug 07, 2023 at 04:38:36PM +0530, MD Danish Anwar wrote: > >> Add interrupts and interrupt-names protperties for PRU and RTU cores. > >> > >> Signed-off-by: MD Danish Anwar > >> --- > >> .../bindings/remoteproc/ti,pru-rproc.yaml | 22 +++++++++++++++++++ > >> 1 file changed, 22 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc= =2Eyaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > >> index cd55d80137f7..6970316943bb 100644 > >> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > >> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > >> @@ -66,6 +66,16 @@ properties: > >> Should contain the name of the default firmware image > >> file located on the firmware search path. > >> =20 > >> + interrupts: > >> + maxItems: 1 > >> + description: > >> + Interrupt specifiers enable the virtio/rpmsg communication betw= een MPU > >> + and the PRU/RTU cores. > >> + > >> + interrupt-names: > >> + items: > >> + - const: vring > >> + > >> if: > >> properties: > >> compatible: > >> @@ -171,6 +181,9 @@ examples: > >> <0x22400 0x100>; > >> reg-names =3D "iram", "control", "debug"; > >> firmware-name =3D "am65x-pru0_0-fw"; > >> + interrupt-parent =3D <&icssg0_intc>; > >> + interrupts =3D <16 2 2>; > >> + interrupt-names =3D "vring"; > >> }; > >=20 > > These examples would probably be more helpful if they used the > > appropriate defines, no? > >=20 >=20 > PRUSS Interrupt controller doesn't have any appropriate defines. This doe= sn't > use GIC so defines from arm-gic.h can not be used here. These are specifi= c to > PRUSS INTC. I was deliberately vague in case the gic stuff applied too, but my main question was about the standard defines used for interrupt types. > I think these example are OK. Please let me know if this is OK to you. --RzfM45YTf9+4RvqO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNIdYgAKCRB4tDGHoIJi 0sfFAQDUGTaUH2VxL1ST+sf18hKE5yCqpFEUkOJu+bgGPLkmuQD/XAUCs4HrdF2v 1lu3PdJ0QSaQoDb36Qrpa6k3hHGvUQg= =l++a -----END PGP SIGNATURE----- --RzfM45YTf9+4RvqO-- --===============7850094687610250871== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7850094687610250871==--