From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B7D0C001B0 for ; Tue, 8 Aug 2023 11:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QetPTRFoieRmXmNXk6U2JPy3w7px0GiLWdH3xYSoJWc=; b=y+KSJRG2etpajX e1XPaxOk928FjMEyvpuVKTB+Kc9CfL6XVYbhR3hn27LmHfUCWqSkS13Ubx4euYMvX9DVDMQ2UkGBd 0oMT4tci/RqNmvFF9vx5vXne4Qemz9dtIu09gxxYwE4Aawdo23T27yP5riRz6yqPJkirt1e7bPvNQ V/MEU6IjavYkK3eryhhrf3wwJKNVuyjP3pb6ja6Zxpna6uBtK7/6atiacRTmnA/DQCsodKzGB+W7H MOOIPr6M7nVnCNBdi/uN7DNsjrgAXxcNvqnWpqraMSjnJ/TOziKnA+w5nigND7f38uIdBbjRz1k1F 0nb92/ginPm7qiHtdafA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTKtn-002SvR-30; Tue, 08 Aug 2023 11:29:15 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTKtk-002Suv-2M; Tue, 08 Aug 2023 11:29:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABFB8624D1; Tue, 8 Aug 2023 11:29:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E544CC433C8; Tue, 8 Aug 2023 11:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691494151; bh=tZ2FF4o+MYOJ/APB5kJLCZ4WhH/ohRGQPmwD8tUh38s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gv+GVG688C7zwn2+rfsZcGjS5xGzK3cwXlM3qNCwnQ4lhJckfRV4W4mhWVnDbTzxZ 83RU5YMfPiyBnatstdz2ZQZbkRIN7eAPpbYrN0CGWJABiYp7naSI2hfk8MMnN6p55V VyUeufF2pjJlokIwR3SeIs/+UuX1x8kM1tfd/hm+aGE2xVNEsIpnuzRvmAZpKurmzS 4PS8AWBRExG4NLeKSCFq1jOh/iy7Kd6T5YTa6NigkQhUyKORzfD2gpNSULnyJYQhtY /lYTHbjM6QTcxq1MhO5b4mMTzqn0ze04jRuEIjdftrUrxnygNI+RYd2YHUofSbYR8a KhNgGL2R8POkQ== Date: Tue, 8 Aug 2023 13:29:07 +0200 From: Andi Shyti To: Krzysztof Kozlowski Cc: Liao Chang , florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3 2/9] i2c: mlxbf: Use dev_err_probe in probe function Message-ID: <20230808112907.4rnvmyha4v6cg5ds@intel.intel> References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-3-liaochang1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_042912_817424_A501F90B X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Tue, Aug 08, 2023 at 10:36:40AM +0200, Krzysztof Kozlowski wrote: > On 08/08/2023 03:29, Liao Chang wrote: > > Use the dev_err_probe function instead of dev_err in the probe function > > so that the printed messge includes the return value and also handles > > -EPROBE_DEFER nicely. > > > > Reviewed-by: Andi Shyti > > Signed-off-by: Liao Chang > > ... > > > @@ -2413,10 +2399,8 @@ static int mlxbf_i2c_probe(struct platform_device *pdev) > > ret = devm_request_irq(dev, irq, mlxbf_i2c_irq, > > IRQF_SHARED | IRQF_PROBE_SHARED, > > dev_name(dev), priv); > > - if (ret < 0) { > > - dev_err(dev, "Cannot get irq %d\n", irq); > > - return ret; > > - } > > + if (ret < 0) > > + return dev_err_probe(dev, ret, "Cannot get irq %d\n", irq); > > I don't think this is needed: > https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/ Hmm, that's a bit borderline, I'd say. The change to devm_request_irq/devm_request_threaded_irq_probe seems like something for another series. But for now, I think I'll accept this as it is since it fits within the scope of this current series. Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel