From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 475CAC001B0 for ; Tue, 8 Aug 2023 20:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kaQYrYU0OotcULYL/uYJfVQBV4B4IXOe/1bIXgK+kwg=; b=VPLiTyrWm/CtSt TpzqlnClYeA0E21YK+oHVt120wAFT2/7WoSk8qhJX78uh5yoArNmddKtMT3B/3j6qskY87wNas68/ AIudFkszRNPpwpD0hRAGgBZHbPIdu3d2RuYw5V455v4xeELew6FxYdPOlUt+NgqOF6fiLxGRdLgRT 7OcVInq1//wBVvVgt+997FdzoWs400s1FMRDcmEd6q9N9eCC7+3eCOkHLIwsQPWTkYHGvBB6Bx1Al pxkoHTUIbOSD3Sqsqp7dTrFzoyKNByLXhT2RWoR4zjcxUs7af1yjtB+g52ZfVqC7+zkIYm0ljEWy0 vQF3hhvYOrVqIgC8Edzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTSvU-003NDN-2r; Tue, 08 Aug 2023 20:03:32 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTSvS-003NCi-0w for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 20:03:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 974A062BE6; Tue, 8 Aug 2023 20:03:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 918EEC433C7; Tue, 8 Aug 2023 20:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691525009; bh=XieZPduHjyDSjvr/8gZ88ZdbCP4k+VL3yfyNd86jhhw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dNjflAS3B1mZjhgu4XYMPMrOknEEnqRQ4UnDUtmF/wdZkTf9wwfnvuB025/6ZCMel 3MO9DSNyp3jMcES/AJwS2n6lxQiS66Rstw0RZalS34IIkFvpOcd+R0AL29usX7IkyI H+tKnwu0tcbrs0c/2n3u0aGS9F15ZEiH0arFKVnqTBE7nSlx8t1aIJdCgW+JpoF6WG dgNA3g1eIEaVHlaxYaItysPNSn31LkY9UeqnNtrtLkKDUheCfrraKEN0gpW2DDXcwR kwuqmYFMLnjW4HuSL63sL9Pz4EvfOZGLaNkTjlookm6FW6SDTGD9X/QEP4SB1iKdR7 6z8zDBRKM7wSw== Date: Tue, 8 Aug 2023 13:03:27 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Simon Horman Subject: Re: [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML Message-ID: <20230808130327.5638d15b@kernel.org> In-Reply-To: References: <20230804190454.394062-1-vadim.fedorenko@linux.dev> <20230804190454.394062-3-vadim.fedorenko@linux.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_130330_377149_B621F0BC X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 7 Aug 2023 22:25:25 +0100 Vadim Fedorenko wrote: > Well, in my case after rebasing on latest net-next I got just part of > your diff: > > diff --git a/drivers/dpll/dpll_nl.c b/drivers/dpll/dpll_nl.c > index ff3f55f0ca94..638e21a9a06d 100644 > --- a/drivers/dpll/dpll_nl.c > +++ b/drivers/dpll/dpll_nl.c > @@ -17,7 +17,6 @@ const struct nla_policy > dpll_pin_parent_device_nl_policy[DPLL_A_PIN_STATE + 1] = > [DPLL_A_PIN_PRIO] = { .type = NLA_U32, }, > [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3), > }; > - Uh, missing cw.nl() somewhere. Will add. > const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE > + 1] = { > [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3), > [DPLL_A_PIN_ID] = { .type = NLA_U32, }, > > > The "/* private: */" comment was added to the generator after Simon's > comment. But I'll include this part into the next version. We only added private for enum masks, I'll send a patch for nlattrs. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel