From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FB5EC04A6A for ; Tue, 8 Aug 2023 20:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nqzlYBrXiwPxphri8SnxmEITuE6G66KYtECeBOsON8U=; b=llmFAQcuEVBixg 7tv9tBOxJU0Wh1K6zhnuxlqHIZ7XUCGy6nFwUTa9+gqD9bG1Ydw5gByjWYnHpKXeIkAJMCdxjmolZ 4cstol6E+Xy+KIvLxbeIlG0/rlBf2ZesBCpKm39VpmmJsNTGKyVEhWJY4knd5z8Ufvrvn3g+Kp/9x zeBTsR6KzqPDmo42fsNZ7SGHZHdonWKSdPvTmNhUQH26cqRLnXTgSz0Q4eRzGnEa2LutHpDPkcDQS rnEKOfHyK8t8msQVcai01OrTrSdirK7oLAP8G6vzzZ0IUO00koZa1YjL+ZzKcYS5Ke7/NK2s5yKDn sz5yVljJCWYkCE9fqt+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTSyE-003NW9-1E; Tue, 08 Aug 2023 20:06:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTSyB-003NVo-2T for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 20:06:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 24F0462C15; Tue, 8 Aug 2023 20:06:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12AD2C433C7; Tue, 8 Aug 2023 20:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691525178; bh=EXXgYeO8+2thyLJnvnLv8j6A+askNI7McKgPFzgsrAI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XuZ9+hENrre4giva7n00N0bFg27pLNhnPyPqDyGlMhYcKysZHD7s+wB5GQ9gKWMhr xLEBZEtxy4Ijq280LlshZ0OQtc5bdOBJaYsmdcRVVjYgwBmCDKYBR3TcdMZV9c8G8L IvwUuNxIeLXI3+ekfhqB1C/LmZKr6JOPykHbiaQvHxJ8f/hfZgIXJ3/W73BAC6hI/X Xg+8ejZndgpq9pr3s9d/dV4IDGbuok/uNo2SrySkFxU60DkqseTlu+lEE0WQusCotG 4NUeCjA6QmY4IlkytAP5Gja51o1bFOHrk2BMskSBjBMwWkcdvEcpmhPs0YTxVf8+gn pDR0jFGaIeuUQ== Date: Tue, 8 Aug 2023 13:06:17 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Simon Horman Subject: Re: [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML Message-ID: <20230808130617.5ad74486@kernel.org> In-Reply-To: <20230808130327.5638d15b@kernel.org> References: <20230804190454.394062-1-vadim.fedorenko@linux.dev> <20230804190454.394062-3-vadim.fedorenko@linux.dev> <20230808130327.5638d15b@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_130619_849558_99F58977 X-CRM114-Status: GOOD ( 11.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 8 Aug 2023 13:03:27 -0700 Jakub Kicinski wrote: > > const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE > > + 1] = { > > [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3), > > [DPLL_A_PIN_ID] = { .type = NLA_U32, }, > > > > > > The "/* private: */" comment was added to the generator after Simon's > > comment. But I'll include this part into the next version. > > We only added private for enum masks, I'll send a patch for nlattrs. On closer look these have no kdoc, so the priv markings are not necessary, dropping them sounds right. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel