From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7068C001B0 for ; Tue, 8 Aug 2023 13:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i+D5xiJ8I0uAfhsDxqLqcSZeR+MEg3oFj+0iQRvdWa0=; b=Qzc28gTBEi/qru HI6F16LxPwwVAJW3HzdF8/QYUyKXYmb7MIaa3rHXwCZSF9NydQqAJeOWM21KMnVCZiBB+zA5U3DtK S1Ry4o2i/n3OqaCNlIhnK7XGWNQ0Oj5QUWRiS8SWoMozo/W5FXLVDGgOvdMvBDZATmxlEM0hafVA6 ZgtUL9Lul1wtkixAl95TG4LHolgVask/QD/Rl2EpdoxRX08JMcZlxA7QXFdrOQS6Af3AhZydhBMi4 r7pYsXjoDL3TxbById+580FiiW+bWNJwHDZyNEAxQhpIXTirxOUCDfmKtjbvl8E44CuYqgYt38v/X D5i83pnC1qp1e1YdES8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTMZv-002cvT-0E; Tue, 08 Aug 2023 13:16:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTMZm-002cu6-1b for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 13:16:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A1846624EE; Tue, 8 Aug 2023 13:16:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB2D1C433C9; Tue, 8 Aug 2023 13:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691500601; bh=5HdjcmKD/DQnK+PC/B1oWrXcxFsNCM0isHGN4n48ljo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f/Hvi2ZSjsN1vmWcYGRpOySS8zeiHsSpCpDR3uvCXXd50YjcrAz5tTPmxUiFWTDPW Sq6fw0RSRS8NKDEqGJ7iA5rbmD0n6XGS4s7+HBvq/dptKYZPlKZX5JR/BZ7CyYe1lB lMIMns3OCURTBjh0rpXW+1WQRly+pk4rKm2tW0HLSJdDRbxpEUJO+LyyBKC0PdhLNB D9rDG7rZqHcrsulC9nXWuzZ6p6IQki0OVkRQWYpsYSnRSnlpkHFaTsjJkzA4uFwcaS B6pJhPL3zSf2/d2TKpTIjSJTj7pM6E10gSN0fpqaPqTZ4M1GHs+mkPb0dCiREn8cFd FQRtN0pMLgoDQ== Date: Tue, 8 Aug 2023 14:16:35 +0100 From: Will Deacon To: Suzuki K Poulose Cc: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, yangyicong@huawei.com, Sami Mujawar , Catalin Marinas , Mark Rutland , Mike Leach , Leo Yan , Alexander Shishkin , James Clark , coresight@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 1/4] arm_pmu: acpi: Refactor arm_spe_acpi_register_device() Message-ID: <20230808131634.GA2369@willie-the-truck> References: <20230808082247.383405-1-anshuman.khandual@arm.com> <20230808082247.383405-2-anshuman.khandual@arm.com> <8bef9c5a-eede-f78f-4418-da10c99a5bef@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8bef9c5a-eede-f78f-4418-da10c99a5bef@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_061642_633861_767AD892 X-CRM114-Status: GOOD ( 29.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 08, 2023 at 09:48:16AM +0100, Suzuki K Poulose wrote: > On 08/08/2023 09:22, Anshuman Khandual wrote: > > Sanity checking all the GICC tables for same interrupt number, and ensuring > > a homogeneous ACPI based machine, could be used for other platform devices > > as well. Hence this refactors arm_spe_acpi_register_device() into a common > > helper arm_acpi_register_pmu_device(). > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Mark Rutland > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > Co-developed-by: Will Deacon > > Signed-off-by: Will Deacon > > Signed-off-by: Anshuman Khandual > > --- > > drivers/perf/arm_pmu_acpi.c | 105 ++++++++++++++++++++++-------------- > > 1 file changed, 65 insertions(+), 40 deletions(-) > > > > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c > > index 90815ad762eb..72454bef2a70 100644 > > --- a/drivers/perf/arm_pmu_acpi.c > > +++ b/drivers/perf/arm_pmu_acpi.c > > @@ -69,6 +69,63 @@ static void arm_pmu_acpi_unregister_irq(int cpu) > > acpi_unregister_gsi(gsi); > > } > > +static int __maybe_unused > > +arm_acpi_register_pmu_device(struct platform_device *pdev, u8 len, > > + u16 (*parse_gsi)(struct acpi_madt_generic_interrupt *)) > > +{ > > + int cpu, this_hetid, hetid, irq, ret; > > + u16 this_gsi, gsi = 0; > > + > > + /* > > + * Ensure that platform device must have IORESOURCE_IRQ > > + * resource to hold gsi interrupt. > > + */ > > + if (pdev->num_resources != 1) > > + return -ENXIO; > > + > > + if (pdev->resource[0].flags != IORESOURCE_IRQ) > > + return -ENXIO; > > + > > + /* > > + * Sanity check all the GICC tables for the same interrupt > > + * number. For now, only support homogeneous ACPI machines. > > + */ > > + for_each_possible_cpu(cpu) { > > + struct acpi_madt_generic_interrupt *gicc; > > + > > + gicc = acpi_cpu_get_madt_gicc(cpu); > > + if (gicc->header.length < len) > > + return gsi ? -ENXIO : 0; > > + > > + this_gsi = parse_gsi(gicc); > > + if (!this_gsi) > > + return gsi ? -ENXIO : 0; > > + > > + this_hetid = find_acpi_cpu_topology_hetero_id(cpu); > > + if (!gsi) { > > + hetid = this_hetid; > > + gsi = this_gsi; > > + } else if (hetid != this_hetid || gsi != this_gsi) { > > + pr_warn("ACPI: %s: must be homogeneous\n", pdev->name); > > + return -ENXIO; > > + } > > + } > > + > > + irq = acpi_register_gsi(NULL, gsi, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_HIGH); > > + if (irq < 0) { > > + pr_warn("ACPI: %s Unable to register interrupt: %d\n", pdev->name, gsi); > > + return -ENXIO; > > + } > > + > > + pdev->resource[0].start = irq; > > + ret = platform_device_register(pdev); > > + if (ret < 0) { > > + pr_warn("ACPI: %s: Unable to register device\n", pdev->name); > > + acpi_unregister_gsi(gsi); > > + } > > + return ret; > > A postivie return value here could confuse the caller. Also, with my comment > below, we don't really need to return something from here. How does this return a positive value? > > + int ret = arm_acpi_register_pmu_device(&spe_dev, ACPI_MADT_GICC_SPE, > > + arm_spe_parse_gsi); > > + if (ret) > > pr_warn("ACPI: SPE: Unable to register device\n"); > > With this change, a system without SPE interrupt description always > generates the above message. Is this intended ? If there are no irqs, why doesn't this return 0? arm_acpi_register_pmu_device() should only fail if either: - The static resources passed in are broken - The tables are not homogeneous - We fail to register the interrupt so something is amiss. > Could we not drop the above message as all the other possible error > scenarios are reported. We could simply make the above helper void, see my > comment above. I disagree. If the ACPI tables are borked, we should print a message saying so. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel