From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90DFFC41513 for ; Tue, 8 Aug 2023 15:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=ieIfDcu0kYwlpmN7ndJD/lAymLSOaG8yHlQzls5ZDXU=; b=wlwnrfZJmwQaTN ghhlAPREylaVC7wo6RtSij6YQ9K2ExYnNioB7JWYKK1KJ8a5nK3po1sSOtCYMRhd0OpZFb18D2KgH hT+Qnz9xM8oYXvgEsqXNLu0vjYSrFGK3+K95/egkNgOuxnD6D34vWvMvSD4FYfs+IxMCrrK19001x 7yXhMb6niiL8Zka0vGHjX3SJ2A2o31CdmRkItA0tbYr/+4EVJlDq5pzW9DXQfkhbMKDBHQ6sRUnGy eUdMoZp8PPA9jS2JAeYmqYefSVYgtPX9PXxr0MwSBuuzVUwQOb44cSjWYGI2fATg1mmmh0qdNmv0V oeiZMsWY6rPAeZECgkoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTOxu-002qQH-1E; Tue, 08 Aug 2023 15:49:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTOxq-002qPt-2e for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 15:49:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 49E20625C9; Tue, 8 Aug 2023 15:49:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 739F2C433C8; Tue, 8 Aug 2023 15:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691509781; bh=PUAWonAUPbtW2YJxANM18kHRL54qijZd61xXDG7EdtQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Co+Az8nrKuQemD9Hz1qRzv4qPtBes76iELh6VLqx6l/qlo5Dwv/Xtch1YbXDDR7G7 xf6Nfye0WYpGVEKA1iDIVOMaloU7LBFqjzfoGIrNU2DL/evE3KDs/Nj4ULTtAwdwf3 kHjm5TTuzx7+/piJij9Y+gpYaOuWKUOE07l2rpLPWriQeJSCTJ8TYagvSTw6YGprWH 12tjXJV3bj/cmdeHDDsVk7WAQxuMNIW+nNqvkqKyr998HwSPUDP/AxyDSSpavuM+CX xxQ7hTl6nrRM/4/Uc9F+WDwPi7zfE/nQOdFewyMB9fGVyiv5Xcsm2dPQdDH1e9hRgt krg455JAeafCw== Date: Tue, 8 Aug 2023 10:49:39 -0500 From: Bjorn Helgaas To: Thippeswamy Havalige Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org, bhelgaas@google.com, krzysztof.kozlowski@linaro.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, lpieralisi@kernel.org, bharat.kumar.gogada@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] PCI: xilinx-nwl: Increase ECAM size to accommodate 256 buses. Message-ID: <20230808154939.GA313654@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230808103733.93707-4-thippeswamy.havalige@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_084942_920018_07293787 X-CRM114-Status: GOOD ( 21.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 08, 2023 at 04:07:33PM +0530, Thippeswamy Havalige wrote: > Our controller is expecting ECAM size to be programmed by software. By > programming "NWL_ECAM_VALUE_DEFAULT 12" controller can access up to 16MB > ECAM region which is used to detect 16 buses, so by updating > "NWL_ECAM_VALUE_DEFAULT" to 16 so that controller can access up to 256MB > ECAM region to detect 256 buses. > > Signed-off-by: Thippeswamy Havalige > Signed-off-by: Bharat Kumar Gogada 1) I'm still concerned that this adds a revlock with the corresponding DT change. Is that acceptable? Should it be mentioned in the commit log? 2) Lorenzo or Krzysztof, if/when you apply this, please drop the period at the end of the subject line. I've mentioned it several times to no avail. > --- > changes in v2: > - Update this changes in a seperate patch. > --- > drivers/pci/controller/pcie-xilinx-nwl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c > index a73554e..b515019 100644 > --- a/drivers/pci/controller/pcie-xilinx-nwl.c > +++ b/drivers/pci/controller/pcie-xilinx-nwl.c > @@ -126,7 +126,7 @@ > #define E_ECAM_CR_ENABLE BIT(0) > #define E_ECAM_SIZE_LOC GENMASK(20, 16) > #define E_ECAM_SIZE_SHIFT 16 > -#define NWL_ECAM_VALUE_DEFAULT 12 > +#define NWL_ECAM_VALUE_DEFAULT 16 > > #define CFG_DMA_REG_BAR GENMASK(2, 0) > #define CFG_PCIE_CACHE GENMASK(7, 0) > -- > 1.8.3.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel