From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69490C04A6A for ; Tue, 8 Aug 2023 16:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=hMoMwhNKM9rbrOUPcZg7O5rOIkAhUYgku/l6XCWD3gE=; b=w66+OAtBWnTYoS I7OVKoUVkaL1j/j4mD8Sn8XehgzXZ+oCUbqxNHhtQY1BWjEwehSj4VrcbpuR6yXJ+cJlB5VlP4n3v BVo3dph7kDdvOerwuB5ATyr7CrdUfYi1fjuVIljFeTU129K94XyF1rqHBUGmftTE231S5OEyckZ4x fycGtcfHE7nm4Ep3VQIuplHgzPQ/x7EadVvQ/nlbk7O5bb6eqRKUYZbDzWpx+a6OVJPteIN2q2EX4 kjl2jdmbU4gN75AnP+oKclLGmygIuOicM+kNwwnO9WCfeZthE8cgeMjr30bsthRMLVC0yOfSOlm8Y 1S6oVGazTwSI1N520Dcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTPXV-002yYt-0E; Tue, 08 Aug 2023 16:26:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTPXS-002yYI-1O for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 16:26:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E06516242B; Tue, 8 Aug 2023 16:26:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71430C433B7; Tue, 8 Aug 2023 16:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691511989; bh=zE/uSYeRloetY2ZRpWdkDWpaPNmX2Vprz3+Hc9pFNr8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Sjdz06csNVGed3j66FD4E/PDkuW6p4aJDFTASGiBQPnqYPMIcBAKLqdysbMQqSGSj Vr60OZ3318kwP8ODF2E8XcwylDOyDCIuuhhha7vfn24K0HNilLiRd0p0TJvmmCDf4q PzutiWTgmR9s2XhbbObOl+ZnWfKF21ZcB4nOC1LkkOdXYuzjK6McaPjFAwvimVJ7qc 4sbBlNPB6fy3zfBF+yxgbTOtoRHWlaAzr7V6ZkLGLQsoAeTb0Dc81xM0/putFxpyCC eGLnfxkHj0+g+njPF9/QrW+TT66W4OV1B3dqcx58PwF4rvi83hx3sT63JZgC2AUHyu aV2sreGd2MOKg== Date: Tue, 8 Aug 2023 11:26:27 -0500 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: "Russell King (Oracle)" , Lorenzo Pieralisi , Bjorn Helgaas , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: mvebu: Mark driver as BROKEN Message-ID: <20230808162627.GA314706@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230808072605.n3rjfsxuogza7qth@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_092630_514515_DB64B7B9 X-CRM114-Status: GOOD ( 16.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+cc linux-arm-kernel, beginning of thread: https://lore.kernel.org/r/20230114164125.1298-1-pali@kernel.org] On Tue, Aug 08, 2023 at 09:26:05AM +0200, Pali Roh=E1r wrote: > On Friday 04 August 2023 12:35:13 Russell King (Oracle) wrote: > ... > > For example, I have an Atheros PCIe WiFi card in an Armada 388 Clearfog > > platform, and this works fine. > > = > > Uwe has a SATA controller for a bunch of disks in an Armada 370 based > > NAS platform that is connected to PCIe, and removing PCIe support > > effectively makes his platform utterly useless. > > = > > Please revert this patch. > = > Please do not revert it, instead start fixing problems. We know that like all the other drivers, the mvebu driver isn't perfect. But I don't think effectively removing the driver completely helps anybody. If people try to use it and notice problems, we have a chance to try to fix them. Or maybe I'm missing your point. I think you're suggesting that we keep pci-mvebu in the tree but unselectable because it depends on CONFIG_BROKEN. What would be the advantage of doing that? Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel