From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Da Xue <da@libre.computer>
Cc: Luke Lu <luke.lu@libre.computer>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: meson-g12a: do post init to fix broken usb after resumption
Date: Tue, 8 Aug 2023 08:10:14 +0200 [thread overview]
Message-ID: <2023080832-plated-slackness-20e4@gregkh> (raw)
In-Reply-To: <CACqvRUaK_Pj1DT4QY+YpKmvGeFqmM8KPcYWqTLNJoUJJaEbFAg@mail.gmail.com>
On Tue, Aug 08, 2023 at 01:33:45AM -0400, Da Xue wrote:
> On Tue, Aug 8, 2023 at 12:56 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Aug 08, 2023 at 03:25:10AM +0000, Luke Lu wrote:
> > > Device connected to usb otg port of GXL-based boards can not be
> > > recognised after resumption, doesn't recover even if disconnect and
> > > reconnect the device. dmesg shows it disconnects during resumption.
> > >
> > > [ 41.492911] usb 1-2: USB disconnect, device number 3
> > > [ 41.499346] usb 1-2: unregistering device
> > > [ 41.511939] usb 1-2: unregistering interface 1-2:1.0
> > >
> > > Calling usb_post_init() will fix this issue, and it's tested and
> > > verified on libretech's aml-s905x-cc board.
> > >
> > > Signed-off-by: Luke Lu <luke.lu@libre.computer>
> >
> > What commit id does this fix? Should it also go to stable kernels?
>
> Hi Greg,
>
> Suspend device tree flag has not been enabled in-tree for the Amlogic
> GXL (S805X/S905X/S905D) series due it having PSCI 0.2 and thus never
> untested. Most of the suspend resume code was only tested on newer
> G12A/B series.
>
> This and "[PATCH v3] net: phy: meson-gxl: implement
> meson_gxl_phy_resume()" fixes USB and Ethernet after resume. HDMI
> requires another fix.
>
> It would be great if they could go into stable since we are carrying
> these two patches in our tree on 6.1 and they're applicable back to
> 5.4 but I am not sure what the criteria is.
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
has the criteria. If you think it should go there, then please resend
with a cc: stable tag in the signed-off-by area.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-08 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 3:25 [PATCH] usb: dwc3: meson-g12a: do post init to fix broken usb after resumption Luke Lu
2023-08-08 4:56 ` Greg Kroah-Hartman
2023-08-08 5:33 ` Da Xue
2023-08-08 6:10 ` Greg Kroah-Hartman [this message]
2023-08-08 6:09 ` Luke Lu
2023-08-08 8:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080832-plated-slackness-20e4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=da@libre.computer \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luke.lu@libre.computer \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).