From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Dhruva Gole <d-gole@ti.com>,
linux-omap@vger.kernel.org, Dave Gerlach <d-gerlach@ti.com>,
Faiz Abbas <faiz_abbas@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Keerthy <j-keerthy@ti.com>, Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] bus: ti-sysc: Fix build warning for 64-bit build
Date: Wed, 9 Aug 2023 10:27:20 +0300 [thread overview]
Message-ID: <20230809072720.GC11676@atomide.com> (raw)
In-Reply-To: <20230805172325.4vjb4lb3vtu3dgfe@commodity>
* Nishanth Menon <nm@ti.com> [230805 17:23]:
> On 10:47-20230805, Dhruva Gole wrote:
> > On Aug 04, 2023 at 13:38:57 +0300, Tony Lindgren wrote:
> > > match = soc_device_match(sysc_soc_match);
> > > if (match && match->data)
> > > - sysc_soc->soc = (int)match->data;
> > > + sysc_soc->soc = (unsigned long)match->data;
> >
> > Reviewed-by: Dhruva Gole <d-gole@ti.com>
>
> Dumb q: is'nt this an enum? Is it better to cast it as (enum
> sysc_soc)match->data ?
Good idea, will update.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-08-09 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 10:38 [PATCH 1/3] bus: ti-sysc: Fix build warning for 64-bit build Tony Lindgren
2023-08-04 10:38 ` [PATCH 2/3] bus: ti-sysc: Build driver for TI K3 SoCs Tony Lindgren
2023-08-05 5:20 ` Dhruva Gole
2023-08-09 9:26 ` Tony Lindgren
2023-08-04 10:38 ` [PATCH 3/3] bus: ti-sysc: Configure uart quirks for k3 SoC Tony Lindgren
2023-08-05 5:17 ` [PATCH 1/3] bus: ti-sysc: Fix build warning for 64-bit build Dhruva Gole
2023-08-05 17:23 ` Nishanth Menon
2023-08-09 7:27 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809072720.GC11676@atomide.com \
--to=tony@atomide.com \
--cc=d-gerlach@ti.com \
--cc=d-gole@ti.com \
--cc=faiz_abbas@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=j-keerthy@ti.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).