From: Dhruva Gole <d-gole@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Keerthy <j-keerthy@ti.com>, Kevin Hilman <khilman@baylibre.com>,
Nishanth Menon <nm@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] bus: ti-sysc: Fix a build warning with W=1 for sysconfig
Date: Wed, 9 Aug 2023 15:41:01 +0530 [thread overview]
Message-ID: <20230809101101.7pbe7fhrlfcblcqk@dhruva> (raw)
In-Reply-To: <20230809095633.34025-1-tony@atomide.com>
On Aug 09, 2023 at 12:56:33 +0300, Tony Lindgren wrote:
> Dhruva reported a build warning with W=1 for "Function parameter or member
> 'sysconfig' not described in 'sysc'". Let's document sysconfig to fix this.
>
> Reported-by: Dhruva Gole <d-gole@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
Probably best to include a Fixes: commit no?
> drivers/bus/ti-sysc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -109,6 +109,7 @@ static const char * const clock_names[SYSC_MAX_CLOCKS] = {
> * @cookie: data used by legacy platform callbacks
> * @name: name if available
> * @revision: interconnect target module revision
> + * @sysconfig: saved sysconfig register value
> * @reserved: target module is reserved and already in use
> * @enabled: sysc runtime enabled status
> * @needs_resume: runtime resume needed on resume from suspend
> --
> 2.41.0
--
Best regards,
Dhruva Gole <d-gole@ti.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-09 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 9:56 [PATCH] bus: ti-sysc: Fix a build warning with W=1 for sysconfig Tony Lindgren
2023-08-09 10:11 ` Dhruva Gole [this message]
2023-08-10 6:23 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809101101.7pbe7fhrlfcblcqk@dhruva \
--to=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=j-keerthy@ti.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox