Re: [PATCH v3 1/5] dt-bindings: net: Add ICSS IEP

Conor Dooley
2023-08-09T21:37:57Z

[-- Attachment #1.1: Type: text/plain, Size: 2032 bytes --]

Hey,

On Wed, Aug 09, 2023 at 05:19:02PM +0530, MD Danish Anwar wrote:
> Add DT binding documentation for ICSS IEP module.
>
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
> new file mode 100644
> index 000000000000..adae240cfd53
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module

Does the module here refer to the hw component or to the linux kernel
module?

> +
> +maintainers:
> + - Md Danish Anwar <danishanwar@ti.com>
> +
> +properties:
> + compatible:
> + enum:
> + - ti,am654-icss-iep # for all TI K3 SoCs

*sigh* Please at least give me a chance to reply to the conversation on
the previous versions of the series before sending more, that's the
second time with this series :/
Right now this looks worse to me than what we started with given the
comment is even broader. I have not changed my mind re: what I said on
the previous version.

Thanks,
Conor.

> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description: phandle to the IEP source clock
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + icssg0_iep0: iep@2e000 {
> + compatible = "ti,am654-icss-iep";
> + reg = <0x2e000 0x1000>;
> + clocks = <&icssg0_iepclk_mux>;
> + };
> --
> 2.34.1
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]