Re: [EXTERNAL] Re: [PATCH v3 1/5] dt-bindings: net: Add ICSS IEP

Conor Dooley
2023-08-10T12:54:02Z

[-- Attachment #1.1: Type: text/plain, Size: 2851 bytes --]

On Thu, Aug 10, 2023 at 03:23:11PM +0530, Md Danish Anwar wrote:
> On 10/08/23 3:07 am, Conor Dooley wrote:
> > On Wed, Aug 09, 2023 at 05:19:02PM +0530, MD Danish Anwar wrote:
> >> Add DT binding documentation for ICSS IEP module.
> >>
> >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> >> ---
> >> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++
> >> 1 file changed, 37 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
> >> new file mode 100644
> >> index 000000000000..adae240cfd53
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
> >> @@ -0,0 +1,37 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module
> >
> > Does the module here refer to the hw component or to the linux kernel
> > module?
> >
>
> The module here refers to the hardware component.

Sweet, thanks.

> >> +
> >> +maintainers:
> >> + - Md Danish Anwar <danishanwar@ti.com>
> >> +
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - ti,am654-icss-iep # for all TI K3 SoCs
> >
> > *sigh* Please at least give me a chance to reply to the conversation on
> > the previous versions of the series before sending more, that's the
> > second time with this series :/
>
> My bad, I should have waited for your response. I will hold on posting next
> version until your response is received.
>
> > Right now this looks worse to me than what we started with given the
> > comment is even broader. I have not changed my mind re: what I said on
> > the previous version.
> >
>
> OK, so in the previous version [1] your reply was to have specific compatibles
> as bindings with "ti-am654-icss-iep" as a fall back. I will go with this only.
>
> Does the below looks good to you? Here "ti,am642-icss-iep" and
> "ti,j721e-icss-iep" are different compatibles for different SoCs where as
> "ti,am654-icss-iep" is the fall back. Compatible "ti,am654-icss-iep" will go in
> the driver.
>
> properties:
> compatible:
> oneOf:
> - items:
> - enum:
> - ti,am642-icss-iep
> - ti,j721e-icss-iep
> - const: ti,am654-icss-iep
>
> - items:
> - const: ti,am654-icss-iep

This one doesn't need to be an items list, since there is only one item.
It should be able to just be const:. I much prefer this approach.

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]