From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E54C6EB64DD for ; Wed, 9 Aug 2023 12:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZhNfWCENv3pk3zVUKiz4XLmy5AABG1Xl+2kucEq2SPo=; b=aiogVm4boMxa0s k64RI4BhFVYa51mCxLnBNYu9YZdTGt/uPhWaMYdt0e6s8UbdYZ4oP30TsuCJBvms+vVjgevQnC+pN suct1hY+ffyVH0U3vDT1rwEGGW+gIdQ9vpUcLrWxN8iRq/YlCjGpg29DL+UhN9wWqihCTegnHZ8uL GO93gnnjRgKP9LoHGrgGul2Ku7slK5mYUmTwaZ+Ue+PepbBQhSP1Co0OQJUN68zrGYJea5byqScb5 BBuf2VlUtb0uPNjSnLiE/z8TQtXTW0G6gmxRuRFBqcvWkWQRPvTwXejNSjqnkSOsPb0x5l7kk56yN VFS2opIZqiwKNQ6dLWoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTi1k-004reD-0r; Wed, 09 Aug 2023 12:11:00 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTi1h-004rdc-1B for linux-arm-kernel@lists.infradead.org; Wed, 09 Aug 2023 12:10:58 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 379CAbFo113161; Wed, 9 Aug 2023 07:10:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691583037; bh=re65MTxKEku1CWbBHlZ76/CLi9I8PcInZ60C3ZZByjc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Bv9x365T+O34SE1SSqTHLKFFQl1iSQtTl2PAe/znSVLSnf/jBZrIwTj4dHNB+BrcP GCt/+Hkd1AcnTWI1a+Kg/e2SCf1PBKI2z1S74mwVK7I2NO00FfsfFmoDXEBd8rZ7k2 VCHaK0sA8/pZ5q+HzBo7j+hRZWXFru5t6p0MBsBs= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 379CAbrM032451 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 9 Aug 2023 07:10:37 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 9 Aug 2023 07:10:37 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 9 Aug 2023 07:10:37 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 379CAamo031271; Wed, 9 Aug 2023 07:10:36 -0500 Date: Wed, 9 Aug 2023 17:40:36 +0530 From: Dhruva Gole To: Zhang Zekun CC: , , , Dhruva Gole Subject: Re: [PATCH] soc: ti: Use devm_platform_ioremap_resource_byname simplify logic Message-ID: <20230809121036.gtdplfpi7v75jusp@dhruva> References: <20230809081523.26196-1-zhangzekun11@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230809081523.26196-1-zhangzekun11@huawei.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230809_051057_506500_B7B51D6F X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Aug 09, 2023 at 16:15:23 +0800, Zhang Zekun wrote: > platform_get_resource_byname() and devm_ioremap_resource() can be > replaced by devm_platform_ioremap_resource_byname(), which can > simplify the code logic a bit, No functional change here. Ack, have seen multiple such series in past as well like here: commit 79caf207d6699419e83ac150accc5c80c5719b47 "phy: ti: convert to devm_platform_ioremap_resource(_byname)" > > Signed-off-by: Zhang Zekun > --- > drivers/soc/ti/k3-ringacc.c | 19 ++++++------------- > 1 file changed, 6 insertions(+), 13 deletions(-) > > diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c > index 4c1353616b72..148f54d9691d 100644 > --- a/drivers/soc/ti/k3-ringacc.c > +++ b/drivers/soc/ti/k3-ringacc.c > @@ -1368,7 +1368,6 @@ static int k3_ringacc_init(struct platform_device *pdev, > const struct soc_device_attribute *soc; > void __iomem *base_fifo, *base_rt; > struct device *dev = &pdev->dev; > - struct resource *res; > int ret, i; > > dev->msi.domain = of_msi_get_domain(dev, dev->of_node, > @@ -1387,24 +1386,20 @@ static int k3_ringacc_init(struct platform_device *pdev, > ringacc->dma_ring_reset_quirk = soc_data->dma_ring_reset_quirk; > } > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rt"); > - base_rt = devm_ioremap_resource(dev, res); > + base_rt = devm_platform_ioremap_resource_byname(pdev, "rt"); > if (IS_ERR(base_rt)) > return PTR_ERR(base_rt); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "fifos"); > - base_fifo = devm_ioremap_resource(dev, res); > + base_fifo = devm_platform_ioremap_resource_byname(pdev, "fifos"); > if (IS_ERR(base_fifo)) > return PTR_ERR(base_fifo); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "proxy_gcfg"); > - ringacc->proxy_gcfg = devm_ioremap_resource(dev, res); > + ringacc->proxy_gcfg = devm_platform_ioremap_resource_byname(pdev, "proxy_gcfg"); > if (IS_ERR(ringacc->proxy_gcfg)) > return PTR_ERR(ringacc->proxy_gcfg); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "proxy_target"); > - ringacc->proxy_target_base = devm_ioremap_resource(dev, res); > + ringacc->proxy_target_base = devm_platform_ioremap_resource_byname(pdev, > + "proxy_target"); > if (IS_ERR(ringacc->proxy_target_base)) > return PTR_ERR(ringacc->proxy_target_base); > > @@ -1471,7 +1466,6 @@ struct k3_ringacc *k3_ringacc_dmarings_init(struct platform_device *pdev, > struct device *dev = &pdev->dev; > struct k3_ringacc *ringacc; > void __iomem *base_rt; > - struct resource *res; > int i; > > ringacc = devm_kzalloc(dev, sizeof(*ringacc), GFP_KERNEL); > @@ -1486,8 +1480,7 @@ struct k3_ringacc *k3_ringacc_dmarings_init(struct platform_device *pdev, > > mutex_init(&ringacc->req_lock); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ringrt"); > - base_rt = devm_ioremap_resource(dev, res); > + base_rt = devm_platform_ioremap_resource_byname(pdev, "ringrt"); > if (IS_ERR(base_rt)) > return ERR_CAST(base_rt); [...] I don't see any major issues, Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel