From: Andi Shyti <andi.shyti@kernel.org>
To: Liao Chang <liaochang1@huawei.com>
Cc: florian.fainelli@broadcom.com, rjui@broadcom.com,
sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
yangyicong@hisilicon.com, aisheng.dong@nxp.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org,
rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com,
linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe function
Date: Wed, 9 Aug 2023 21:21:17 +0200 [thread overview]
Message-ID: <20230809192117.h7rn6vwmvxdnkr2a@intel.intel> (raw)
In-Reply-To: <20230808012954.1643834-10-liaochang1@huawei.com>
Hi Liao,
On Tue, Aug 08, 2023 at 09:29:54AM +0800, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
>
> Signed-off-by: Liao Chang <liaochang1@huawei.com>
After some discussions and time, I think it's right to r-b this
patch. If you agree more with Krzysztof, feel free to follow his
recommendation and send another version otherwise I will go ahead
and take this series in my branch. I do not really mind, both
arguments are valid.
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-09 19:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 1:29 [PATCH v3 0/9] Use dev_err_probe in i2c probe function Liao Chang
2023-08-08 1:29 ` [PATCH v3 1/9] i2c: bcm2835: Use dev_err_probe in " Liao Chang
2023-08-08 9:37 ` Markus Elfring
2023-08-08 11:31 ` Andi Shyti
2023-08-08 1:29 ` [PATCH v3 2/9] i2c: mlxbf: " Liao Chang
2023-08-08 8:36 ` Krzysztof Kozlowski
2023-08-08 11:29 ` Andi Shyti
2023-08-08 11:31 ` Krzysztof Kozlowski
2023-08-08 11:47 ` Andi Shyti
2023-08-08 15:55 ` Krzysztof Kozlowski
2023-08-09 8:02 ` Andi Shyti
2023-08-08 10:32 ` Markus Elfring
2023-08-08 1:29 ` [PATCH v3 3/9] i2c: xlp9xx: " Liao Chang
2023-08-08 8:36 ` Krzysztof Kozlowski
2023-08-08 1:29 ` [PATCH v3 4/9] i2c: hisi: " Liao Chang
2023-08-08 8:36 ` Krzysztof Kozlowski
2023-08-08 1:29 ` [PATCH v3 5/9] i2c: qcom-cci: " Liao Chang
2023-08-10 15:06 ` Bjorn Andersson
2023-08-08 1:29 ` [PATCH v3 6/9] i2c: pxa: " Liao Chang
2023-08-08 1:29 ` [PATCH v3 7/9] i2c: dln2: " Liao Chang
2023-08-08 1:29 ` [PATCH v3 8/9] i2c: imx-lpi2c: " Liao Chang
2023-08-08 8:37 ` Krzysztof Kozlowski
2023-08-08 1:29 ` [PATCH v3 9/9] i2c: synquacer: " Liao Chang
2023-08-08 8:37 ` Krzysztof Kozlowski
2023-08-09 19:21 ` Andi Shyti [this message]
2023-08-10 2:33 ` Liao, Chang
2023-08-10 8:10 ` Andi Shyti
2023-08-10 8:19 ` [PATCH v3 0/9] Use dev_err_probe in i2c " Andi Shyti
2023-08-14 15:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809192117.h7rn6vwmvxdnkr2a@intel.intel \
--to=andi.shyti@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=ardb@kernel.org \
--cc=asmaa@nvidia.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=gcherian@marvell.com \
--cc=kblaiech@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=liaochang1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=loic.poulain@linaro.org \
--cc=rfoss@kernel.org \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).