From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BCC6C001DE for ; Wed, 9 Aug 2023 19:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aCcUGe16TRvuwQpo8UTI69cB9lkT5+rFirSWwK1rG0A=; b=YHCe43N1amuEy+ 0omgVbASzveDzZVCeA7N43ZQcweXOFCLEBWMQjhTpG+RZkeMEi/o6ZKEdvd3QiEiJ7E//XHElyxAi dMRRM/JTAa6leswe5EZFD1HS2R1T1ZVCVj/SWwfMvnLunsCE9nHGYixPFDfTJaVlfuhI90+ZIt2Rz GS1kzhhwXBA5SdEdm/ZCHAie4452f1v+DSkVEdQ7GUn8ktnbXqsZPFtdm23uCZDEV+1/fuGPPvgZu kGM7Rn+y5kv6LWMzR3iPqUSXM+iIiAvSN6N1IsBxyoAneVGXK9vBAMuho8U0DcFj8QzogsWaDrE7m iy3RlWjVVfzGu0HrN2kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTokL-005jBu-3B; Wed, 09 Aug 2023 19:21:29 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTokJ-005jAM-0i; Wed, 09 Aug 2023 19:21:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5500F6462C; Wed, 9 Aug 2023 19:21:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35967C433C7; Wed, 9 Aug 2023 19:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691608885; bh=TiIG4S1nRqWeK6cqm2dQQ3PwFd9Ye8wKZqV8Kz/6D1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fxaAkJN6WLJh+Tva2wUZFiB1cm3V6vzphmIuOpvtEQryz0sznmqQ4JKSoOFL4nljq NYyZFoWNZDLzi2lWbFXw5CsVaHQXB20ynXMbmM6XQ+boVSIAHcLdY12naARz7tXLNW xYmN//vwASWRG+4/UOynp7bMoyTw7ykwLy2prtyrUesejsgz8YTyknDiKeuUIZXH6q 1frE0XLQnSWn+hfv68zXyGdoVscaOC2XLPkvj4TFOhJYZxb+EuC/bPoBxRHTpVmRMD LEJkrxl2noWV5WKeusZg6rBGVKDsMwy918P72Lpk72Ds5Wsspf9VpkoiQOM4gezNu9 W0sCpQtPZBIsQ== Date: Wed, 9 Aug 2023 21:21:17 +0200 From: Andi Shyti To: Liao Chang Cc: florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe function Message-ID: <20230809192117.h7rn6vwmvxdnkr2a@intel.intel> References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-10-liaochang1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230808012954.1643834-10-liaochang1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230809_122127_304137_2EC07757 X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liao, On Tue, Aug 08, 2023 at 09:29:54AM +0800, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. > > Signed-off-by: Liao Chang After some discussions and time, I think it's right to r-b this patch. If you agree more with Krzysztof, feel free to follow his recommendation and send another version otherwise I will go ahead and take this series in my branch. I do not really mind, both arguments are valid. Reviewed-by: Andi Shyti Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel