From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3DF3C001DB for ; Thu, 10 Aug 2023 12:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:CC:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4eSpClUgf8V2piHkV5uLnPDlzE5DOKhTJdGdtsiIv5M=; b=FG+TnbHMhHDstpKkpEiCPIFr1w kgqM4qgOWbDZaKI8knWrGn0vnqLSl9J2CWze2pozmWHg/m7Gk8RAJDJTVn/aZIQviieV5CAPgIOeL M0vNy+UvxQvsfDYjhijuwokm4g8cOpubSxC/pGYaOUKcMlQf3egWPW4NYJYV5M2Kt+3HWCsJkkyrd 4O3W6ilT/io8l8qDVlvF7CVppfNLQ68d4RfEBZjhjZLLjotZyCuZbkqn/z9l12+IbUaIXqA8y//7o Np6GeEeeuYj4k98J3b4uOEbogruPx4oQCfyB4Y37yjU45D6Fm5vF6dRPYCTDjvB14/kMStFIcjz1W ft6r76/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qU5AT-007ex2-0z; Thu, 10 Aug 2023 12:53:33 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qU5AP-007evo-31 for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 12:53:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1691672009; x=1723208009; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mJ+/b00F9kPexO4v/gdgxth24IwvwYtglje3VG8O1nU=; b=OFgHyEIYKzylx11uWVXwtkHd1pec7NgU2qi6rKhJi1ZZGXNHzegV8Sc1 qoV10PdW38tFnz3U5Sr3lStWYUZCq2EiTHdVGI3YA2QQ6YH1COk5lZBUy UJUbHd0Z5bcsU8eBh0XfLX5sZ5YE/sBpCiJj5laNszw5y7G/3cjC+G3xr F6O2e5vWXom30dP7JMWTo5HNzYz+4rZKNm3the6GNvar1Fhl/cnzm1IyO 9D7QZr97hYJ0DaBJLShnFr2NR1oZSdOyPszHqSvzCH5McVlDgJbpB5Onn 2IsK/rFlBhJtNRqZ1KUtRCdWcLb5JkeeUwaw/kY7DF9RR5K0u5ePEUQ3J w==; X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="asc'?scan'208";a="229166856" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Aug 2023 05:53:24 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 10 Aug 2023 05:52:53 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 10 Aug 2023 05:52:49 -0700 Date: Thu, 10 Aug 2023 13:52:11 +0100 From: Conor Dooley To: Md Danish Anwar CC: Conor Dooley , MD Danish Anwar , Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , , , , , , , Subject: Re: [EXTERNAL] Re: [PATCH v3 1/5] dt-bindings: net: Add ICSS IEP Message-ID: <20230810-drippy-draw-8e8a63164e46@wendy> References: <20230809114906.21866-1-danishanwar@ti.com> <20230809114906.21866-2-danishanwar@ti.com> <20230809-cardboard-falsify-6cc9c09d8577@spud> <0b619ec5-9a86-a449-e8db-b12cca115b93@ti.com> MIME-Version: 1.0 In-Reply-To: <0b619ec5-9a86-a449-e8db-b12cca115b93@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_055330_034459_C938666B X-CRM114-Status: GOOD ( 27.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4486659182408102095==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4486659182408102095== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="diS/Ua0hOZdswhas" Content-Disposition: inline --diS/Ua0hOZdswhas Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 10, 2023 at 03:23:11PM +0530, Md Danish Anwar wrote: > On 10/08/23 3:07 am, Conor Dooley wrote: > > On Wed, Aug 09, 2023 at 05:19:02PM +0530, MD Danish Anwar wrote: > >> Add DT binding documentation for ICSS IEP module. > >> > >> Signed-off-by: MD Danish Anwar > >> --- > >> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ > >> 1 file changed, 37 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.= yaml > >> > >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/= Documentation/devicetree/bindings/net/ti,icss-iep.yaml > >> new file mode 100644 > >> index 000000000000..adae240cfd53 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml > >> @@ -0,0 +1,37 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) mo= dule > >=20 > > Does the module here refer to the hw component or to the linux kernel > > module? > >=20 >=20 > The module here refers to the hardware component. Sweet, thanks. > >> + > >> +maintainers: > >> + - Md Danish Anwar > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - ti,am654-icss-iep # for all TI K3 SoCs > >=20 > > *sigh* Please at least give me a chance to reply to the conversation on > > the previous versions of the series before sending more, that's the > > second time with this series :/ >=20 > My bad, I should have waited for your response. I will hold on posting ne= xt > version until your response is received. >=20 > > Right now this looks worse to me than what we started with given the > > comment is even broader. I have not changed my mind re: what I said on > > the previous version. > >=20 >=20 > OK, so in the previous version [1] your reply was to have specific compat= ibles > as bindings with "ti-am654-icss-iep" as a fall back. I will go with this = only. >=20 > Does the below looks good to you? Here "ti,am642-icss-iep" and > "ti,j721e-icss-iep" are different compatibles for different SoCs where as > "ti,am654-icss-iep" is the fall back. Compatible "ti,am654-icss-iep" will= go in > the driver. >=20 > properties: > compatible: > oneOf: > - items: > - enum: > - ti,am642-icss-iep > - ti,j721e-icss-iep > - const: ti,am654-icss-iep >=20 > - items: > - const: ti,am654-icss-iep This one doesn't need to be an items list, since there is only one item. It should be able to just be const:. I much prefer this approach. Thanks, Conor. --diS/Ua0hOZdswhas Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNTdewAKCRB4tDGHoIJi 0iMoAQCDOBl0Qa9rDfRGu4AnjpAIUepfbUnc63ThpYDzbWaJ+wD/e5Y5S1Ae5ZBa 5xbzDkOAnzsbPwqtnhkcByShucEghg4= =yxL7 -----END PGP SIGNATURE----- --diS/Ua0hOZdswhas-- --===============4486659182408102095== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4486659182408102095==--