From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 297B4C001DE for ; Thu, 10 Aug 2023 18:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iRN7MJFrfdVtO3OXY/w64l8zbPkSUzs5IhYiBe3OCsM=; b=EonjLCGPs/KQsOKaBvC6J9kOiL uutLPKDiVL2mnbDNh2WCNoQOYMT3wllwvv6jtBB+P55g1EBKpR+ADA4z3Wui+oHFz8GDUapMYdVzn bN3wpI9pg8aQUa2LIVr5zRbCtErnxJStsmnq7uecKL79egvK7fMBu2YL+/sLLQTE4yK2KT5+moaUq N8sOjSxFrs4hEUUkXBeDtu0ceR9uidDgVcdCs7VEUYcKhqAqSjKUmKeQyGPyuvKyC82tdX+jULscG 6bN2FtDLZDvdAy90wox88T/Mr/dDSj8FwLWZvLvwT8bE4K1Xw7xeUhI0+qlsJM6VXxVC7M1kCau+4 x0RgEUyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUAVO-008R7X-3B; Thu, 10 Aug 2023 18:35:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUAVL-008R6V-0M for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 18:35:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 741D863EE5; Thu, 10 Aug 2023 18:35:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFA41C433C7; Thu, 10 Aug 2023 18:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691692524; bh=xfjlfRaVHyNDxaHERql/K3X32fbh27hAOake+ptYZtk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PRUXEURoDnrQd5HHCHEg5XvLTan1NlCqYygvEFGt28td5BeCZMuvF+wOG0JZ9b3Ou YQKkS0ikkyLHecHlViA059WbPzNvh8LisUMpybBBx8joViZV7Tf1b3N/TcXXAdjEMX wknA+NtG+UQKxj69wDDYvePCdbgsB52oeEATnrIyJNMrCbtQmruDuIE6gtkufoTeSq oUoq+acwwW/oX7kZjLtGTpypouVEXEcjSTqoLkPw/PoH7j66ESbDM4JuX8K7lc3BLe jr4qDXbi8sUVR/hzoqf4iiXZVWmpU16lZz1MCuT2pEhKfQ+AoopeGVkcxHiNq0qB6x LvsqGfF4lgd1w== Date: Thu, 10 Aug 2023 19:35:20 +0100 From: Conor Dooley To: Vignesh Raghavendra Cc: Peter Ujfalusi , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] dt-bindings: dma: ti: k3-bcdma: Describe cfg register regions Message-ID: <20230810-prelaw-payback-9388222dd6d3@spud> References: <20230810174356.3322583-1-vigneshr@ti.com> <20230810174356.3322583-2-vigneshr@ti.com> MIME-Version: 1.0 In-Reply-To: <20230810174356.3322583-2-vigneshr@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_113527_258554_7044EA22 X-CRM114-Status: GOOD ( 19.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5856615772496877114==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5856615772496877114== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hy+rd1947X41UhRn" Content-Disposition: inline --hy+rd1947X41UhRn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 10, 2023 at 11:13:53PM +0530, Vignesh Raghavendra wrote: > Block copy DMA(BCDMA)module on K3 SoCs have ring cfg, TX and RX > channel cfg register regions which are usually configured by a Device > Management firmware. But certain entities such as bootloader (like > U-Boot) may have to access them directly. Describe this region in the > binding documentation for completeness of module description. >=20 > Keep the binding compatible with existing DTS files by requiring first > five regions to be present at least. >=20 > Signed-off-by: Vignesh Raghavendra > --- > .../devicetree/bindings/dma/ti/k3-bcdma.yaml | 25 +++++++++++++------ > 1 file changed, 17 insertions(+), 8 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Doc= umentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > index 4ca300a42a99..d166e284532b 100644 > --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > @@ -37,11 +37,11 @@ properties: > =20 > reg: > minItems: 3 > - maxItems: 5 > + maxItems: 8 How come none of these reg entries have a description? What differentiates a "gcfg" from a "cfg" for example? > =20 > reg-names: > minItems: 3 > - maxItems: 5 > + maxItems: 8 > =20 > "#dma-cells": > const: 3 > @@ -161,14 +161,19 @@ allOf: > properties: > reg: > minItems: 5 > + maxItems: 8 > =20 > reg-names: > + minItems: 5 > items: > - const: gcfg > - const: bchanrt > - const: rchanrt > - const: tchanrt > - const: ringrt > + - const: cfg > + - const: tchan > + - const: rchan > =20 > required: > - ti,sci-rm-range-bchan > @@ -216,12 +221,16 @@ examples: > main_bcdma: dma-controller@485c0100 { > compatible =3D "ti,am64-dmss-bcdma"; > =20 > - reg =3D <0x0 0x485c0100 0x0 0x100>, > - <0x0 0x4c000000 0x0 0x20000>, > - <0x0 0x4a820000 0x0 0x20000>, > - <0x0 0x4aa40000 0x0 0x20000>, > - <0x0 0x4bc00000 0x0 0x100000>; > - reg-names =3D "gcfg", "bchanrt", "rchanrt", "tchanrt", "= ringrt"; > + reg =3D <0x00 0x485c0100 0x00 0x100>, Why have you added extra zeros? (0x00) Thanks, Conor. > + <0x00 0x4c000000 0x00 0x20000>, > + <0x00 0x4a820000 0x00 0x20000>, > + <0x00 0x4aa40000 0x00 0x20000>, > + <0x00 0x4bc00000 0x00 0x100000>, > + <0x00 0x48600000 0x00 0x8000>, > + <0x00 0x484a4000 0x00 0x2000>, > + <0x00 0x484c2000 0x00 0x2000>; > + reg-names =3D "gcfg", "bchanrt", "rchanrt", "tchanrt", "= ringrt", > + "cfg", "tchan", "rchan"; > msi-parent =3D <&inta_main_dmss>; > #dma-cells =3D <3>; > =20 > --=20 > 2.41.0 >=20 --hy+rd1947X41UhRn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNUt6AAKCRB4tDGHoIJi 0s88AP9ckxn/7qNPWkQ0s/NJZZQvBPDQh/iTfduUH9NmovrdigD/S+xmMkFsCX2w YXPFIUnSv9qL4bpWzkUCGGmOXW8bOg0= =pc+/ -----END PGP SIGNATURE----- --hy+rd1947X41UhRn-- --===============5856615772496877114== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5856615772496877114==--