From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0517AC001DE for ; Thu, 10 Aug 2023 09:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hUzpKP0VYdz8/geBBlnaSM+bTojqvf8PowU3KT4noy0=; b=cdkCzX+FNf0x79 +0GGana+UCq08psGzbZHZ7gVRNE1Q/TCMbr8PBRWNo4ikRiTiC0JHDEEBN2ciy3HK+ek8byb0k+bT z9mEAj+BxJtDdrF6Yx8GWpcvxGsLAOd5iJOBfdLSSYBd2uWcZaMVo5Qb8UyesZcZCQ7YoriQxrpTd wy7hJCMYddk1mEFlxszh6H+czpgpwUsnM8WDoCuNdQ21Sym8MroqRqNn4mIF1/qtEPPyID5CTMgus jwnDj7pnWPcU2m1Y0fZIAq6K37Zu6IkLfS6q2HsDYU4GcBTWnXHomJB1NQLL/nB8cPJoeKpaVbKfJ Vr5dsK87mWv0FcoOCCoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qU2Cl-0070b5-1O; Thu, 10 Aug 2023 09:43:43 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qU2Ci-0070aD-1p for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 09:43:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E5A8665655; Thu, 10 Aug 2023 09:43:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D207C433C7; Thu, 10 Aug 2023 09:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691660618; bh=tdZvvunqI2kWKxGbLVgNcUUq5A+ZAKwbvFYIFUY+NYg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A10A9URAFmjsDxwciW/ZOY590dKY4C3OAB2pDu0GmmbEFWmD8m5rbBGgHI2EQnPEs VXFVk4MKY9hgaiqUcRi13WLXWoqhmGYyNeW2qAIzhxUBJoCPY4/cMyeZhaYxEHD6Ow /ArdVEdttCJTQ/Ls+YTtHTewM6ZiZoTtKJxQRtsFFKxENRXLXQy9M0dKTOK2U3ykCp 4pJShizefWUz6/aFRqImpflfZzQXFe/e7iA8+f1IhIL4bitf5zEg5C0psL20VLXU8S 4hK+hrfBvB+a6Caega2jSeCQJmD5Zsixy2ZCtNTUmfkFGokpqo+3lbR84cqwdhsbpS zjNCm/X3bjiEw== Date: Thu, 10 Aug 2023 10:43:33 +0100 From: Will Deacon To: Michael Shavit Cc: Jason Gunthorpe , iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, nicolinc@nvidia.com, jean-philippe@linaro.org Subject: Re: [PATCH v5 2/9] iommu/arm-smmu-v3: Replace s1_cfg with cdtab_cfg Message-ID: <20230810094323.GC5365@willie-the-truck> References: <20230808171446.2187795-1-mshavit@google.com> <20230809011204.v5.2.I1ef1ed19d7786c8176a0d05820c869e650c8d68f@changeid> <20230809134941.GA4226@willie-the-truck> <20230809145542.GB4472@willie-the-truck> <20230809162254.GB4591@willie-the-truck> <20230809162749.GA4663@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_024340_652161_FB3E45A4 X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 10, 2023 at 05:33:53PM +0800, Michael Shavit wrote: > > > > Sounds a lot like the existing s1fmt field. Can we keep it? > > > > > > If you are OK with the dead code, I don't object. But let's put it in > > > the struct arm_smmu_ctx_desc_cfg. > > > > Ok, we have a deal! > > What dead code? Is the deal here that we keep the field, but still > infer the value to write from (cd_table->l1_desc == null) in > arm_smmu_write_strtab_ent?? Keep the field and write it directly when populating the ste (i.e. don't infer anything), but the field moves into 'struct arm_smmu_ctx_desc_cfg'. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel