From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE942C001B0 for ; Thu, 10 Aug 2023 19:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RKqQzCxj7lDKOpR4CHrNqn9hdaLccdSvqO/Z4qBDW1I=; b=YMYIS78E3B4gS0 uShxCb1W2kmpKRQwolCGRE6ca/+2trmkZoZLCyIJZJcFEg7COfxjs4PtGoKY+iX5WhWphltX3YXKV bC1t3NApsyDMHyDmMUeVRnGXPOmPNYyDNw2vNwhrCXB0e15+DbU/AIGT5znSWuSho9/i1sx4e0XiA zzAHVYql4iOLYbHdMqUASVv90mbShpQTHI9CiIe4dGDriGfQDmSb+nxbglOVHLiG+1c5xSWCFX9YQ 29iM+Z7O35IsPuQ6CbFdM1Z+VE1BWrIB6twwDb57Au1ZbCzn1onMiROywD83oAKf4yXjRRow/Jy1v oUJNJIXb4hx4iea2p5xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUBnQ-008bmb-2Q; Thu, 10 Aug 2023 19:58:12 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUBnM-008bll-35 for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 19:58:10 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bc5acc627dso10020705ad.1 for ; Thu, 10 Aug 2023 12:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1691697487; x=1692302287; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=GrzpUIYsNReqF6Vjt7YeuyI+AzdvZwRKw+lBcbw3/VE=; b=AIGXxuzPsRszEV5Gyhfusxvte6pg5BONip5dTyc5hhzjXpSNO57GWCQT96ebiABjYS 8/90fFkIVa2FauB47bAOXuu10ZTR9hxBnVQranwCf2+5kEWBpjY2oSyb6xRiXaeGQZ18 GgxdUjnPTWhQzCQjPexgwl6fmEz94SHJUcsVs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691697487; x=1692302287; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GrzpUIYsNReqF6Vjt7YeuyI+AzdvZwRKw+lBcbw3/VE=; b=a6zFfeC6Rp1/Rt50dO7JlXc0GYMF68bTMGbxcBnSqm+gGZjq0/sF0O/6WAI8EKRPPk FvefRMYcBZ+Yk5t6Lg8y7HsYstf/+ZOgbbX0u2f8ULTMO7Bdzl2cRk8eUrzohyojbLI/ sRErF3Hh6+nm66vhDEH11+/goA1SA79ijwhKkV9FBZHcSV+i3U/HEMuw1ToJWiGPKls3 PsRU2hHKMmcjFLURO8GQGETz8fOta8I30qVSQquNG8rDsGQpCmjUDFTEIvce8OC5NI/s MNmPYtSzbWbw5G7je2y9Whqqw1ae5wNfJUoeixv4IDVYC8Rv4Q1oNowefL5rb1ISrxnc HmwA== X-Gm-Message-State: AOJu0YytilrDAznv1Q+nnzRgl1CMe+3mgR4VTss7dFFCNIPcVn27BT+H JjOt3OhLrk2+SaUMqM0DZ244nA== X-Google-Smtp-Source: AGHT+IFrQQ+KCWzwjasCjLqDeaFB7YOqF1dDdtbZZXKcKKDFCgxX4Wc6XAZFk5pk13f92S/nfnkDvQ== X-Received: by 2002:a17:903:247:b0:1bb:b86e:8d60 with SMTP id j7-20020a170903024700b001bbb86e8d60mr4103679plh.46.1691697487304; Thu, 10 Aug 2023 12:58:07 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id h5-20020a170902f54500b001a1b66af22fsm2166866plf.62.2023.08.10.12.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 12:58:06 -0700 (PDT) Date: Thu, 10 Aug 2023 12:58:06 -0700 From: Kees Cook To: Justin Stitt Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] arm64/sysreg: refactor deprecated strncpy Message-ID: <202308101257.47E6ACBD5@keescook> References: <20230810-strncpy-arch-arm64-v1-1-f67f3685cd64@google.com> <202308101155.81497C5B@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_125809_037595_24E0599C X-CRM114-Status: GOOD ( 34.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBdWcgMTAsIDIwMjMgYXQgMTI6MjU6MzdQTSAtMDcwMCwgSnVzdGluIFN0aXR0IHdy b3RlOgo+IE9uIFRodSwgQXVnIDEwLCAyMDIzIGF0IDEyOjAw4oCvUE0gS2VlcyBDb29rIDxrZWVz Y29va0BjaHJvbWl1bS5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIFRodSwgQXVnIDEwLCAyMDIzIGF0 IDA2OjM5OjAzUE0gKzAwMDAsIEp1c3RpbiBTdGl0dCB3cm90ZToKPiA+ID4gYHN0cm5jcHlgIGlz IGRlcHJlY2F0ZWQgZm9yIHVzZSBvbiBOVUwtdGVybWluYXRlZCBkZXN0aW5hdGlvbiBzdHJpbmdz Cj4gPiA+IFsxXS4gV2hpY2ggc2VlbXMgdG8gYmUgdGhlIGNhc2UgaGVyZSBkdWUgdG8gdGhlIGZv cmNlZnVsIHNldHRpbmcgb2YgYGJ1ZmAncwo+ID4gPiB0YWlsIHRvIDAuCj4gPgo+ID4gQW5vdGhl ciBub3RlIHRvIGluY2x1ZGUgaW4gdGhlc2UgZXZhbHVhdGlvbnMgd291bGQgYmUgImRvZXMgdGhl Cj4gPiBkZXN0aW5hdGlvbiBleHBlY3QgdG8gYmUgJU5VTCBwYWRkZWQ/Ii4gSGVyZSwgaXQgbG9v a3MgbGlrZSBubywgYXMgYWxsCj4gPiB0aGUgcm91dGluZXMgImJ1ZiIgaXMgcGFzc2VkIHRvIGV4 cGVjdCBhIHJlZ3VsYXIgQyBzdHJpbmcgKHBhZGRpbmcKPiA+IGRvZXNuJ3QgbWF0dGVyKS4KPiA+ Cj4gPiA+Cj4gPiA+IEEgc3VpdGFibGUgcmVwbGFjZW1lbnQgaXMgYHN0cnNjcHlgIFsyXSBkdWUg dG8gdGhlIGZhY3QgdGhhdCBpdAo+ID4gPiBndWFyYW50ZWVzIE5VTC10ZXJtaW5hdGlvbiBvbiBp dHMgZGVzdGluYXRpb24gYnVmZmVyIGFyZ3VtZW50IHdoaWNoIGlzCj4gPiA+IF9ub3RfIHRoZSBj YXNlIGZvciBgc3RybmNweWAhCj4gPiA+Cj4gPiA+IEluIHRoaXMgY2FzZSwgdGhlcmUgaXMgc29t ZSBiZWhhdmlvciBiZWluZyB1c2VkIGluIGNvbmp1bmN0aW9uIHdpdGgKPiA+ID4gYHN0cm5jcHlg IHRoYXQgYHN0cnNjcHlgIGFscmVhZHkgaW1wbGVtZW50cy4gVGhpcyBtZWFucyB3ZSBjYW4gZHJv cCBzb21lCj4gPiA+IG9mIHRoZSBleHRyYSBzdHVmZiBsaWtlIGAuLi4gLTFgIGFuZCBgYnVmW2xl bl0gPSAwYAo+ID4gPgo+ID4gPiBUaGlzIHNob3VsZCBoYXZlIG5vIGZ1bmN0aW9uYWwgY2hhbmdl IGFuZCB5ZXQgdXNlcyBhIG1vcmUgcm9idXN0IGFuZAo+ID4gPiBsZXNzIGFtYmlndW91cyBpbnRl cmZhY2Ugd2hpbHN0IHJlZHVjaW5nIGNvZGUgY29tcGxleGl0eS4KPiA+ID4KPiA+ID4gTGluazog d3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwvbGF0ZXN0L3Byb2Nlc3MvZGVwcmVjYXRlZC5odG1sI3N0 cm5jcHktb24tbnVsLXRlcm1pbmF0ZWQtc3RyaW5nc1sxXQo+ID4gPiBMaW5rOiBodHRwczovL21h bnBhZ2VzLmRlYmlhbi5vcmcvdGVzdGluZy9saW51eC1tYW51YWwtNC44L3N0cnNjcHkuOS5lbi5o dG1sIFsyXQo+ID4gPiBMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vS1NQUC9saW51eC9pc3N1ZXMv OTAKPiA+ID4gQ2M6IGxpbnV4LWhhcmRlbmluZ0B2Z2VyLmtlcm5lbC5vcmcKPiA+ID4KPiA+ID4g U2lnbmVkLW9mZi1ieTogSnVzdGluIFN0aXR0IDxqdXN0aW5zdGl0dEBnb29nbGUuY29tPgo+ID4g PiAtLS0KPiA+ID4gRm9yIHJlZmVyZW5jZSwgc2VlIGEgcGFydCBvZiBgc3Ryc2NweWAncyBpbXBs ZW1lbnRhdGlvbiBoZXJlOgo+ID4gPgo+ID4gPiB8ICAgICAvKiBIaXQgYnVmZmVyIGxlbmd0aCB3 aXRob3V0IGZpbmRpbmcgYSBOVUw7IGZvcmNlIE5VTC10ZXJtaW5hdGlvbi4gKi8KPiA+ID4gfCAg ICAgaWYgKHJlcykKPiA+ID4gfCAgICAgICAgICAgICBkZXN0W3Jlcy0xXSA9ICdcMCc7Cj4gPiA+ Cj4gPiA+IE5vdGU6IGNvbXBpbGUgdGVzdGVkCj4gPiA+IC0tLQo+ID4gPiAgYXJjaC9hcm02NC9r ZXJuZWwvaWRyZWctb3ZlcnJpZGUuYyB8IDUgKystLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAy IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9h cmNoL2FybTY0L2tlcm5lbC9pZHJlZy1vdmVycmlkZS5jIGIvYXJjaC9hcm02NC9rZXJuZWwvaWRy ZWctb3ZlcnJpZGUuYwo+ID4gPiBpbmRleCAyZmUyNDkxYjY5MmMuLjQ4MmRjNWM3MWU5MCAxMDA2 NDQKPiA+ID4gLS0tIGEvYXJjaC9hcm02NC9rZXJuZWwvaWRyZWctb3ZlcnJpZGUuYwo+ID4gPiAr KysgYi9hcmNoL2FybTY0L2tlcm5lbC9pZHJlZy1vdmVycmlkZS5jCj4gPiA+IEBAIC0yNjIsOSAr MjYyLDggQEAgc3RhdGljIF9faW5pdCB2b2lkIF9fcGFyc2VfY21kbGluZShjb25zdCBjaGFyICpj bWRsaW5lLCBib29sIHBhcnNlX2FsaWFzZXMpCj4gPiA+ICAgICAgICAgICAgICAgaWYgKCFsZW4p Cj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47Cj4gPiA+Cj4gPiA+IC0gICAgICAg ICAgICAgbGVuID0gbWluKGxlbiwgQVJSQVlfU0laRShidWYpIC0gMSk7Cj4gPiA+IC0gICAgICAg ICAgICAgc3RybmNweShidWYsIGNtZGxpbmUsIGxlbik7Cj4gPiA+IC0gICAgICAgICAgICAgYnVm W2xlbl0gPSAwOwo+ID4gPiArICAgICAgICAgICAgIGxlbiA9IG1pbihsZW4sIEFSUkFZX1NJWkUo YnVmKSk7Cj4gPiA+ICsgICAgICAgICAgICAgc3Ryc2NweShidWYsIGNtZGxpbmUsIGxlbik7Cj4g Pgo+ID4gVGhpcywgaG93ZXZlciwgaXNuJ3QgY29ycmVjdDogImNtZGxpbmUiIHdpbGwgYmUgaW5j cmVtZW50ZWQgYnkgImxlTiIKPiA+IGxhdGVyLCBhbmQgd2Ugd2FudCBhIGNvdW50IG9mIHRoZSBj aGFyYWN0ZXJzIGNvcGllZCBpbnRvICJidWYiLCBldmVuIGlmCj4gPiB0aGV5J3JlIHRydW5jYXRl ZC4gSSB0aGluayB0aGlzIHNob3VsZCBiZToKPiA+Cj4gPiAgICAgICAgICAgICAgICAgc3Ryc2Nw eShidWYsIGNtZGxpbmUsIEFSUkFZX1NJWkUoYnVmKSk7Cj4gPiAgICAgICAgICAgICAgICAgbGVu ID0gc3RybGVuKGJ1Zik7Cj4gPgo+IFRob3VnaHRzIG9uIHVzaW5nIHRoZSByZXR1cm4gdmFsdWUg ZnJvbSBgc3Ryc2NweWAgaGVyZT8KClRoaXMgY29kZSBzZWVtcyB0byBzaWxlbnRseSBhY2NlcHQg dHJ1bmNhdGlvbiwgc28gLUUyQklHIHdpbGwgY2F1c2UgYQpwcm9ibGVtIGlmIGl0IG9ubHkgbG9v a3MgYXQgdGhlIHJldHVybiB2YWx1ZS4KCi1LZWVzCgotLSAKS2VlcyBDb29rCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==