* [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes [not found] <20230810141947.1236730-1-arnd@kernel.org> @ 2023-08-10 14:19 ` Arnd Bergmann 2023-08-11 22:10 ` Masahiro Yamada 2023-08-10 14:19 ` [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes Arnd Bergmann 1 sibling, 1 reply; 5+ messages in thread From: Arnd Bergmann @ 2023-08-10 14:19 UTC (permalink / raw) To: Andrew Morton, linux-kernel Cc: Arnd Bergmann, Catalin Marinas, Palmer Dabbelt, Guo Ren, Alexander Gordeev, Russell King, Will Deacon, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Paul Walmsley, Palmer Dabbelt, Albert Ou, Heiko Carstens, Vasily Gorbik, Christian Borntraeger, Sven Schnelle, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin, linux-arm-kernel, linux-csky, linuxppc-dev, linux-riscv, linux-s390 From: Arnd Bergmann <arnd@arndb.de> The prototype was hidden on x86, which causes a warning: kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes] Fix this by providing it in only one place that is always visible. Acked-by: Catalin Marinas <catalin.marinas@arm.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> Acked-by: Guo Ren <guoren@kernel.org> Reviewed-by: Alexander Gordeev <agordeev@linux.ibm.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/include/asm/irq_work.h | 2 -- arch/arm64/include/asm/irq_work.h | 2 -- arch/csky/include/asm/irq_work.h | 2 +- arch/powerpc/include/asm/irq_work.h | 1 - arch/riscv/include/asm/irq_work.h | 2 +- arch/s390/include/asm/irq_work.h | 2 -- arch/x86/include/asm/irq_work.h | 1 - include/linux/irq_work.h | 3 +++ 8 files changed, 5 insertions(+), 10 deletions(-) diff --git a/arch/arm/include/asm/irq_work.h b/arch/arm/include/asm/irq_work.h index 3149e4dc1b540..8895999834cc0 100644 --- a/arch/arm/include/asm/irq_work.h +++ b/arch/arm/include/asm/irq_work.h @@ -9,6 +9,4 @@ static inline bool arch_irq_work_has_interrupt(void) return is_smp(); } -extern void arch_irq_work_raise(void); - #endif /* _ASM_ARM_IRQ_WORK_H */ diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h index 81bbfa3a035bd..a1020285ea750 100644 --- a/arch/arm64/include/asm/irq_work.h +++ b/arch/arm64/include/asm/irq_work.h @@ -2,8 +2,6 @@ #ifndef __ASM_IRQ_WORK_H #define __ASM_IRQ_WORK_H -extern void arch_irq_work_raise(void); - static inline bool arch_irq_work_has_interrupt(void) { return true; diff --git a/arch/csky/include/asm/irq_work.h b/arch/csky/include/asm/irq_work.h index 33aaf39d6f94f..d39fcc1f5395f 100644 --- a/arch/csky/include/asm/irq_work.h +++ b/arch/csky/include/asm/irq_work.h @@ -7,5 +7,5 @@ static inline bool arch_irq_work_has_interrupt(void) { return true; } -extern void arch_irq_work_raise(void); + #endif /* __ASM_CSKY_IRQ_WORK_H */ diff --git a/arch/powerpc/include/asm/irq_work.h b/arch/powerpc/include/asm/irq_work.h index b8b0be8f1a07e..c6d3078bd8c3b 100644 --- a/arch/powerpc/include/asm/irq_work.h +++ b/arch/powerpc/include/asm/irq_work.h @@ -6,6 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) { return true; } -extern void arch_irq_work_raise(void); #endif /* _ASM_POWERPC_IRQ_WORK_H */ diff --git a/arch/riscv/include/asm/irq_work.h b/arch/riscv/include/asm/irq_work.h index b53891964ae03..b27a4d64fc6a0 100644 --- a/arch/riscv/include/asm/irq_work.h +++ b/arch/riscv/include/asm/irq_work.h @@ -6,5 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) { return IS_ENABLED(CONFIG_SMP); } -extern void arch_irq_work_raise(void); + #endif /* _ASM_RISCV_IRQ_WORK_H */ diff --git a/arch/s390/include/asm/irq_work.h b/arch/s390/include/asm/irq_work.h index 603783766d0ab..f00c9f610d5a8 100644 --- a/arch/s390/include/asm/irq_work.h +++ b/arch/s390/include/asm/irq_work.h @@ -7,6 +7,4 @@ static inline bool arch_irq_work_has_interrupt(void) return true; } -void arch_irq_work_raise(void); - #endif /* _ASM_S390_IRQ_WORK_H */ diff --git a/arch/x86/include/asm/irq_work.h b/arch/x86/include/asm/irq_work.h index 800ffce0db29e..6b4d36c951655 100644 --- a/arch/x86/include/asm/irq_work.h +++ b/arch/x86/include/asm/irq_work.h @@ -9,7 +9,6 @@ static inline bool arch_irq_work_has_interrupt(void) { return boot_cpu_has(X86_FEATURE_APIC); } -extern void arch_irq_work_raise(void); #else static inline bool arch_irq_work_has_interrupt(void) { diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h index 8cd11a2232605..136f2980cba30 100644 --- a/include/linux/irq_work.h +++ b/include/linux/irq_work.h @@ -66,6 +66,9 @@ void irq_work_sync(struct irq_work *work); void irq_work_run(void); bool irq_work_needs_cpu(void); void irq_work_single(void *arg); + +void arch_irq_work_raise(void); + #else static inline bool irq_work_needs_cpu(void) { return false; } static inline void irq_work_run(void) { } -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes 2023-08-10 14:19 ` [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes Arnd Bergmann @ 2023-08-11 22:10 ` Masahiro Yamada 2023-08-12 7:34 ` Arnd Bergmann 0 siblings, 1 reply; 5+ messages in thread From: Masahiro Yamada @ 2023-08-11 22:10 UTC (permalink / raw) To: Arnd Bergmann Cc: Andrew Morton, linux-kernel, Arnd Bergmann, Catalin Marinas, Palmer Dabbelt, Guo Ren, Alexander Gordeev, Russell King, Will Deacon, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Paul Walmsley, Palmer Dabbelt, Albert Ou, Heiko Carstens, Vasily Gorbik, Christian Borntraeger, Sven Schnelle, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin, linux-arm-kernel, linux-csky, linuxppc-dev, linux-riscv, linux-s390 On Fri, Aug 11, 2023 at 10:00 AM Arnd Bergmann <arnd@kernel.org> wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > The prototype was hidden on x86, which causes a warning: What do you mean by "hidden on x86"? arch_irq_work_raise() was declared on 7 architectures, including x86. > > kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes] > > Fix this by providing it in only one place that is always visible. > > Acked-by: Catalin Marinas <catalin.marinas@arm.com> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > Acked-by: Guo Ren <guoren@kernel.org> > Reviewed-by: Alexander Gordeev <agordeev@linux.ibm.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/include/asm/irq_work.h | 2 -- > arch/arm64/include/asm/irq_work.h | 2 -- > arch/csky/include/asm/irq_work.h | 2 +- > arch/powerpc/include/asm/irq_work.h | 1 - > arch/riscv/include/asm/irq_work.h | 2 +- > arch/s390/include/asm/irq_work.h | 2 -- > arch/x86/include/asm/irq_work.h | 1 - > include/linux/irq_work.h | 3 +++ > 8 files changed, 5 insertions(+), 10 deletions(-) > -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes 2023-08-11 22:10 ` Masahiro Yamada @ 2023-08-12 7:34 ` Arnd Bergmann 0 siblings, 0 replies; 5+ messages in thread From: Arnd Bergmann @ 2023-08-12 7:34 UTC (permalink / raw) To: Masahiro Yamada, Arnd Bergmann Cc: Andrew Morton, linux-kernel, Catalin Marinas, Palmer Dabbelt, guoren, Alexander Gordeev, Russell King, Will Deacon, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Paul Walmsley, Palmer Dabbelt, Albert Ou, Heiko Carstens, Vasily Gorbik, Christian Borntraeger, Sven Schnelle, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin, linux-arm-kernel, linux-csky@vger.kernel.org, linuxppc-dev, linux-riscv, linux-s390 On Sat, Aug 12, 2023, at 00:10, Masahiro Yamada wrote: > On Fri, Aug 11, 2023 at 10:00 AM Arnd Bergmann <arnd@kernel.org> wrote: >> >> From: Arnd Bergmann <arnd@arndb.de> >> >> The prototype was hidden on x86, which causes a warning: > > > What do you mean by "hidden on x86"? > > arch_irq_work_raise() was declared on 7 architectures, > including x86. > I meant hidden in some configurations. Specifically, x86 only declares the function when it overrides it for CONFIG_X86_LOCAL_APIC, while without that option the generic stub still gets compiled but is never declared. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes [not found] <20230810141947.1236730-1-arnd@kernel.org> 2023-08-10 14:19 ` [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes Arnd Bergmann @ 2023-08-10 14:19 ` Arnd Bergmann 2023-08-11 11:46 ` Masami Hiramatsu 1 sibling, 1 reply; 5+ messages in thread From: Arnd Bergmann @ 2023-08-10 14:19 UTC (permalink / raw) To: Andrew Morton, linux-kernel, Naveen N. Rao, Anil S Keshavamurthy, Masami Hiramatsu Cc: Arnd Bergmann, Vineet Gupta, Russell King, Catalin Marinas, Will Deacon, Thomas Bogendoerfer, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Christian Borntraeger, Sven Schnelle, Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz, David S. Miller, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin, Gaosheng Cui, Steven Rostedt (Google), Yang Jihong, Jiri Olsa, Alexei Starovoitov, linux-snps-arc, linux-arm-kernel, linux-ia64, linux-mips, linuxppc-dev, linux-s390, linux-sh, sparclinux, linux-trace-kernel From: Arnd Bergmann <arnd@arndb.de> Most architectures that support kprobes declare this function in their own asm/kprobes.h header and provide an override, but some are missing the prototype, which causes a warning for the __weak stub implementation: kernel/kprobes.c:1865:12: error: no previous prototype for 'kprobe_exceptions_notify' [-Werror=missing-prototypes] 1865 | int __weak kprobe_exceptions_notify(struct notifier_block *self, Move the prototype into linux/kprobes.h so it is visible to all the definitions. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arc/include/asm/kprobes.h | 3 --- arch/arm/include/asm/kprobes.h | 2 -- arch/arm64/include/asm/kprobes.h | 2 -- arch/ia64/include/asm/kprobes.h | 2 -- arch/mips/include/asm/kprobes.h | 2 -- arch/powerpc/include/asm/kprobes.h | 2 -- arch/s390/include/asm/kprobes.h | 2 -- arch/sh/include/asm/kprobes.h | 2 -- arch/sparc/include/asm/kprobes.h | 2 -- arch/x86/include/asm/kprobes.h | 2 -- include/linux/kprobes.h | 4 ++++ 11 files changed, 4 insertions(+), 21 deletions(-) diff --git a/arch/arc/include/asm/kprobes.h b/arch/arc/include/asm/kprobes.h index de1566e32cb89..68e8301c0df2c 100644 --- a/arch/arc/include/asm/kprobes.h +++ b/arch/arc/include/asm/kprobes.h @@ -32,9 +32,6 @@ struct kprobe; void arch_remove_kprobe(struct kprobe *p); -int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); - struct prev_kprobe { struct kprobe *kp; unsigned long status; diff --git a/arch/arm/include/asm/kprobes.h b/arch/arm/include/asm/kprobes.h index e26a278d301ab..5b8dbf1b0be49 100644 --- a/arch/arm/include/asm/kprobes.h +++ b/arch/arm/include/asm/kprobes.h @@ -40,8 +40,6 @@ struct kprobe_ctlblk { void arch_remove_kprobe(struct kprobe *); int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr); -int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); /* optinsn template addresses */ extern __visible kprobe_opcode_t optprobe_template_entry[]; diff --git a/arch/arm64/include/asm/kprobes.h b/arch/arm64/include/asm/kprobes.h index 05cd82eeca136..be7a3680dadff 100644 --- a/arch/arm64/include/asm/kprobes.h +++ b/arch/arm64/include/asm/kprobes.h @@ -37,8 +37,6 @@ struct kprobe_ctlblk { void arch_remove_kprobe(struct kprobe *); int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr); -int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); void __kretprobe_trampoline(void); void __kprobes *trampoline_probe_handler(struct pt_regs *regs); diff --git a/arch/ia64/include/asm/kprobes.h b/arch/ia64/include/asm/kprobes.h index 9e956768946cc..56004f97df6d2 100644 --- a/arch/ia64/include/asm/kprobes.h +++ b/arch/ia64/include/asm/kprobes.h @@ -107,8 +107,6 @@ struct arch_specific_insn { }; extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr); -extern int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); extern void arch_remove_kprobe(struct kprobe *p); diff --git a/arch/mips/include/asm/kprobes.h b/arch/mips/include/asm/kprobes.h index 68b1e5d458cfb..bc27d99c94363 100644 --- a/arch/mips/include/asm/kprobes.h +++ b/arch/mips/include/asm/kprobes.h @@ -71,8 +71,6 @@ struct kprobe_ctlblk { struct prev_kprobe prev_kprobe; }; -extern int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); #endif /* CONFIG_KPROBES */ #endif /* _ASM_KPROBES_H */ diff --git a/arch/powerpc/include/asm/kprobes.h b/arch/powerpc/include/asm/kprobes.h index c8e4b4fd4e330..4525a9c68260d 100644 --- a/arch/powerpc/include/asm/kprobes.h +++ b/arch/powerpc/include/asm/kprobes.h @@ -84,8 +84,6 @@ struct arch_optimized_insn { kprobe_opcode_t *insn; }; -extern int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr); extern int kprobe_handler(struct pt_regs *regs); extern int kprobe_post_handler(struct pt_regs *regs); diff --git a/arch/s390/include/asm/kprobes.h b/arch/s390/include/asm/kprobes.h index 83f732ca3af4d..3f87125dd9b0d 100644 --- a/arch/s390/include/asm/kprobes.h +++ b/arch/s390/include/asm/kprobes.h @@ -72,8 +72,6 @@ struct kprobe_ctlblk { void arch_remove_kprobe(struct kprobe *p); int kprobe_fault_handler(struct pt_regs *regs, int trapnr); -int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); #define flush_insn_slot(p) do { } while (0) diff --git a/arch/sh/include/asm/kprobes.h b/arch/sh/include/asm/kprobes.h index eeba83e0a7d29..65d4c3316a5bd 100644 --- a/arch/sh/include/asm/kprobes.h +++ b/arch/sh/include/asm/kprobes.h @@ -46,8 +46,6 @@ struct kprobe_ctlblk { }; extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr); -extern int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); extern int kprobe_handle_illslot(unsigned long pc); #else diff --git a/arch/sparc/include/asm/kprobes.h b/arch/sparc/include/asm/kprobes.h index 06c2bc767ef75..aec742cd898f2 100644 --- a/arch/sparc/include/asm/kprobes.h +++ b/arch/sparc/include/asm/kprobes.h @@ -47,8 +47,6 @@ struct kprobe_ctlblk { struct prev_kprobe prev_kprobe; }; -int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); int kprobe_fault_handler(struct pt_regs *regs, int trapnr); asmlinkage void __kprobes kprobe_trap(unsigned long trap_level, struct pt_regs *regs); diff --git a/arch/x86/include/asm/kprobes.h b/arch/x86/include/asm/kprobes.h index a2e9317aad495..5939694dfb28d 100644 --- a/arch/x86/include/asm/kprobes.h +++ b/arch/x86/include/asm/kprobes.h @@ -113,8 +113,6 @@ struct kprobe_ctlblk { }; extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr); -extern int kprobe_exceptions_notify(struct notifier_block *self, - unsigned long val, void *data); extern int kprobe_int3_handler(struct pt_regs *regs); #else diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h index 85a64cb95d755..987911cdc90a2 100644 --- a/include/linux/kprobes.h +++ b/include/linux/kprobes.h @@ -450,6 +450,10 @@ int kprobe_get_kallsym(unsigned int symnum, unsigned long *value, char *type, int arch_kprobe_get_kallsym(unsigned int *symnum, unsigned long *value, char *type, char *sym); + +int kprobe_exceptions_notify(struct notifier_block *self, + unsigned long val, void *data); + #else /* !CONFIG_KPROBES: */ static inline int kprobe_fault_handler(struct pt_regs *regs, int trapnr) -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes 2023-08-10 14:19 ` [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes Arnd Bergmann @ 2023-08-11 11:46 ` Masami Hiramatsu 0 siblings, 0 replies; 5+ messages in thread From: Masami Hiramatsu @ 2023-08-11 11:46 UTC (permalink / raw) To: Arnd Bergmann Cc: Andrew Morton, linux-kernel, Naveen N. Rao, Anil S Keshavamurthy, Arnd Bergmann, Vineet Gupta, Russell King, Catalin Marinas, Will Deacon, Thomas Bogendoerfer, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Christian Borntraeger, Sven Schnelle, Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz, David S. Miller, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin, Gaosheng Cui, Steven Rostedt (Google), Yang Jihong, Jiri Olsa, Alexei Starovoitov, linux-snps-arc, linux-arm-kernel, linux-ia64, linux-mips, linuxppc-dev, linux-s390, linux-sh, sparclinux, linux-trace-kernel On Thu, 10 Aug 2023 16:19:32 +0200 Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Most architectures that support kprobes declare this function in their > own asm/kprobes.h header and provide an override, but some are missing > the prototype, which causes a warning for the __weak stub implementation: > > kernel/kprobes.c:1865:12: error: no previous prototype for 'kprobe_exceptions_notify' [-Werror=missing-prototypes] > 1865 | int __weak kprobe_exceptions_notify(struct notifier_block *self, > > Move the prototype into linux/kprobes.h so it is visible to all > the definitions. Good catch! and it seems x86 has no implementation, so this is more resonable. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Thank you, > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arc/include/asm/kprobes.h | 3 --- > arch/arm/include/asm/kprobes.h | 2 -- > arch/arm64/include/asm/kprobes.h | 2 -- > arch/ia64/include/asm/kprobes.h | 2 -- > arch/mips/include/asm/kprobes.h | 2 -- > arch/powerpc/include/asm/kprobes.h | 2 -- > arch/s390/include/asm/kprobes.h | 2 -- > arch/sh/include/asm/kprobes.h | 2 -- > arch/sparc/include/asm/kprobes.h | 2 -- > arch/x86/include/asm/kprobes.h | 2 -- > include/linux/kprobes.h | 4 ++++ > 11 files changed, 4 insertions(+), 21 deletions(-) > > diff --git a/arch/arc/include/asm/kprobes.h b/arch/arc/include/asm/kprobes.h > index de1566e32cb89..68e8301c0df2c 100644 > --- a/arch/arc/include/asm/kprobes.h > +++ b/arch/arc/include/asm/kprobes.h > @@ -32,9 +32,6 @@ struct kprobe; > > void arch_remove_kprobe(struct kprobe *p); > > -int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > - > struct prev_kprobe { > struct kprobe *kp; > unsigned long status; > diff --git a/arch/arm/include/asm/kprobes.h b/arch/arm/include/asm/kprobes.h > index e26a278d301ab..5b8dbf1b0be49 100644 > --- a/arch/arm/include/asm/kprobes.h > +++ b/arch/arm/include/asm/kprobes.h > @@ -40,8 +40,6 @@ struct kprobe_ctlblk { > > void arch_remove_kprobe(struct kprobe *); > int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr); > -int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > > /* optinsn template addresses */ > extern __visible kprobe_opcode_t optprobe_template_entry[]; > diff --git a/arch/arm64/include/asm/kprobes.h b/arch/arm64/include/asm/kprobes.h > index 05cd82eeca136..be7a3680dadff 100644 > --- a/arch/arm64/include/asm/kprobes.h > +++ b/arch/arm64/include/asm/kprobes.h > @@ -37,8 +37,6 @@ struct kprobe_ctlblk { > > void arch_remove_kprobe(struct kprobe *); > int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr); > -int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > void __kretprobe_trampoline(void); > void __kprobes *trampoline_probe_handler(struct pt_regs *regs); > > diff --git a/arch/ia64/include/asm/kprobes.h b/arch/ia64/include/asm/kprobes.h > index 9e956768946cc..56004f97df6d2 100644 > --- a/arch/ia64/include/asm/kprobes.h > +++ b/arch/ia64/include/asm/kprobes.h > @@ -107,8 +107,6 @@ struct arch_specific_insn { > }; > > extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr); > -extern int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > > extern void arch_remove_kprobe(struct kprobe *p); > > diff --git a/arch/mips/include/asm/kprobes.h b/arch/mips/include/asm/kprobes.h > index 68b1e5d458cfb..bc27d99c94363 100644 > --- a/arch/mips/include/asm/kprobes.h > +++ b/arch/mips/include/asm/kprobes.h > @@ -71,8 +71,6 @@ struct kprobe_ctlblk { > struct prev_kprobe prev_kprobe; > }; > > -extern int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > > #endif /* CONFIG_KPROBES */ > #endif /* _ASM_KPROBES_H */ > diff --git a/arch/powerpc/include/asm/kprobes.h b/arch/powerpc/include/asm/kprobes.h > index c8e4b4fd4e330..4525a9c68260d 100644 > --- a/arch/powerpc/include/asm/kprobes.h > +++ b/arch/powerpc/include/asm/kprobes.h > @@ -84,8 +84,6 @@ struct arch_optimized_insn { > kprobe_opcode_t *insn; > }; > > -extern int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr); > extern int kprobe_handler(struct pt_regs *regs); > extern int kprobe_post_handler(struct pt_regs *regs); > diff --git a/arch/s390/include/asm/kprobes.h b/arch/s390/include/asm/kprobes.h > index 83f732ca3af4d..3f87125dd9b0d 100644 > --- a/arch/s390/include/asm/kprobes.h > +++ b/arch/s390/include/asm/kprobes.h > @@ -72,8 +72,6 @@ struct kprobe_ctlblk { > void arch_remove_kprobe(struct kprobe *p); > > int kprobe_fault_handler(struct pt_regs *regs, int trapnr); > -int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > > #define flush_insn_slot(p) do { } while (0) > > diff --git a/arch/sh/include/asm/kprobes.h b/arch/sh/include/asm/kprobes.h > index eeba83e0a7d29..65d4c3316a5bd 100644 > --- a/arch/sh/include/asm/kprobes.h > +++ b/arch/sh/include/asm/kprobes.h > @@ -46,8 +46,6 @@ struct kprobe_ctlblk { > }; > > extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr); > -extern int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > extern int kprobe_handle_illslot(unsigned long pc); > #else > > diff --git a/arch/sparc/include/asm/kprobes.h b/arch/sparc/include/asm/kprobes.h > index 06c2bc767ef75..aec742cd898f2 100644 > --- a/arch/sparc/include/asm/kprobes.h > +++ b/arch/sparc/include/asm/kprobes.h > @@ -47,8 +47,6 @@ struct kprobe_ctlblk { > struct prev_kprobe prev_kprobe; > }; > > -int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > int kprobe_fault_handler(struct pt_regs *regs, int trapnr); > asmlinkage void __kprobes kprobe_trap(unsigned long trap_level, > struct pt_regs *regs); > diff --git a/arch/x86/include/asm/kprobes.h b/arch/x86/include/asm/kprobes.h > index a2e9317aad495..5939694dfb28d 100644 > --- a/arch/x86/include/asm/kprobes.h > +++ b/arch/x86/include/asm/kprobes.h > @@ -113,8 +113,6 @@ struct kprobe_ctlblk { > }; > > extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr); > -extern int kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data); > extern int kprobe_int3_handler(struct pt_regs *regs); > > #else > diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h > index 85a64cb95d755..987911cdc90a2 100644 > --- a/include/linux/kprobes.h > +++ b/include/linux/kprobes.h > @@ -450,6 +450,10 @@ int kprobe_get_kallsym(unsigned int symnum, unsigned long *value, char *type, > > int arch_kprobe_get_kallsym(unsigned int *symnum, unsigned long *value, > char *type, char *sym); > + > +int kprobe_exceptions_notify(struct notifier_block *self, > + unsigned long val, void *data); > + > #else /* !CONFIG_KPROBES: */ > > static inline int kprobe_fault_handler(struct pt_regs *regs, int trapnr) > -- > 2.39.2 > -- Masami Hiramatsu (Google) <mhiramat@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-12 7:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230810141947.1236730-1-arnd@kernel.org>
2023-08-10 14:19 ` [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes Arnd Bergmann
2023-08-11 22:10 ` Masahiro Yamada
2023-08-12 7:34 ` Arnd Bergmann
2023-08-10 14:19 ` [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes Arnd Bergmann
2023-08-11 11:46 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).