Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Conor Dooley <conor@kernel.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: arm: ti: Add bindings for AM62P5 SoCs
Date: Thu, 10 Aug 2023 13:43:08 -0500	[thread overview]
Message-ID: <20230810184308.q67ldarld6qwo5uq@erased> (raw)
In-Reply-To: <20230810-exile-accurate-790c6828133b@spud>

On 17:03-20230810, Conor Dooley wrote:
> On Thu, Aug 10, 2023 at 10:23:12AM +0530, Vignesh Raghavendra wrote:
> > From: Bryan Brattlof <bb@ti.com>
> > 
> > Add bindings for TI's AM62P5 family of devices.
> > 
> > Signed-off-by: Bryan Brattlof <bb@ti.com>
> > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> > ---
> >  Documentation/devicetree/bindings/arm/ti/k3.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > index 5ca6af492507..93b2774cc0a9 100644
> > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > @@ -25,6 +25,12 @@ properties:
> >                - ti,am62a7-sk
> >            - const: ti,am62a7
> >  
> > +      - description: K3 AM62P5 SoC
> 
> SoC seems a bit off here, since the sk is actually a board using the
> SoC, but it seems to be the convention for TI stuff,

Thanks for providing that perspective - there will be new boards
getting added to the enum list, they should be one line additions at
this point.

But, your point taken. K3 AM625P SoC based boards is more appropriate.

I can do the local change as I apply and keep your ack unless you
object.

> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> 
> 
> > +        items:
> > +          - enum:
> > +              - ti,am62p5-sk
> > +          - const: ti,am62p5
> > +
> >        - description: K3 AM625 SoC PHYTEC phyBOARD-Lyra
> >          items:
> >            - const: phytec,am625-phyboard-lyra-rdk
> > -- 
> > 2.41.0
> > 



-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-10 18:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10  4:53 [PATCH 0/3] arm64: dts: ti: Introduce AM62P SoCs Vignesh Raghavendra
2023-08-10  4:53 ` [PATCH 1/3] dt-bindings: arm: ti: Add bindings for AM62P5 SoCs Vignesh Raghavendra
2023-08-10  5:19   ` Rob Herring
2023-08-10 16:03   ` Conor Dooley
2023-08-10 18:43     ` Nishanth Menon [this message]
2023-08-13  9:55       ` Conor Dooley
2023-08-13 13:06         ` Nishanth Menon
2023-08-10  4:53 ` [PATCH 2/3] arm64: dts: ti: Introduce AM62P5 family of SoCs Vignesh Raghavendra
2023-08-10 21:11   ` Andrew Davis
2023-08-14 19:21   ` Krzysztof Kozlowski
2023-08-10  4:53 ` [PATCH 3/3] arm64: dts: ti: Add support for the AM62P5-SK Vignesh Raghavendra
2023-08-10 21:19   ` Andrew Davis
2023-08-11 15:25     ` Vignesh Raghavendra
2023-08-10 17:43 ` [PATCH 0/3] arm64: dts: ti: Introduce AM62P SoCs Dhruva Gole
2023-08-10 18:46 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230810184308.q67ldarld6qwo5uq@erased \
    --to=nm@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox