From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F38EC0015E for ; Fri, 11 Aug 2023 10:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GPxRiH89fPtCjElfKuVwce1vzdQLl79ZSJNoprQN774=; b=DsayAAuwQy7Xr/ nJwBCzNQeNQlKDUFyLHkHPB+BjSnYK5UMvtrdJsT7m9rQJs5MBCCTGZxpKjARvmOuWZGoHeFHGJEG iHsEl3yvR6OPwIc0mBMkIvsUT9GKMtLFOq9NEE2vCZ9TJqNrhikl4smzvR+3iWr/UZKKmuiNLiw3n Q6e2UxMypLMAOyDYN/XfvvWh3gx3tN5bemHd56s2rYMTGHwl0Tk21d9DMWl5rSgquQdDdiXT0U2PI DWAGIUUMH0zxhouib1pl2cczuBdb3+rhI1ZbDfG6ICojA+kEob36ftg98U+FN8VJC+u6CRglTlANV SDe47w/EAbsyKDGMythQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUPF1-00A8Xm-1k; Fri, 11 Aug 2023 10:19:35 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUPEy-00A8WJ-1K for linux-arm-kernel@lists.infradead.org; Fri, 11 Aug 2023 10:19:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D5CB366EF8; Fri, 11 Aug 2023 10:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3817C433C7; Fri, 11 Aug 2023 10:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691749171; bh=uLzOe07u2mc5CQdgcJqCfLD+BPdp+FAFUsDEr9hSL7Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pmzBoLX0tqhg+bqiJpj/BpbDfOI7f4tge07r0ir+XCi9n9p6N590mBZ4XSQvATCeE belyCKPq+cvh1Yy0h0jwnKuOoz8mU8obHq7SAXhvLCreXr5H8bPWs8bBUueTXU6csF giJaiJii9mmU47sV/wRiygpQJLN6vw1x3+sWD5lJ3uy81yVkdWo8YZkupGuDVYJtge MBVCCE52s7978VyhkEsVdbqRW3gxe/0S8efQQtFt+6K6gaaAgXbBNNTFfNdW2cuVso +xIAAUpyJAogMt/Bg+9UWYyVwUbNS5AKc1gWCa6TieeFgKCv/nltclGrX92CYAiVSw zETfu0evfVFnw== Date: Fri, 11 Aug 2023 11:19:25 +0100 From: Will Deacon To: Suzuki K Poulose Cc: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, yangyicong@huawei.com, Sami Mujawar , Catalin Marinas , Mark Rutland , Mike Leach , Leo Yan , Alexander Shishkin , James Clark , coresight@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 1/4] arm_pmu: acpi: Refactor arm_spe_acpi_register_device() Message-ID: <20230811101925.GB6827@willie-the-truck> References: <20230808082247.383405-1-anshuman.khandual@arm.com> <20230808082247.383405-2-anshuman.khandual@arm.com> <8bef9c5a-eede-f78f-4418-da10c99a5bef@arm.com> <20230808131634.GA2369@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230811_031932_561774_04BB806A X-CRM114-Status: GOOD ( 35.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 09, 2023 at 01:54:55PM +0100, Suzuki K Poulose wrote: > On 08/08/2023 14:16, Will Deacon wrote: > > On Tue, Aug 08, 2023 at 09:48:16AM +0100, Suzuki K Poulose wrote: > > > On 08/08/2023 09:22, Anshuman Khandual wrote: > > > > Sanity checking all the GICC tables for same interrupt number, and ensuring > > > > a homogeneous ACPI based machine, could be used for other platform devices > > > > as well. Hence this refactors arm_spe_acpi_register_device() into a common > > > > helper arm_acpi_register_pmu_device(). > > > > > > > > Cc: Catalin Marinas > > > > Cc: Will Deacon > > > > Cc: Mark Rutland > > > > Cc: linux-arm-kernel@lists.infradead.org > > > > Cc: linux-kernel@vger.kernel.org > > > > Co-developed-by: Will Deacon > > > > Signed-off-by: Will Deacon > > > > Signed-off-by: Anshuman Khandual > > > > --- > > > > drivers/perf/arm_pmu_acpi.c | 105 ++++++++++++++++++++++-------------- > > > > 1 file changed, 65 insertions(+), 40 deletions(-) > > > > > > > > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c > > > > index 90815ad762eb..72454bef2a70 100644 > > > > --- a/drivers/perf/arm_pmu_acpi.c > > > > +++ b/drivers/perf/arm_pmu_acpi.c > > > > + pdev->resource[0].start = irq; > > > > + ret = platform_device_register(pdev); > > > > + if (ret < 0) { > > > > + pr_warn("ACPI: %s: Unable to register device\n", pdev->name); > > > > + acpi_unregister_gsi(gsi); > > > > + } > > > > + return ret; > > > > > > A postivie return value here could confuse the caller. Also, with my comment > > > below, we don't really need to return something from here. > > > > How does this return a positive value? > > Right now, there aren't. My point is this function returns a "return value" > of another function. And the caller of this function doesn't > really follow the "check" it needs. e.g.: > > ret = foo(); > if (ret < 0) > error; > return ret; > > > > And the caller only checks for > > if (ret) > error; > > This seems fragile. Yeah, the '< 0' check is weird. I'd be inclined to drop that entirely from the helper function tbh... > > > > + int ret = arm_acpi_register_pmu_device(&spe_dev, ACPI_MADT_GICC_SPE, > > > > + arm_spe_parse_gsi); > > > > + if (ret) > > > > pr_warn("ACPI: SPE: Unable to register device\n"); > > > > > > With this change, a system without SPE interrupt description always > > > generates the above message. Is this intended ? > > > > If there are no irqs, why doesn't this return 0? > > Apologies, I missed that. > > > arm_acpi_register_pmu_device() should only fail if either: > > > > - The static resources passed in are broken > > - The tables are not homogeneous > > - We fail to register the interrupt > > > > so something is amiss. > > Agreed. We don't need duplicate messages about an error ? > i.e., one in arm_acpi_register_pmu_device() and another > one in the caller ? (Of course adding any missing error msgs). ... and then just print the registration failure message in the caller. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel