* [PATCH] ARM: dts: imx6dl-b1x5pv2: Fix simple-audio routing property @ 2023-08-09 11:44 Fabio Estevam 2023-08-09 19:36 ` Sebastian Reichel 2023-08-11 14:27 ` Shawn Guo 0 siblings, 2 replies; 4+ messages in thread From: Fabio Estevam @ 2023-08-09 11:44 UTC (permalink / raw) To: shawnguo; +Cc: linux-arm-kernel, sebastian.reichel, Fabio Estevam From: Fabio Estevam <festevam@denx.de> Per simple-card.yaml, 'simple-audio-card,audio-routing' is not a valid property. Change it to 'simple-audio-card,routing'. Signed-off-by: Fabio Estevam <festevam@denx.de> --- arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi index 37697fac9dea..6e487ebf27a2 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi @@ -257,7 +257,7 @@ sound { simple-audio-card,bitclock-master = <&dailink_master>; simple-audio-card,frame-master = <&dailink_master>; simple-audio-card,widgets = "Speaker", "Ext Spk"; - simple-audio-card,audio-routing = "Ext Spk", "LINE"; + simple-audio-card,routing = "Ext Spk", "LINE"; simple-audio-card,cpu { sound-dai = <&ssi1>; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6dl-b1x5pv2: Fix simple-audio routing property 2023-08-09 11:44 [PATCH] ARM: dts: imx6dl-b1x5pv2: Fix simple-audio routing property Fabio Estevam @ 2023-08-09 19:36 ` Sebastian Reichel 2023-08-14 7:42 ` EXT: " Wang, Huan Kitty (GE HealthCare) 2023-08-11 14:27 ` Shawn Guo 1 sibling, 1 reply; 4+ messages in thread From: Sebastian Reichel @ 2023-08-09 19:36 UTC (permalink / raw) To: Fabio Estevam Cc: shawnguo, linux-arm-kernel, Fabio Estevam, Ian Ray, Huan 'Kitty' Wang [-- Attachment #1.1: Type: text/plain, Size: 1318 bytes --] Hi, On Wed, Aug 09, 2023 at 08:44:31AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Per simple-card.yaml, 'simple-audio-card,audio-routing' is not a valid > property. > > Change it to 'simple-audio-card,routing'. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- Fixes: 1fac5db35ee9 ("ARM: dts: imx6: Add GE B1x5v2") Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> I no longer have that hardware to test the change. +Cc Ian and Kitty for testing. -- Sebastian > arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi > index 37697fac9dea..6e487ebf27a2 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi > +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi > @@ -257,7 +257,7 @@ sound { > simple-audio-card,bitclock-master = <&dailink_master>; > simple-audio-card,frame-master = <&dailink_master>; > simple-audio-card,widgets = "Speaker", "Ext Spk"; > - simple-audio-card,audio-routing = "Ext Spk", "LINE"; > + simple-audio-card,routing = "Ext Spk", "LINE"; > > simple-audio-card,cpu { > sound-dai = <&ssi1>; > -- > 2.34.1 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: EXT: Re: [PATCH] ARM: dts: imx6dl-b1x5pv2: Fix simple-audio routing property 2023-08-09 19:36 ` Sebastian Reichel @ 2023-08-14 7:42 ` Wang, Huan Kitty (GE HealthCare) 0 siblings, 0 replies; 4+ messages in thread From: Wang, Huan Kitty (GE HealthCare) @ 2023-08-14 7:42 UTC (permalink / raw) To: Sebastian Reichel, Fabio Estevam Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam, Ray, Ian (GE HealthCare) > -----Original Message----- > From: Sebastian Reichel <sebastian.reichel@collabora.com> > Sent: Thursday, August 10, 2023 3:37 AM > To: Fabio Estevam <festevam@gmail.com> > Cc: shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org; Fabio Estevam > <festevam@denx.de>; Ray, Ian (GE HealthCare) <ian.ray@ge.com>; Wang, Huan > Kitty (GE HealthCare) <HuanWang@ge.com> > Subject: EXT: Re: [PATCH] ARM: dts: imx6dl-b1x5pv2: Fix simple-audio routing > property > > WARNING: This email originated from outside of GE. Please validate the > sender's email address before clicking on links or attachments as they may not > be safe. > > Hi, > > On Wed, Aug 09, 2023 at 08:44:31AM -0300, Fabio Estevam wrote: > > From: Fabio Estevam <festevam@denx.de> > > > > Per simple-card.yaml, 'simple-audio-card,audio-routing' is not a valid > > property. > > > > Change it to 'simple-audio-card,routing'. > > > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > --- > > Fixes: 1fac5db35ee9 ("ARM: dts: imx6: Add GE B1x5v2") > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > I no longer have that hardware to test the change. > +Cc Ian and Kitty for testing. Thanks for the patch. Tested-by: Wang, Huan Kitty (GE HealthCare) <HuanWang@ge.com> > > -- Sebastian > > > arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi > > b/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi > > index 37697fac9dea..6e487ebf27a2 100644 > > --- a/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi > > +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-b1x5pv2.dtsi > > @@ -257,7 +257,7 @@ sound { > > simple-audio-card,bitclock-master = <&dailink_master>; > > simple-audio-card,frame-master = <&dailink_master>; > > simple-audio-card,widgets = "Speaker", "Ext Spk"; > > - simple-audio-card,audio-routing = "Ext Spk", "LINE"; > > + simple-audio-card,routing = "Ext Spk", "LINE"; > > > > simple-audio-card,cpu { > > sound-dai = <&ssi1>; > > -- > > 2.34.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6dl-b1x5pv2: Fix simple-audio routing property 2023-08-09 11:44 [PATCH] ARM: dts: imx6dl-b1x5pv2: Fix simple-audio routing property Fabio Estevam 2023-08-09 19:36 ` Sebastian Reichel @ 2023-08-11 14:27 ` Shawn Guo 1 sibling, 0 replies; 4+ messages in thread From: Shawn Guo @ 2023-08-11 14:27 UTC (permalink / raw) To: Fabio Estevam; +Cc: linux-arm-kernel, sebastian.reichel, Fabio Estevam On Wed, Aug 09, 2023 at 08:44:31AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Per simple-card.yaml, 'simple-audio-card,audio-routing' is not a valid > property. > > Change it to 'simple-audio-card,routing'. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-14 7:42 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-08-09 11:44 [PATCH] ARM: dts: imx6dl-b1x5pv2: Fix simple-audio routing property Fabio Estevam 2023-08-09 19:36 ` Sebastian Reichel 2023-08-14 7:42 ` EXT: " Wang, Huan Kitty (GE HealthCare) 2023-08-11 14:27 ` Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).