From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AED2CC001DB for ; Mon, 14 Aug 2023 01:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:Cc:To:From: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=7XL1/daMfLjqrzCpf63ZobluPawoQ6NltnlZYXjrDWU=; b=dFl alL0qid2RfmK2pv/xDzNyC3nIsu251sLVxCEQ39vf/bfbkvf+epT7dcn2g2WSfk86Lgk2EDCqIkyT L5T7vzaLZ6uiEwhFuFQ0hphW5/tK0UtpLQQM45IgotAR0OC7LpJ/cxIzzy71VXPQa/YHaz4TCxp17 /4FW0VDue/MbOQhJaYKWTfSTGojRaY0AsaWxfyjgqz3AOw8i21VUFE/OUmOEhd1teBcMcbjrkeJtS 1YtGYKiYglHlfgpUO1oIPh27ptT43V/IxSN6YW6HexGHK+1mLjmU3S58V2Iprq5RCBCirrTf27X2Q VCGiVOrbvDfKpBeYBfsMQXy0rwK/MGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVMqB-00FyTA-28; Mon, 14 Aug 2023 01:57:55 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVMq7-00FySS-1O for linux-arm-kernel@lists.infradead.org; Mon, 14 Aug 2023 01:57:53 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1bddac1b7bfso3772675ad.0 for ; Sun, 13 Aug 2023 18:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nathanrossi.com; s=google; t=1691978268; x=1692583068; h=mime-version:content-transfer-encoding:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=7Fm0TMFuin2nVJfOQii6CnvygCyjrjgFJg/XJLKguZo=; b=ZUNThFEc4hgiZaUjyd8Ng0rAQRmVrOU1J3UM0O/irEV1cAfKgZ9L2xQrkCNbkPqco/ GD7DN6xw3u9NEiUald7qGlFEN01Ui6hMev8K6YiHbPU3v85rBYk+X838IwXmA/+0n4ZD sXbblx5T/kC8qYb27xgZ/U3v44EKRdOSz1+ZNaGbWa1gNud+f379ZyvlBbzsL38xCPxB +AWmHYQEUPqfwTOdLIcx3JkreVae7OqvVTSm3leB+ZQazPPxQQnPcPc99Cbs9nHXwkWU 2nuJ5qgjFQJWHOj2FaRSf6oed4HJs3vEprYA8EQFHL/aL42MNUkJpeWTv+ucE2Aqm9yo 2m4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691978268; x=1692583068; h=mime-version:content-transfer-encoding:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Fm0TMFuin2nVJfOQii6CnvygCyjrjgFJg/XJLKguZo=; b=TfW55hB3MVpSP/mvXSMih4xz/FKQ/DOpb9PYDhJe7ov6AwGBPD2dGNAVCfFLGzQz+y 8yKH7LfqM2PTbc4p9/M6GoJSVg91hBRKKrKs9ur8wICMLCkqPOb6OT29cHx/sqIXY1mU 0CeCj2xRcVF8kzGigTPgrtvHrw4t0ZJREiBxEnSGQrUO8XWUXB3j3cMok2bonP3rmcRF tHSy9Y8tYPpo0jv/LFUXvGqdRY+lHLNqyHtPmfKfA4T4L8CLiGjbjwTy00AhZeMnEFu0 iC4iw98e+vdBdjXShiXS50d2sCV9fOqFjlLVJX6OZZ6Q6ebbK8AniZLo1v2MJQJTJNQJ lnAQ== X-Gm-Message-State: AOJu0YzLXaAquVDI1VRABuu9qaAZdmpZDHfH8Pu9PsmrRQPymvX47aBJ 0ihdYoEO/9sW7NPtHsPhLVnmKQ== X-Google-Smtp-Source: AGHT+IEJinrn2EOXiV+zlg4ANTeH8wmIIGKRxUmU/utFcxV4Fazdo6/ncbR/oBUBoXy8N3TArk86AA== X-Received: by 2002:a17:902:e846:b0:1bd:ea18:925d with SMTP id t6-20020a170902e84600b001bdea18925dmr462959plg.6.1691978268264; Sun, 13 Aug 2023 18:57:48 -0700 (PDT) Received: from [127.0.1.1] (117-20-68-32.751444.bne.nbn.aussiebb.net. [117.20.68.32]) by smtp.gmail.com with UTF8SMTPSA id jc3-20020a17090325c300b001b86492d724sm8075352plb.223.2023.08.13.18.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Aug 2023 18:57:47 -0700 (PDT) Date: Mon, 14 Aug 2023 01:57:00 +0000 Message-Id: <20230814015700.70156-1-nathan@nathanrossi.com> From: Nathan Rossi To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Nathan Rossi , Nathan Rossi , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: [PATCH] soc: imx8m: Enable OCOTP clock for imx8mm before reading registers MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230813_185751_542140_2A68DDE3 X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nathan Rossi Commit 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register") added configuration to enable the OCOTP clock before attempting to read from the associated registers. This same kexec issue is present with the imx8m SoCs that use the imx8mm_soc_uid function (e.g. imx8mp). This requires the imx8mm_soc_uid function to configure the OCOTP clock before accessing the associated registers. This change implements the same clock enable functionality that is present in the imx8mq_soc_revision function for the imx8mm_soc_uid function. Signed-off-by: Nathan Rossi --- drivers/soc/imx/soc-imx8m.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c index 1dcd243df5..ec87d9d878 100644 --- a/drivers/soc/imx/soc-imx8m.c +++ b/drivers/soc/imx/soc-imx8m.c @@ -100,6 +100,7 @@ static void __init imx8mm_soc_uid(void) { void __iomem *ocotp_base; struct device_node *np; + struct clk *clk; u32 offset = of_machine_is_compatible("fsl,imx8mp") ? IMX8MP_OCOTP_UID_OFFSET : 0; @@ -109,11 +110,20 @@ static void __init imx8mm_soc_uid(void) ocotp_base = of_iomap(np, 0); WARN_ON(!ocotp_base); + clk = of_clk_get_by_name(np, NULL); + if (IS_ERR(clk)) { + WARN_ON(IS_ERR(clk)); + return; + } + + clk_prepare_enable(clk); soc_uid = readl_relaxed(ocotp_base + OCOTP_UID_HIGH + offset); soc_uid <<= 32; soc_uid |= readl_relaxed(ocotp_base + OCOTP_UID_LOW + offset); + clk_disable_unprepare(clk); + clk_put(clk); iounmap(ocotp_base); of_node_put(np); } --- 2.40.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel