From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4053BEB64DD for ; Mon, 14 Aug 2023 18:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iCrc3xmX/xoGL10oU/pJqfe2CdyMfTdeqsNbBRrlWRs=; b=yHKOZeZwILcKw7 tCFf558iAcqWdAcBZhDC4KCUsXv2fLv4vB3sG5t87vFOsX9glBsIWoIxMNQJooJi0u3rdtTPYEbLH JAY5Qwp9nAD8Bn715tixbNFYfkQZLvGs0JlHLj1i8vHI14jzx7h+/BLahrpV7ECFyG0PvigwFkp00 ANJ3U67e+3VbMc6qzfLBK25+6dGP4B5ElCpCDlTy7ULr8rOXCJbTklzPrUQFKehhVcdutoza3z/Ew S53EtD7RGKlGRCdWmRPDpUSdd5zQ+Qsj2kVKzR0lnjohACX9oMJtAG3A1BFAw082DP/H58yT44Scn DdDvsjHxYq5qDAxsOfhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVc4t-0006XJ-2C; Mon, 14 Aug 2023 18:14:07 +0000 Received: from mgamail.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVc4q-0006Wo-16 for linux-arm-kernel@lists.infradead.org; Mon, 14 Aug 2023 18:14:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692036844; x=1723572844; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZPxt2QQcAtgeUsWpZ4wBDio4lSa6brn/TkPHu4rCISE=; b=KYlzxmiRPPPxXCEHAmWn8OpzPc+FCxz1gk74PRbmzRE9WdhkrLGDzaq/ fQbDQERPeGBU2PtFA6MBUBykx1/rP+VAk6PMFIOhHetJhPEF9WgogizaC lr5YKIwHvxAtZs4i0i/2FMly6tH0Pk2ibIpBgXI5MrcCu1XFrGmQn0ViP vdyFlg7B2XLTie9ngs4KSdrYc7H4yt9yX/JSs/inVbC4ALkbJsUUHEvDg rVUHx9VBJiHOgc0aamU+hRLN8DfEEG1IKpxQjHKjCpIqR7ZkXrYJb2cIh 0N8EjILZrNa7xGPeIWXnYQeYXMGB4r7at5Z6iW2MAwM9vtOYolLG/fSU8 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="438439546" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="438439546" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 11:14:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="877060648" Received: from pglc00067.png.intel.com ([10.221.207.87]) by fmsmga001.fm.intel.com with ESMTP; 14 Aug 2023 11:14:02 -0700 From: rohan.g.thomas@intel.com To: jose.abreu@synopsys.com Cc: alexandre.torgue@foss.st.com, conor+dt@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, pabeni@redhat.com, peppe.cavallaro@st.com, robh+dt@kernel.org, Rohan G Thomas Subject: RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback Date: Tue, 15 Aug 2023 02:13:54 +0800 Message-Id: <20230814181354.8603-1-rohan.g.thomas@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230814_111404_475905_155EA34D X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Rohan G Thomas From: Rohan G Thomas Date: Mon, Aug 14, 2023 at 15:06:37 > > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h > > @@ -219,6 +219,8 @@ struct stmmac_priv { > > int hwts_tx_en; > > bool tx_path_in_lpi_mode; > > bool tso; > > + bool tx_q_coe_lmt; > > Please use a flag here instead of "tx_q_coe_lmt". This is the preferrable > method now. > > Thanks, > Jose Thanks Jose for the feedback. If I read that correctly, your suggestion is to change " tx_q_coe_lmt" to something more readable, like "has_txcoe_limit". Please correct me if I understand it wrongly. BR, Rohan > > > + u32 tx_q_with_coe; > > int sph; > > int sph_cap; > > u32 sarc_type; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel