From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86F17C001B0 for ; Tue, 15 Aug 2023 03:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BgPP3eWKLhiV9Xlek+hKSHndu71aFBM+OagWRfQ5fcw=; b=mX/srTEgavkw1Y wSBaeZ8MgdAnrXhtTQ5c6dinR+n+b0iwf9TtVoowWJmQE8zxOV1BJ4G6YoWTl3SMpfpDBzGN5667s 57qKQhRYGzIijRqYbqtDtSMLUG6iDYOgJyLZ0VSlFc/zZ7cPScMr7AZZitodVPolGuI6Oqzsr/qFh xlxsH8QFzcYOixf+xOzPEAsltq/tFtIxGhXQUTEV7XQUpseJv5RtDevMdnlY2hRVVVXGtXWTCFvbE xlwQc76bEe6Bdo2hj5OwehKFsU63nod569949AOoJyE60iT6PAhdd/9yqZXKY+nXTdIG4GVoWpqMK P5MJFoQRUxbi06Q4iGoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVkfo-000nYN-1q; Tue, 15 Aug 2023 03:24:48 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVkfk-000nXw-2g for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 03:24:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB37760ABC; Tue, 15 Aug 2023 03:24:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D622C433C7; Tue, 15 Aug 2023 03:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692069883; bh=3FRPby38WxMTq6IfBU0Tvs25oJJdKuU9MSll+th2OsE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CohmaaG5iOklaCdHt91LUExlKpLVTVneSHhbdnXV20JXzqFrpqlDFmV2mcXlqi/zy 0xrSDKaT+EGvXM4vwCw771XsxmZn7pRw7Tl1WTmb/KVsTBM5W7zXZr8NOVy5pNT5gQ eVv2srZ6/3YDU9VH1CZVh2LL3xn/ve/cl7yXOZCacsolZsnXnZFy9XJKky1jK4E6b3 WdaqHv/eX0lL/oxtfLyFb32sCE8v4p0riDP8+UWgwM9BTWCJ5JmcvQs7pUDITYXA0F +0QkZKoC6sEPWH073OgEtVWZKzpkEV/meZf8ei7i9M+TaAyYJ4wqtycQWrEd4nCHZc j9Bw7B/xcRTYw== Date: Mon, 14 Aug 2023 20:24:41 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko Subject: Re: [PATCH net-next v4 4/9] dpll: netlink: Add DPLL framework base functions Message-ID: <20230814202441.349586b4@kernel.org> In-Reply-To: <20230811200340.577359-5-vadim.fedorenko@linux.dev> References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-5-vadim.fedorenko@linux.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230814_202444_946848_BFBFC7A0 X-CRM114-Status: UNSURE ( 9.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Aug 2023 21:03:35 +0100 Vadim Fedorenko wrote: > + xa_for_each(&pin->dpll_refs, i, ref) { > + const struct dpll_pin_ops *ops = dpll_pin_ops(ref); > + struct dpll_device *dpll = ref->dpll; > + > + if (!ops->frequency_set) > + return -EOPNOTSUPP; > + ret = ops->frequency_set(pin, dpll_pin_on_dpll_priv(dpll, pin), > + dpll, dpll_priv(dpll), freq, extack); > + if (ret) > + return ret; > + __dpll_pin_change_ntf(pin); > + } only one freq is reported in get, AFAICT, so why send a notification after each ref is updated? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel