From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E9A9C001DB for ; Tue, 15 Aug 2023 03:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dlMIfZVqWaGzYGC/5klbSNsqHxKAauOU1Bu5U/sbri8=; b=ogoj9PyunGCWzp tGiopiGHvCRxjKF52DJu1re+z+5sGLg+T7b5NnZpNdLAe4XqCN7bHubeFqq6E/r7n2PChnK+FAmVz hcJ5sD1s47JOyio7XbSoWktjnRE9et4aaFTWNkjPdpg3WHWhAoa4xBYZTC9GyI2/nM0wmJUR6DIqI 8BwrHvemHwB63zLhSZ5cmsg60BPAxDZwCcR5oVX0+pq+f3QvX2CPppNqMYyeI2EFtiohqbcS0tWoh HuTOCEXXv/r108zjBEZhylWyphurHaVP3FNHF74k47/vwiL/+bYvZkUUkZTXXMtWHPHr1bIhK1Jy9 xk9qMXIwW9kzNULeiBLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVl65-000pE8-0q; Tue, 15 Aug 2023 03:51:57 +0000 Received: from mgamail.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVl61-000pDc-1e for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 03:51:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692071513; x=1723607513; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0U5mVMBc7pOFHVeJVlzVG7Zb1up3kpgr5XH1w5CKdFQ=; b=dJkIDYvZh2RWfJfpff76A3EB7lQDox3PLknJmHZlVZN3QworAVkgi0m4 FNfcN2lQ5Y7YAjQri0OTa7Iu8aBrG6bCa0YoMqcXa/F7z7gOf9UYekceY pZUWCK7KgzBTKfzwKhlTKxofXtgVUrPd0ENVpPfDO/jusgfjhKj1gDZZ3 /yW3l0exBOzC9QVGaR1y9rKzWi1bvPJY7PDmCbpVKi6kg6D+VgPikiywn FPvGXMWBbKeO1wNDqt6HzGjoGxHhMxXz6W55xooMH6GXe1bj55zW3JJly Aabs/WlZM8dczck+HK8Tn7YHDIXSu264Ued9sX/KQO3ruMOoVr2D5WetK A==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="403176412" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="403176412" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 20:51:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="847904364" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="847904364" Received: from pglc00067.png.intel.com ([10.221.207.87]) by fmsmga002.fm.intel.com with ESMTP; 14 Aug 2023 20:51:48 -0700 From: Rohan G Thomas To: Jose Abreu Cc: alexandre.torgue@foss.st.com, conor+dt@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, pabeni@redhat.com, peppe.cavallaro@st.com, robh+dt@kernel.org, Rohan G Thomas Subject: RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback Date: Tue, 15 Aug 2023 11:51:45 +0800 Message-Id: <20230815035145.16990-1-rohan.g.thomas@intel.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20230814181354.8603-1-rohan.g.thomas@intel.com> References: <20230814181354.8603-1-rohan.g.thomas@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230814_205153_560547_729408EF X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Rohan G Thomas Date: Mon, Aug 14, 2023 at 15:06:37 > > > + bool tx_q_coe_lmt; > > > > Please use a flag here instead of "tx_q_coe_lmt". This is the > > preferrable method now. > > > > Thanks, > > Jose > > Thanks Jose for the feedback. If I read that correctly, your suggestion is to > change " tx_q_coe_lmt" to something more readable, like "has_txcoe_limit". > Please correct me if I understand it wrongly. > > BR, > Rohan > Or, use int instead of bool? BR, Rohan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel