From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 198BFC001B0 for ; Tue, 15 Aug 2023 08:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lDHRmokbczJYfDk1ZDgK6Mu8+UuKY33AJ0k5tLdbbXE=; b=FBNs7W3lyUI9ah kewG/BVxiCiAdGF4UshB6I0PeuTNqO6R5eimTeaI+MAOAHZOXc9ZqceI1wwuwCw3VIEeSUiEDjf5d iuhLoeZGlZMZKDws7TIz2OWUbxi4RChdf3AutyJqGDn7t9uit7yHPDIBW/ORVxKJaZraN2gQgFQkk QPnJ31q77M+TKExfJ5X+woo0d+HnXX1S1LCx1BHkKOxKmo+fKHimKpVhF1WJ/p6aN7vfbJ+TAg24v gIYIjOb7/1TKbZErclAVcqxsidvXPncLHq/Sa3ft6uA+RN+MoyBNDT5Img3T/1/ikxLg5aF8r6wjd e23195thpD5ylLY7H5Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVpjN-0019p4-1M; Tue, 15 Aug 2023 08:48:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVpjK-0019oF-0G for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 08:48:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3FB661063; Tue, 15 Aug 2023 01:49:25 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 73DBA3F762; Tue, 15 Aug 2023 01:48:41 -0700 (PDT) Date: Tue, 15 Aug 2023 09:48:38 +0100 From: Sudeep Holla To: Sibi Sankar Cc: cristian.marussi@arm.com, lukasz.luba@arm.com, Sudeep Holla , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_rjendra@quicinc.com, srinivas.kandagatla@linaro.org, Chandra Sekhar Lingutla Subject: Re: [PATCH] firmware: arm_scmi: Fixup perf microwatt support Message-ID: <20230815084838.46wqgiggnxc6rfpe@bogus> References: <20230811204818.30928-1-quic_sibis@quicinc.com> <20230814092503.xdzafmqu5h3shrlz@bogus> <0cfd73bb-3ae6-d7bd-296c-0c39d194464b@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0cfd73bb-3ae6-d7bd-296c-0c39d194464b@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_014846_169951_DEF631DD X-CRM114-Status: GOOD ( 22.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 14, 2023 at 09:43:37PM +0530, Sibi Sankar wrote: > Hey Sudeep, > > On 8/14/23 14:55, Sudeep Holla wrote: > > On Sat, Aug 12, 2023 at 02:18:18AM +0530, Sibi Sankar wrote: > > > The perf power scale value would currently be reported as bogowatts if the > > > platform firmware supports microwatt power scale and meets the perf major > > > version requirements. Fix this by populating version information in the > > > driver private data before the call to protocol attributes is made. > > > > > > CC: Chandra Sekhar Lingutla > > > Fixes: 3630cd8130ce ("firmware: arm_scmi: Add SCMI v3.1 perf power-cost in microwatts") > > > Signed-off-by: Sibi Sankar > > > --- > > > drivers/firmware/arm_scmi/perf.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > > > index c0cd556fbaae..30dedd6ebfde 100644 > > > --- a/drivers/firmware/arm_scmi/perf.c > > > +++ b/drivers/firmware/arm_scmi/perf.c > > > @@ -1080,6 +1080,8 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph) > > > > Please rebase any patch when posting upstream on upstream kernel tree. > > This definitely looks like some downstream tree. I will adjust and apply > > this time. This file never crossed 1000 line and this patch indicates > > otherwise, so I am sure Qcom has some downstream changes in this file now. > > Thanks for taking time to review the patch but zero points for the ^^ > deduction lol. The correct phrasing would be v6.5 rc6 hasn't crossed 1k > lines but the patch was based on next-20230809 which has the perf level > indexing mode support in addition :) You are right. Cristian reminded me about v3.2 perf changes in -next after I replied on this thread. I saw this as fix and was looking at only upstream tree and this didn't apply cleanly. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel