From: Jijie Shao <shaojijie@huawei.com>
To: <will@kernel.org>, <jonathan.cameron@huawei.com>, <mark.rutland@arm.com>
Cc: <chenhao418@huawei.com>, <shaojijie@huawei.com>,
<shenjian15@huawei.com>, <wangjie125@huawei.com>,
<liuyonglong@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH drivers/perf: hisi: 1/2] drivers/perf: hisi: hns3: default use hardware event 0 as group leader event.
Date: Wed, 16 Aug 2023 17:46:18 +0800 [thread overview]
Message-ID: <20230816094619.3563784-2-shaojijie@huawei.com> (raw)
In-Reply-To: <20230816094619.3563784-1-shaojijie@huawei.com>
From: Hao Chen <chenhao418@huawei.com>
For hns3 pmu events, we use command as below before:
perf stat -g -e hns3_pmu_sicl_0/config=0x00105,global=1/
-e hns3_pmu_sicl_0/config=0x10105,global=1/ -I 1000
We want to use -g parameter to make 0x00105 event and 0x10105 event
share a hardware event, but for kernel 6.2, 'commit 5f8f95673f68
("perf evlist: Remove group option.")' remove -g parameter.
So add this patch to set default related event idx as 0 to share
the first hardware event.
The new command shows as below:
perf stat -e hns3_pmu_sicl_0/config=0x00105,global=1/
-e hns3_pmu_sicl_0/config=0x10105,global=1/ -I 1000
Fixes: 5f8f95673f68 ("perf evlist: Remove group option.")
Signed-off-by: Hao Chen <chenhao418@huawei.com>
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
---
drivers/perf/hisilicon/hns3_pmu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/perf/hisilicon/hns3_pmu.c b/drivers/perf/hisilicon/hns3_pmu.c
index e0457d84af6b..6a4d04cbae91 100644
--- a/drivers/perf/hisilicon/hns3_pmu.c
+++ b/drivers/perf/hisilicon/hns3_pmu.c
@@ -796,9 +796,11 @@ static int hns3_pmu_find_related_event_idx(struct hns3_pmu *hns3_pmu,
if (!hns3_pmu_cmp_event(sibling, event))
continue;
- /* Related events is used in group */
+ /* Related events is used in group, else we use index 0 event as related event */
if (sibling->group_leader == event->group_leader)
return idx;
+ else
+ return 0;
}
/* No related event and all hardware events are used up */
--
2.30.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-16 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 9:46 [PATCH drivers/perf: hisi: 0/2] There are some bugfix for the hisi perf driver Jijie Shao
2023-08-16 9:46 ` Jijie Shao [this message]
2023-08-21 11:58 ` [PATCH drivers/perf: hisi: 1/2] drivers/perf: hisi: hns3: default use hardware event 0 as group leader event Will Deacon
2023-08-23 2:38 ` Jijie Shao
2023-08-16 9:46 ` [PATCH drivers/perf: hisi: 2/2] drivers/perf: hisi: fix set wrong filter mode for running events issue Jijie Shao
2023-08-21 12:04 ` Will Deacon
2023-08-21 12:08 ` Will Deacon
2023-08-21 12:32 ` Jijie Shao
2023-08-23 2:33 ` Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816094619.3563784-2-shaojijie@huawei.com \
--to=shaojijie@huawei.com \
--cc=chenhao418@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=mark.rutland@arm.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox