From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65EFDC678DD for ; Thu, 17 Aug 2023 23:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rRsrTWJE+Ab9QXFXAQAQPGNGZZLsHiwA+V2+8kOPX0w=; b=3+MqFlYiIgBNrv XHf/zAS8l7Cn+ztJlN0AcZxKu9JJj2ynm1rn4+iNR8bg16v/VrddvmXi2zzcqNEePXk6+wSxPNVnR t6pUVa9EZLB0Tu26SIWpJSbsEYQrOvvFuBfcYWkDZmfiqfXsMR5yisFfNEcOOOdH5Rv7yExAGLpO6 UAcM9jqweplPbPb5IQRoSm00qri20BOcIIFB7tOBPhBVR2HNLGmAGTuunxfXYiPKOApf1/chOBX9V ARJcyk5th5dg1sx57GuT0E3UN/yCa+/D6tQyd71fKuiLEm4jFk3cQ5/CydF+Dgp5E5TNZrN5pClkQ eD5CuwcHOLr3aGEeuaEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWmXp-007KIz-2q; Thu, 17 Aug 2023 23:36:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWmXm-007KIc-1Y for linux-arm-kernel@lists.infradead.org; Thu, 17 Aug 2023 23:36:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34B3D61D7B; Thu, 17 Aug 2023 23:36:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27221C433C9; Thu, 17 Aug 2023 23:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692315402; bh=RhegQx5uRaKcu1E0Rcckw5IZtC6q56UwuK3vF+HLjhU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oFbxa95Hfo/FdXazIXS1L4w163X1hkyZix7WC7BswVsZltRRJV70Ia5RhDke9RQmW v5hMxYFTDPzxcMcC/GvJ3Y6U135ShOZAwlJqQ/LudBbm5whE1X7PpULwONQt8x2GYD Az+eOYwcn5MjbP3m/psJ++7Fvg/c/ryL/n91X1rY5W4YzM4jMBtKNSJRV0qKYPc7Wy ujm/9LHTqEDTlOq6wzgAehvprfFveA++VHaLyRvgActcHbER5qLtY2rU+RAJeFjmph q9Vg1g8N/HCHlJIdko6OagOrS2NcV5TemgTsF+CEdKLCl4DtaFR6661uo6FA/+8WN/ WpXlldD11n9DQ== Date: Thu, 17 Aug 2023 16:36:40 -0700 From: Jakub Kicinski To: "Kubalewski, Arkadiusz" Cc: Vadim Fedorenko , Jiri Pirko , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , Bart Van Assche , "intel-wired-lan@lists.osuosl.org" , Jiri Pirko Subject: Re: [PATCH net-next v4 2/9] dpll: spec: Add Netlink spec in YAML Message-ID: <20230817163640.2ad33a4b@kernel.org> In-Reply-To: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-3-vadim.fedorenko@linux.dev> <20230814194336.55642f34@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230817_163646_630876_F87F0525 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 17 Aug 2023 18:40:00 +0000 Kubalewski, Arkadiusz wrote: > >Why are all attributes in a single attr space? :( > >More than half of them are prefixed with a pin- does it really > >not scream to you that they belong to a different space? > > I agree, but there is an issue with this, currently: > > name: pin-parent-device > subset-of: dpll > attributes: > - > name: id > type: u32 > - > name: pin-direction > type: u32 > - > name: pin-prio > type: u32 > - > name: pin-state > type: u32 > > Where "id" is a part of device space, rest attrs would be a pin space.. > Shall we have another argument for device id in a pin space? Why would pin and device not have separate spaces? When referring to a pin from a "device mostly" command you can usually wrap the pin attributes in a nest, and vice versa. But it may not be needed at all here? Let's look at the commands: + - + name: device-id-get + request: + attributes: + - module-name + - clock-id + - type + reply: + attributes: + - id All attributes are in "device" space, no mixing. + name: device-get + request: + attributes: + - id + reply: &dev-attrs + attributes: + - id + - module-name + - mode + - mode-supported + - lock-status + - temp + - clock-id + - type Again, no pin attributes, so pin can be separate? + - + name: device-set + request: + attributes: + - id Herm, this one looks like it's missing attrs :S + - + name: pin-id-get + request: + attributes: + - module-name + - clock-id + - pin-board-label + - pin-panel-label + - pin-package-label + - pin-type + reply: + attributes: + - pin-id Mostly pin stuff. I guess the module-name and clock-id attrs can be copy/pasted between device and pin, or put them in a separate set and add that set as an attr here. Copy paste is likely much simpler. + - + name: pin-get + request: + attributes: + - pin-id + reply: &pin-attrs + attributes: + - pin-id + - pin-board-label + - pin-panel-label + - pin-package-label + - pin-type + - pin-frequency + - pin-frequency-supported + - pin-dpll-caps + - pin-parent-device + - pin-parent-pin All pin. + - + name: pin-set + request: + attributes: + - pin-id + - pin-frequency + - pin-direction + - pin-prio + - pin-state + - pin-parent-device + - pin-parent-pin And all pin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel