From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA93BEE49A1 for ; Sat, 19 Aug 2023 01:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xa2+rrk+ehJHN4uVJcTaOr+BiRDtygHw/qQqGENJcEo=; b=ANxMIJ5B52B3oJ uNp4MdEai923yvA6Lpqf1uzMCHV+q3KggfXk/41A/wrMLPVWiWuIROsWAIqY66oYU9GJ1zv8SkrY3 N889cRhYJDsydweJ3W3jus4DxOh4IOjo7Vd6KhImB8Yxrf5769vrMAa7didUxCWTZsyLeyjRigzrx AP4xmArdpuDmaMPw4/re6yHIzskyAO1nCuKPP9E0liugbQDs+/hTMp58S8KsId97vTg/+3m0+73Z8 qHatAnt8usPHORlgZ5Lym6OUYWxmF02b2s7MR4KILxj7AvXTrIW97JAlp1EGHQaESWdqbkzTow2yu 7eZRlqN0Fr8Erk+CfKZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qXAq7-00AFZ4-0n; Sat, 19 Aug 2023 01:33:19 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qXAq4-00AFYi-3C; Sat, 19 Aug 2023 01:33:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 095CD61312; Sat, 19 Aug 2023 01:33:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA794C433C8; Sat, 19 Aug 2023 01:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692408795; bh=eQsDnVRcEoBkIR035KXsBsK1ZgEoecLvJBhlfQqPdvo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oo2h163uvr5HkeY9eXN8I13GpuAxwj82iwdkWJRNvXGueeQjJzVI1wg2ww2kootiX BOVZEjnlMwvuagtOGJGXD+ULBRIQfFEwLJPBtTSvvhRmE2lvfkSgfJMGiWTWNUBl2d eTyxlrW/En3wvKguy8EPt/fnSJdJvAT24dS3aYurZN44OggxY2hzJ707984EvwAS9W BFzf8J57P3niIwJ14Kk309Z80y3ivkjKHJT83nrDEmttwQPFzuE1uXjenECTkDwWiX qBtqnSltRcmeOJJKhc4AEcTtN4nZlF/7ash+D3wKJZDjrrLQUnvknu8PrWTyiPErSx WVyc4zzWA3NJQ== Date: Fri, 18 Aug 2023 18:33:13 -0700 From: Jakub Kicinski To: Daniel Golle Cc: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sujuan Chen , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net] net: ethernet: mtk_eth_soc: fix NULL pointer on hw reset Message-ID: <20230818183313.52f9b9f3@kernel.org> In-Reply-To: <6863f378a2a077701c60cea6ae654212e919d624.1692273610.git.daniel@makrotopia.org> References: <6863f378a2a077701c60cea6ae654212e919d624.1692273610.git.daniel@makrotopia.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_183317_120554_312DBB7C X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 17 Aug 2023 13:01:11 +0100 Daniel Golle wrote: > Initialize the hw_list will 0s and break out of both functions in case > a hw_list entry is 0. Static variables are always initialized to 0, I don't think that part is need. -- pw-bot: cr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel