From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F5A5EE498E for ; Fri, 18 Aug 2023 18:56:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+dvB3cMAVuJI7pqDSlz6Nd0t5/xDzZQUZTN90y76pDg=; b=xjY9vPN8c7LBq6 WZSu4KerZ6/vnDhvZ+o18ByKXWRMv6hE+gpwZVx+VTl5CMLhWzmAMTlzaklxzOm4sayIYcZeITzi8 Mf5CicazlS5dsTPTzlKqh+4yJBtkEL9LAJ9XDgwL46n9MKuXZn810nKTwhwi73ZVxwwGOlwj6S2uU QV4rys4pLt/ycJaC3rkLfjqmUrME6/q7Kz9UqM27kTCdo7YLaXysmkOMoc03DdjaUcIkUN/6AfgNj AiVFmZn2T9SNE66DqweDqeeUJL0mkO0EkBnT+JILRd+F4SlWevofH0F+GZ+5CIfrgyKOj4aHgjv/a HCBmxNabL3XknfICL/Aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qX4e4-009uBl-0W; Fri, 18 Aug 2023 18:56:28 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qX4e1-009uBK-1h for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 18:56:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7E606111D; Fri, 18 Aug 2023 18:56:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A79FC433C7; Fri, 18 Aug 2023 18:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692384984; bh=hI7sDkcMLbQVdysnlBH36J0XAQpUpzgf7DTFx9Kp0Ns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kW5WLekcF0hUuFAU6QxzZ/uE1xajc79qOZp4BBy2bhvLjfFlyQdPNdCRDdKB0PYgz mFWs/XxMTqb5UamENiQZmAxjzbOg62qiXCjubj4/2RZShVEYCUGKlKPhna0F42p0Zj P0PMN1cNtDHA6d33es69CJzpSsEc29fq3+UX3mEjTbgB4VsWYQiKEfET9ADBpXytPw eSdzsIy0vkppjQXjgab/RWj7YBN3c2NRlkfmOFUT7Bl0qx/iaFVYqDisZSTP594at5 LxBBnve2b4czQS4uxBb1K6bWDgJRmg69uib3EvB2RSoyfoxG75Bqpt8Xs7Eg55murq WoPYsrztMCwoQ== Date: Fri, 18 Aug 2023 21:56:16 +0300 From: Leon Romanovsky To: Ruan Jinjie Cc: horatiu.vultur@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, daniel.machon@microchip.com, richardcochran@gmail.com, horms@kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2 1/3] net: microchip: vcap api: Always return ERR_PTR for vcap_get_rule() Message-ID: <20230818185616.GF22185@unreal> References: <20230818050505.3634668-1-ruanjinjie@huawei.com> <20230818050505.3634668-2-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230818050505.3634668-2-ruanjinjie@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_115625_630895_D50345AA X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 18, 2023 at 01:05:03PM +0800, Ruan Jinjie wrote: > As Simon Horman suggests, update vcap_get_rule() to always > return an ERR_PTR() and update the error detection conditions to > use IS_ERR(), which would be more cleaner in this case. > > Signed-off-by: Ruan Jinjie > Suggested-by: Simon Horman > --- > drivers/net/ethernet/microchip/vcap/vcap_api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel