From: Leon Romanovsky <leon@kernel.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: horatiu.vultur@microchip.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
lars.povlsen@microchip.com, Steen.Hegelund@microchip.com,
daniel.machon@microchip.com, richardcochran@gmail.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 3/3] net: microchip: sparx5: Update return value check for vcap_get_rule()
Date: Fri, 18 Aug 2023 21:56:33 +0300 [thread overview]
Message-ID: <20230818185633.GH22185@unreal> (raw)
In-Reply-To: <20230818050505.3634668-4-ruanjinjie@huawei.com>
On Fri, Aug 18, 2023 at 01:05:05PM +0800, Ruan Jinjie wrote:
> As Simon Horman suggests, update vcap_get_rule() to always
> return an ERR_PTR() and update the error detection conditions to
> use IS_ERR(), so use IS_ERR() to check the return value.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> Suggested-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-18 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 5:05 [PATCH net-next v2 0/3] net: Update and fix return value check for vcap_get_rule() Ruan Jinjie
2023-08-18 5:05 ` [PATCH net-next v2 1/3] net: microchip: vcap api: Always return ERR_PTR " Ruan Jinjie
2023-08-18 18:56 ` Leon Romanovsky
2023-08-18 5:05 ` [PATCH net-next v2 2/3] net: lan966x: Fix return value check " Ruan Jinjie
2023-08-18 18:56 ` Leon Romanovsky
2023-08-18 5:05 ` [PATCH net-next v2 3/3] net: microchip: sparx5: Update " Ruan Jinjie
2023-08-18 18:56 ` Leon Romanovsky [this message]
2023-08-19 7:03 ` [PATCH net-next v2 0/3] net: Update and fix " Simon Horman
2023-08-19 18:43 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818185633.GH22185@unreal \
--to=leon@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).