From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBA75EE498E for ; Fri, 18 Aug 2023 18:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4KMu9iFzuKKenLmOupK3GVDO6X18iwi542A3HDzAi2o=; b=wBzU/X+UsF1M0E PDGJlG0lp8rIFyIlyFryK8wVFQwCyJcZ0g+NuY5nDiPN8KNhYmYoWL9vb8kCtvOawkMxQlrFUZbzK EGTVCUANVnY57Xh/72LKhe/cA5hAM/3koM6pjbRnLaQYCQ2fEkQ9HzB88Pu0G1icg1QgRFZjArxiU yAM10cp8B/jCY5hT5XI0y6wOCQB+XdTvMxxXcFwoLltmtNFaB22MVb0W9OGA/CaoUmMKVqPhURtn/ Eqk7FUgegxiURd7HnhE06tCaIAJ0F39XbMBSbHm31T+KKU6wV9ZHSNlgAk2ybxzpl/yUyqxtLQlw8 H/LrACJaVsq+JdEtkXyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qX4eL-009uFf-2m; Fri, 18 Aug 2023 18:56:45 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qX4eI-009uEV-14 for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 18:56:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC0E563986; Fri, 18 Aug 2023 18:56:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01C0FC433C7; Fri, 18 Aug 2023 18:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692385001; bh=qYe/f9Mr0sh3fGaKQnKLua3hro4AYCmL1Dd+xlaHDXg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=obGtvy8AIxx9BfUVTVYRsZrl8CJtuYlurJJfJLfjjQWVqFwRcdR5aSE8BwNFpnVNI Fc2CyvhUsVYr5aKGKPpynFM6bCpiLvM0NTuKzZt6kWI6/JCB2Wvy7N+wEkETBVjLcG 3z5WKkrGTzaMyk/axMY3iWxCA0PmZGaoYrd4K0v1Dk/JCi08xJ58tNd8lqEKcTAXiO /wepb9rtGIhuC8SjWZJ6no7dYbHzrpKRjlifi1Tdl+oQoSNLr+oFm/KwiFSvmrTd4V bNMDJ3ZTPeWA2Jkgp3tjibJjTnB1Kjx6TyAQIS6h6vzJDdCkXKQwK2Hbh82zlj/OAj y1zRFadlKY7Kg== Date: Fri, 18 Aug 2023 21:56:33 +0300 From: Leon Romanovsky To: Ruan Jinjie Cc: horatiu.vultur@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, daniel.machon@microchip.com, richardcochran@gmail.com, horms@kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2 3/3] net: microchip: sparx5: Update return value check for vcap_get_rule() Message-ID: <20230818185633.GH22185@unreal> References: <20230818050505.3634668-1-ruanjinjie@huawei.com> <20230818050505.3634668-4-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230818050505.3634668-4-ruanjinjie@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_115642_409656_1BA6622B X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 18, 2023 at 01:05:05PM +0800, Ruan Jinjie wrote: > As Simon Horman suggests, update vcap_get_rule() to always > return an ERR_PTR() and update the error detection conditions to > use IS_ERR(), so use IS_ERR() to check the return value. > > Signed-off-by: Ruan Jinjie > Suggested-by: Simon Horman > --- > drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel