From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AC20EE4993 for ; Mon, 21 Aug 2023 11:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jIM6nI2LDJ13dfMBcVdts3/6uj0DCE/oogsIxXohoOU=; b=4l77+lZHqthBgc jD2Yp4QZUMolhkAExDPm/zGeCu1e/ursM90/sn8m5B84kSuZGgBR911KGxJQPsLJgJ/JZ7MmC+DdX 8Yi9sgfAUTA21xT+QlRsHbbYbM2hE/lBe4Ef5ZrDQ49VHrNEJYmnOAe/jHoHh6bsIhio8rwz+/pB8 IpeSbJ1IEUwx62DISIb5alA1GkDYXix9RGHG2Zs3reGw2TNmwHcqRxUjm/87bH2Tr16GO7jJq74dQ r1IEcygYMrbdXDtGaohJmjnMN1avcRQpJBUXguXLs/bF3f1VDGTxwa53/da4qmbYpiZUQuVz0LcDl ef8KEOG23D3fAYEGBvqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY3YD-00DvZ8-0y; Mon, 21 Aug 2023 11:58:29 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qY3YA-00DvYZ-1w for linux-arm-kernel@lists.infradead.org; Mon, 21 Aug 2023 11:58:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E87EA632D3; Mon, 21 Aug 2023 11:58:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91230C433C8; Mon, 21 Aug 2023 11:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692619105; bh=T4xgCx5Z7Da6zvQfuv9RvMhCD7j3XXVo0DgN+vZ0gKM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aJIHohZYinbcN8n8Y1M/EzZR6AsYhe/nWTtkSgUSlur4uewOJrrG2ChhvPwPImXXO 0KjpEnfGmyyoFGrMo0HHL7uRNga4vC0bLUzA1IC79UhcUVe8qt3uf12SKq5u8BMq5H ZyrzaAi+OyLV/erqtY7PJ1edsnyhErk8HNBkpqFMxCZyX5avgNT+76DUZgmElINV7p pqpD/sDIWS1aBaKlsbHLe4vr6GoLlfmvobE2C/MmZ3nD2BOmUFTPj2PhwKcaSolmZL CvYgjz+OoJH8mGNex+jkfEPGMXmB+Tu8x7P48Z3/rwVwH/wS8lQAqbAG2+tBuQ2c+J f4RwImtk5PLrg== Date: Mon, 21 Aug 2023 12:58:20 +0100 From: Will Deacon To: Jijie Shao Cc: jonathan.cameron@huawei.com, mark.rutland@arm.com, chenhao418@huawei.com, shenjian15@huawei.com, wangjie125@huawei.com, liuyonglong@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH drivers/perf: hisi: 1/2] drivers/perf: hisi: hns3: default use hardware event 0 as group leader event. Message-ID: <20230821115820.GA19617@willie-the-truck> References: <20230816094619.3563784-1-shaojijie@huawei.com> <20230816094619.3563784-2-shaojijie@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230816094619.3563784-2-shaojijie@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230821_045826_681164_9A3FD311 X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 16, 2023 at 05:46:18PM +0800, Jijie Shao wrote: > From: Hao Chen > > For hns3 pmu events, we use command as below before: > perf stat -g -e hns3_pmu_sicl_0/config=0x00105,global=1/ > -e hns3_pmu_sicl_0/config=0x10105,global=1/ -I 1000 > > We want to use -g parameter to make 0x00105 event and 0x10105 event > share a hardware event, but for kernel 6.2, 'commit 5f8f95673f68 > ("perf evlist: Remove group option.")' remove -g parameter. > > So add this patch to set default related event idx as 0 to share > the first hardware event. Hmm, but the change cited above is a userspace change so I don't think we should be making driver-side changes for that. Furthermore, the commit message there suggests that you should be using a different syntax, introduced by 89efb029502d ("perf tools: Add support to parse event group syntax") (which describes the grammer and has some examples too). Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel