From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41674EE4993 for ; Mon, 21 Aug 2023 16:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i2zLcjABhtdiOgN0mL6or0yOOhDyuVKvJ++sUi/0zfA=; b=con0lzelFoWto/ WNd4zhuj3vsVLQ28OG930fIese1H8pDv3LbGs1tQBGE3nuSGt2vEKClF6dyNc3lBcxvALiCYvmxld mMWukamfsxl79v9BT+SbNmwxgi1UkE07IBkYgxKf2BChobaAcNQVG1hfxHGsVyZMqW6yjiQxo2haJ nUbLntKETxJicF4a9MJo46UqemY4Vj/CfVuu3EF5Cjbet8EUrcENLgC10mNTGwbxfJ483Q8nabxIr ZcpNFRi8tCE+OsxFUJPeD9JeDaMbWsGsMoU9DUJSK4w+XU/BeJZk2CSrtDsZzRa/Qg+mbLivryw7I MijSGlh3psps2mmUdLaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY7SH-00EL3O-1K; Mon, 21 Aug 2023 16:08:37 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qY7SD-00EL2R-1M for linux-arm-kernel@lists.infradead.org; Mon, 21 Aug 2023 16:08:35 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 1B1061C0004; Mon, 21 Aug 2023 18:08:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1692634105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G3h+5K3nJFrTdEYrbKtvLLhmyVimLfcmMypOuvflm9I=; b=G0rEhsFGBHKL2nFBgNm+Rf8na9z+iQKQRMHPuzcaTtc2Khb7ceMeRn8flR9cImjCxb1Gl/ AjZtb/QrqwzsonZ8PGWu5e/1T6FL8oQZFhFjdK2beISHkLub19hFD0o/hydgMYgqX6HqbS yHdpl9SYYeYl6QXgLtnkA6cAPfUlCic= Date: Mon, 21 Aug 2023 18:08:17 +0200 From: Pavel Machek To: Andrey Skvortsov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Jarrah Gosbell , Arnaud Ferraris Subject: Re: [PATCH] arm64: dts: pinephone: Add pstore support for PinePhone A64 Message-ID: <20230821160817.GA2227@bug> References: <20230724213457.24593-1-andrej.skvortzov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230724213457.24593-1-andrej.skvortzov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230821_090833_629148_481DB039 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! > This patch reserves some memory in the DTS and sets up a > pstore device tree node to enable pstore support. > > Signed-off-by: Andrey Skvortsov > > Gbp-Pq: Topic pinephone > Gbp-Pq: Name 0161-arm64-dts-pinephone-Add-pstore-support-for-PinePhone.patch > --- > .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > index 87847116ab6d..84f9410b0b70 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > @@ -19,6 +19,22 @@ aliases { > serial0 = &uart0; > }; > > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + pstore_mem: ramoops@61000000 { > + compatible = "ramoops"; > + reg = <0x61000000 0x100000>; > + record-size = <0x20000>; > + console-size = <0x20000>; > + ftrace-size = <0x20000>; > + pmsg-size = <0x20000>; > + ecc-size = <16>; > + }; > + }; dts is supposed to be for hardware description, but this is really policy decision. Should we have something like "any dram is suitable for pstore"....? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel