From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 114CCEE4996 for ; Tue, 22 Aug 2023 16:55:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eR2p24MhHTwaHdxrr5PMa4/fYB9qFnXvCxIMrK6oANo=; b=4a6zmt+/HF4rQL 0wnvXmvw5bVDgjf9NV5xsLaadk+SibS0kQ25+nk4aIQpqu6FLShG7bFNPKvmWPrFj0tK9g6dwhQfq BSF2IcYMhZ1zNybyaMx9IJkducwdscfXiKhugPF7SMM+5ayhLgD14/9uHTotWcN8KjQw7srO7Y7lG MT1YbUueS5vAJSKO9vB6GUYMPppdcA09GSbzvJCN/XRXbb7YErHtpizSIoxs2Q/pjcCQxTe/N/Y+/ YCZwyrAqLYcWc23c2sk6mVXYvSmULzXjTIAMnFq6S50CGCHZ3rGDSZYlKyzJWqom7bJkISKHE3YQr sKiVvLhBYB6Qyk83ZREg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYUem-00GXeu-0f; Tue, 22 Aug 2023 16:55:04 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYUej-00GXeI-3B for linux-arm-kernel@lists.infradead.org; Tue, 22 Aug 2023 16:55:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 547C562DBA; Tue, 22 Aug 2023 16:54:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4254CC433C8; Tue, 22 Aug 2023 16:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692723297; bh=UoOkKIMbPfEd0c+D0Uln/kWgFO+YI518rHnvKJm0rLE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FSW1H/InJ2afLXXYL2DTIbtdyEMvsvlV33F1+8nwiy+mPTMnZSkf5rQYOZPUIYgOJ KbKOR9QK5OXYgCCadIlZbHfa/ilQRbg/ewWQfBVzWcB2MlDaMnL5adQu1yRdy4ihx8 rlyJhCqIqCnTRnUEZeSz7bllPFA5aIhZ3PFtO2sptLM9MoISuNOt6+ezpkEUAB2Wg5 kWoGVIS0paAl0jwTiQreTve7v0Ywb5dKFSmCEJ4ZLHHSuSxqrbDDE7lHiJtOSNcnCB U/eNEsQZ5JYTPI5+/bhjZfm+eg+niNopnoEmKhnTdwoA9qDiXEBt6b4l4lP84Nkx+h W3lYaCXNI72Bw== Date: Tue, 22 Aug 2023 09:54:56 -0700 From: Jakub Kicinski To: "Kubalewski, Arkadiusz" Cc: Jiri Pirko , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , Bart Van Assche , "intel-wired-lan@lists.osuosl.org" , Jiri Pirko Subject: Re: [PATCH net-next v4 2/9] dpll: spec: Add Netlink spec in YAML Message-ID: <20230822095456.0a08b008@kernel.org> In-Reply-To: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-3-vadim.fedorenko@linux.dev> <20230814194336.55642f34@kernel.org> <20230817163640.2ad33a4b@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_095502_091197_B58305DB X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 21 Aug 2023 10:15:41 +0000 Kubalewski, Arkadiusz wrote: > I prepared some POC's and it seems most convenient way to do the > split was to add new argument as proposed on the previous mail. > After all the spec generated diff for uAPI header like this: > > --- a/include/uapi/linux/dpll.h > +++ b/include/uapi/linux/dpll.h > @@ -148,7 +148,17 @@ enum dpll_a { > DPLL_A_LOCK_STATUS, > DPLL_A_TEMP, > DPLL_A_TYPE, > - DPLL_A_PIN_ID, > + > + __DPLL_A_MAX, > + DPLL_A_MAX = (__DPLL_A_MAX - 1) > +}; > + > +enum dpll_a_pin { > + DPLL_A_PIN_ID = 1, > + DPLL_A_PIN_PARENT_ID, > + DPLL_A_PIN_MODULE_NAME, > + DPLL_A_PIN_PAD, > + DPLL_A_PIN_CLOCK_ID, > DPLL_A_PIN_BOARD_LABEL, > DPLL_A_PIN_PANEL_LABEL, > DPLL_A_PIN_PACKAGE_LABEL, > @@ -164,8 +174,8 @@ enum dpll_a { > DPLL_A_PIN_PARENT_DEVICE, > DPLL_A_PIN_PARENT_PIN, > > - __DPLL_A_MAX, > - DPLL_A_MAX = (__DPLL_A_MAX - 1) > + __DPLL_A_PIN_MAX, > + DPLL_A_PIN_MAX = (__DPLL_A_PIN_MAX - 1) > }; > > So we have additional attribute for targeting either a pin or device > DPLL_A_PIN_PARENT_ID (u32) - which would be enclosed in the nests as > previously: > - DPLL_A_PIN_PARENT_DEVICE (if parent is a device) > - DPLL_A_PIN_PARENT_PIN (if parent is a pin) > > > I will adapt the docs and send this to Vadim's repo for review today, > if that is ok for us. LGTM! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel