From: Martin Kaiser <martin@kaiser.cx>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH v2 4/6] hwrng: imx-rngc - read status register for error checks
Date: Thu, 24 Aug 2023 21:20:57 +0200 [thread overview]
Message-ID: <20230824192059.1569591-5-martin@kaiser.cx> (raw)
In-Reply-To: <20230824192059.1569591-1-martin@kaiser.cx>
The error bit in the status register of the imx-rngc is set for any kind
of error. Details about the error can be read from the bits in the error
status register.
In the imx_rngc_self_test function, we just need the info if there was an
error or not. We can check the status register, there's no need to read
the error status register.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/char/hw_random/imx-rngc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index 09523936d2af..c2582673427d 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -114,7 +114,7 @@ static int imx_rngc_self_test(struct imx_rngc *rngc)
if (ret < 0)
return ret;
- return readl(rngc->base + RNGC_ERROR) ? -EIO : 0;
+ return (status & RNGC_STATUS_ERROR) ? -EIO : 0;
}
static int imx_rngc_read(struct hwrng *rng, void *data, size_t max, bool wait)
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-24 19:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 19:20 [PATCH v2 0/6] hwrng: imx-rngc - use polling instead of interrupt Martin Kaiser
2023-08-24 19:20 ` [PATCH v2 1/6] hwrng: imx-rngc - reasonable timeout for selftest Martin Kaiser
2023-08-24 19:20 ` [PATCH v2 2/6] hwrng: imx-rngc - reasonable timeout for initial seed Martin Kaiser
2023-08-24 19:20 ` [PATCH v2 3/6] hwrng: imx-rngc - use polling to detect end of self test Martin Kaiser
2023-08-25 7:12 ` Alexander Stein
2023-08-29 18:58 ` Martin Kaiser
2023-08-24 19:20 ` Martin Kaiser [this message]
2023-08-24 19:20 ` [PATCH v2 5/6] hwrng: imx-rngc - use polling for initial seed Martin Kaiser
2023-08-24 19:20 ` [PATCH v2 6/6] hwrng: imx-rngc - remove interrupt handler Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824192059.1569591-5-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=alexander.stein@ew.tq-group.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).