From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BECF4C83F10 for ; Sun, 27 Aug 2023 17:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=79Xa+PTwo5xz/S1Gsbuh+zBOrMmwDf9POJeKaeJq0S8=; b=u1luyjPD2d7Pf0 2fYQSalXwv+e97dTYEuLSWOV7TR+4ESje1fR23ClgxJsknseaKNSPwAsU8pCM5Hi8mTxWTts8kF8U cNjm8OxWsETS/DqytrEIEnkpXFKQbkLWXmLD44iupwlJMeCR2YMPRx60SnbUAotn8FxhKAJ1saxA5 r7bc5NaCF5+LmA0poDkCTpL+D4sQ9mNQqCYPiCy8EDfXYYQYtdG3p5eDX3bA0I3HfOLE8gj1LRa4p dK8bZwcsoGMW4Xh42JSnMPR/7D4LvEbxYvl+CulMB5olbkWw8WgZuWNPtwsx21/OJLiVS+5zoxjJ/ 84xVgo+2HRW7m/hBYS7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qaJE0-008HhI-2C; Sun, 27 Aug 2023 17:06:56 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qaJDt-008Hg8-08; Sun, 27 Aug 2023 17:06:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A0CC60FD2; Sun, 27 Aug 2023 17:06:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37A02C433C7; Sun, 27 Aug 2023 17:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693156006; bh=kf7goXxFzP7UPvM4+zs0gsazvakWRvcmTwI7V2CQnXw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PowsSb3w+mXwzknuW+XZpdoiv2+Y2ez5ogTodw8fsCwGSZ6AyOg00Fhpg+eEmoXnW rNtnFw6NX66XUhrt+OXzNT68ByUkB744I9xychP9SbcDGOhCL8pgunIp8QeyhfoKZQ WrULVepsdTdX5dS2WGTFujqRU9KqQxpKYlvNYvBgQCF1PwNe2T0HHrqKQ9KkXdNRW/ fd2/S62TvNtSCu4MZB0y09g+FN3RZnkE2I/wOY1gyKQK/y6nqkaAYvi1lrNyG6Td3c FO50Gx4dRhetJUS1yn0hHiEFBXP5QymWpljYnT0uG4IIUsiuN8fd1OYu77IknGtAl2 d/RSIlbM8k9fQ== Date: Sun, 27 Aug 2023 18:07:06 +0100 From: Jonathan Cameron To: Jinjie Ruan Cc: , , , , , Subject: Re: [PATCH -next 0/2] iio: adc: mt6577_auxadc: Cleanup with the helpers Message-ID: <20230827180706.09242b5d@jic23-huawei> In-Reply-To: <20230826035402.3512033-1-ruanjinjie@huawei.com> References: <20230826035402.3512033-1-ruanjinjie@huawei.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230827_100653_679209_F6E9C7DA X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 26 Aug 2023 11:54:00 +0800 Jinjie Ruan wrote: > Use the dev_err_probe() helper to simplify error handling during probe. > This also handle scenario, when EDEFER is returned and useless > error is printed. Just a quick note to the driver maintainers. Whilst I've applied this, I won't be pushing that out as a non rebasing tree for a few weeks. As such I'm very happy to add tags, or indeed to drop it if you see any changes you would like. Taking it quickly is mostly because I have a huge backlog having been away and want to get the simple stuff off that list! Thanks, Jonathan > > And use devm_add_action_or_reset() and devm_iio_device_register() > to simplify the code. > > Jinjie Ruan (2): > iio: adc: mt6577_auxadc: Simplify with dev_err_probe() > iio: adc: mt6577_auxadc: Simplify with device managed function > > drivers/iio/adc/mt6577_auxadc.c | 60 +++++++++++++-------------------- > 1 file changed, 23 insertions(+), 37 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel