* [PATCH] tty: serial: meson: Add a earlycon for the S4 SoC
@ 2023-08-28 12:10 Lucas Tanure
2023-08-28 12:16 ` Neil Armstrong
0 siblings, 1 reply; 4+ messages in thread
From: Lucas Tanure @ 2023-08-28 12:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Neil Armstrong, Kevin Hilman,
Jerome Brunet
Cc: linux-kernel, linux-serial, linux-arm-kernel, linux-amlogic,
Lucas Tanure
The new Amlogic S4 SoC does not have a always-on uart, so add
OF_EARLYCON_DECLARE for it.
Signed-off-by: Lucas Tanure <tanure@linux.com>
---
drivers/tty/serial/meson_uart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
index 790d910dafa5..8dfaa260e545 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
return 0;
}
-OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
- meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);
#define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
#else
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tty: serial: meson: Add a earlycon for the S4 SoC
2023-08-28 12:10 [PATCH] tty: serial: meson: Add a earlycon for the S4 SoC Lucas Tanure
@ 2023-08-28 12:16 ` Neil Armstrong
2023-08-28 12:26 ` Lucas Tanure
0 siblings, 1 reply; 4+ messages in thread
From: Neil Armstrong @ 2023-08-28 12:16 UTC (permalink / raw)
To: Lucas Tanure, Greg Kroah-Hartman, Jiri Slaby, Kevin Hilman,
Jerome Brunet
Cc: linux-kernel, linux-serial, linux-arm-kernel, linux-amlogic
Hi,
On 28/08/2023 14:10, Lucas Tanure wrote:
> The new Amlogic S4 SoC does not have a always-on uart, so add
> OF_EARLYCON_DECLARE for it.
>
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
> drivers/tty/serial/meson_uart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 790d910dafa5..8dfaa260e545 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
> return 0;
> }
>
> -OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
> - meson_serial_early_console_setup);
> +OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
> +OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);
Not sure why you would change both lines, and where's the t7 entry ?
Neil
>
> #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
> #else
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tty: serial: meson: Add a earlycon for the S4 SoC
2023-08-28 12:16 ` Neil Armstrong
@ 2023-08-28 12:26 ` Lucas Tanure
2023-08-28 12:30 ` neil.armstrong
0 siblings, 1 reply; 4+ messages in thread
From: Lucas Tanure @ 2023-08-28 12:26 UTC (permalink / raw)
To: neil.armstrong
Cc: Greg Kroah-Hartman, Jiri Slaby, Kevin Hilman, Jerome Brunet,
linux-kernel, linux-serial, linux-arm-kernel, linux-amlogic
On Mon, Aug 28, 2023 at 1:16 PM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> Hi,
>
> On 28/08/2023 14:10, Lucas Tanure wrote:
> > The new Amlogic S4 SoC does not have a always-on uart, so add
> > OF_EARLYCON_DECLARE for it.
> >
> > Signed-off-by: Lucas Tanure <tanure@linux.com>
> > ---
> > drivers/tty/serial/meson_uart.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> > index 790d910dafa5..8dfaa260e545 100644
> > --- a/drivers/tty/serial/meson_uart.c
> > +++ b/drivers/tty/serial/meson_uart.c
> > @@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
> > return 0;
> > }
> >
> > -OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
> > - meson_serial_early_console_setup);
> > +OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
> > +OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);
>
> Not sure why you would change both lines, and where's the t7 entry ?
ok, but we don't need t7, right? T7 will use S4 compatible line.
>
> Neil
>
> >
> > #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
> > #else
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tty: serial: meson: Add a earlycon for the S4 SoC
2023-08-28 12:26 ` Lucas Tanure
@ 2023-08-28 12:30 ` neil.armstrong
0 siblings, 0 replies; 4+ messages in thread
From: neil.armstrong @ 2023-08-28 12:30 UTC (permalink / raw)
To: tanure
Cc: Greg Kroah-Hartman, Jiri Slaby, Kevin Hilman, Jerome Brunet,
linux-kernel, linux-serial, linux-arm-kernel, linux-amlogic
Hi,
On 28/08/2023 14:26, Lucas Tanure wrote:
> On Mon, Aug 28, 2023 at 1:16 PM Neil Armstrong
> <neil.armstrong@linaro.org> wrote:
>>
>> Hi,
>>
>> On 28/08/2023 14:10, Lucas Tanure wrote:
>>> The new Amlogic S4 SoC does not have a always-on uart, so add
>>> OF_EARLYCON_DECLARE for it.
>>>
>>> Signed-off-by: Lucas Tanure <tanure@linux.com>
>>> ---
>>> drivers/tty/serial/meson_uart.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
>>> index 790d910dafa5..8dfaa260e545 100644
>>> --- a/drivers/tty/serial/meson_uart.c
>>> +++ b/drivers/tty/serial/meson_uart.c
>>> @@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
>>> return 0;
>>> }
>>>
>>> -OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
>>> - meson_serial_early_console_setup);
>>> +OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
>>> +OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);
>>
>> Not sure why you would change both lines, and where's the t7 entry ?
> ok, but we don't need t7, right? T7 will use S4 compatible line.
Indeed, I forget you finally used amlogic,meson-s4-uart as fallback.
Please indicate this in the commit message.
I'll ack the revert then,
Thanks,
Neil
>>
>> Neil
>>
>>>
>>> #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
>>> #else
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-28 12:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-28 12:10 [PATCH] tty: serial: meson: Add a earlycon for the S4 SoC Lucas Tanure
2023-08-28 12:16 ` Neil Armstrong
2023-08-28 12:26 ` Lucas Tanure
2023-08-28 12:30 ` neil.armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).