From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 523B3C83F12 for ; Mon, 28 Aug 2023 11:12:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bvp6rRV5J4qIqciRW1h1ow7odtnosCVC7ZaQflSdqD4=; b=z2ITzHgUMz1g79 kbKdxE4l+t4P25UVp3Y7j+kp1ITNI0FBgzpJ06NH/6r6iSShWc5MyNI8jR7JBisgNPtsfrX+ozb8m QIJB54dVhd7OHOALHr+V4nirrQtY9W3gd6XkKGY72joKUkgYos87zX1HS+bKAai17w+s1sIa8rmOC QE3O2LmXvieRfcbjqYrO/tnGm+P5yG6mJK82H2E4e+gRIXh/4BtTzXn7FmjYpJS/jVWlTZunoz9s1 /gz+WNB8UyF5ZAwz29rnu74Htz2FHYQAz3tIm7mlFI64OiJBbglwrtgvhqgGRAXpUrelcD6mkr0mK uStyUyTzDG6Dfp2psGbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qaaAO-009U5F-1I; Mon, 28 Aug 2023 11:12:20 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qaaAL-009U40-0J for linux-arm-kernel@lists.infradead.org; Mon, 28 Aug 2023 11:12:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9A28B6101A; Mon, 28 Aug 2023 11:12:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63853C433C7; Mon, 28 Aug 2023 11:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693221124; bh=3xzMaPjPYEqZCNZV1zhlfpTm5S4RWqgbO23BEWAdQgU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Oxfh+ZjH/zfMgeQvI+h2B3MHBfoOJBA1zSctRZ58PrZXZqpwYfyLpZbLydXAY+GRq rvA2l85mogIOWbrnzDYCphiRkeflaw/NT03B7H/dEp3h0Nh3ov1v/vlGh0EAw3hGBJ mJm7tx2kyrVGySYg/0jUMt7GgVVEChbFuCtqj/sSgPdrjsd6dxOdAGlrca10q3c1SO vxGQcsgbvSPcoGfJXOAxnjNPjGVqmjDqB1wukA/QFP4w1VbspjRBpvFvgAyHST21Fr D0mWnlao8cRUrNJ9VV6TBKoKl1QSH4uHiDOyC3uMQ64ydkIQNdg2+upx9UwgJw9vVL izf/NdY3xUWkw== Date: Mon, 28 Aug 2023 12:12:22 +0100 From: Jonathan Cameron To: Jinjie Ruan Subject: Re: [PATCH -next v3 0/3] iio: adc: at91_adc: Cleanup with the helpers Message-ID: <20230828121222.114c728a@jic23-huawei> In-Reply-To: <20230828064546.2383857-1-ruanjinjie@huawei.com> References: <20230828064546.2383857-1-ruanjinjie@huawei.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230828_041217_181006_A9166657 X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, alexandre.belloni@bootlin.com, lars@metafoo.de, heiko@sntech.de, linux-iio@vger.kernel.org, claudiu.beznea@tuxon.dev, yangyingliang@huawei.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 28 Aug 2023 14:45:43 +0800 Jinjie Ruan wrote: > Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared > and enabled clocks") provides a new helper function to prepare and > enable a clock which keeps prepared (or enabled) during the whole > lifetime of the driver. > > Use devm_request_irq() to request the interrupt, so we can > avoid having to manually clean this up. > > Use the dev_err_probe() helper to simplify error handling during probe. > This also handle scenario, when EDEFER is returned and useless > error is printed. > > changes in v3: > - Take the last remove free_irq() and add it to be the first devm managed. > - Not going any longer than 80 chars than is necessary. > > Changes in v2: > - Also use devm_request_irq() and dev_err_probe() to clean up the at91_adc. > - Split the at91_adc patch out to be a new patch set. > > Jinjie Ruan (3): > iio: adc: at91_adc: Use devm_request_irq() helper function > iio: adc: at91_adc: Use devm_clk_get_enabled() helper function > iio: adc: at91_adc: Simplify with dev_err_probe() > > drivers/iio/adc/at91_adc.c | 108 +++++++++++++------------------------ > 1 file changed, 37 insertions(+), 71 deletions(-) > Series applied. Thanks for jumping through the various hoops that came up in review! Note that whilst I have applied this, that is mostly about my tracking rather than meaning others cannot continue to comment on it. I won't be pushing this out as a non rebasing tree (which linux-next will pick up) for a few weeks. Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel