From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73A23C71153 for ; Tue, 29 Aug 2023 15:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JxXDrSZRDC90G8FsOACuW2LzygpwCSFwtspZOawBhOI=; b=H74dtFlbMiZ2u7B5E4yMyr/pLV xFqIa2ISa7033h1lZqLeSluLLLv9r56D29/s6cdHelzVaYDGBN8qqZPth4QY+MekApY2SFN1nFOGN 2j1CYipi/lgzxGc4c7gOFBbbox74n5ZUiqXbUT69mc2JVfCwJMa+4yXllOCGCyoLzuWviUyiFvS1Y ezmqqej6TpxdfJnB0qDi3mTyVEL069ofTEgqEFrhFQRZUxs5L3wUKyeHwYr9yTJ7JhKI9hoUmc/cY H72h6k+txKRnwejzSiVjgV4VUz/0OPnGcMx3iLV5fL9dXXVyUamltXDsHQzCQWDZqUjYXPWgj/Rqp Z0PibA/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qb0Cd-00Bk72-2R; Tue, 29 Aug 2023 15:00:23 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qb0CS-00Bk1I-2w for linux-arm-kernel@lists.infradead.org; Tue, 29 Aug 2023 15:00:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5518C61ED1; Tue, 29 Aug 2023 15:00:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D445DC433C7; Tue, 29 Aug 2023 15:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693321211; bh=ceUTSllSKCAPQG+RRuLHM1ghYUnZrUeBrxRMcn6jQVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BnJuG9hGO3t+yTmYVTEOiDWcrnoG5yz0vpGjMLpq1FojJ2LDvg4/YjKzaeGx2Pxry rWWdNhHGtYL7n/sd6zSawDGN48gL0Y61pAHLeG4s7/m547dFSi86k0TRkBeMNUkrw1 iZS+f3GsXrCFalgAkqllwUu4+P9LsxmRjz6OT2nL+t1pnMUZbUA76Ubf1h4IubCsUe p4NAdGt1n7ip10vck2eA/j8fKSpyaoocWgTrblqHtAkPRZkJT/95mVOTPYnSOESWN+ szDMOgx9wlMjQOpUKhWauy/qPxkTaEqjlDOG8Rq4T+x23cOGIKUUS4ZruosT4KrsSO v87qltN0F+0jA== Date: Tue, 29 Aug 2023 16:00:06 +0100 From: Conor Dooley To: Alain Volmat Cc: Hugues Fruchet , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Sakari Ailus , Dan Scally , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] dt-bindings: media: add bindings for dcmipp driver Message-ID: <20230829-juror-decathlon-f7b252a330bf@spud> References: <20230829132357.192535-1-alain.volmat@foss.st.com> <20230829132357.192535-2-alain.volmat@foss.st.com> MIME-Version: 1.0 In-Reply-To: <20230829132357.192535-2-alain.volmat@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_080013_079838_1D7D5802 X-CRM114-Status: GOOD ( 20.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4929571974653073725==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4929571974653073725== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qG2kGaJAeSU28rCp" Content-Disposition: inline --qG2kGaJAeSU28rCp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, On Tue, Aug 29, 2023 at 03:23:45PM +0200, Alain Volmat wrote: > Add the yaml binding for the DCMIPP driver. Please drop all mentions of drivers, bindings are for hardware. >=20 > Signed-off-by: Alain Volmat > --- > .../bindings/media/st,stm32-dcmipp.yaml | 95 +++++++++++++++++++ > 1 file changed, 95 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmi= pp.yaml >=20 > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml= b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > new file mode 100644 > index 000000000000..63f03a1c42b6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > @@ -0,0 +1,95 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/st,stm32-dcmipp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STM32 DCMIPP Digital Camera Memory Interface P= ixel Processor binding s/binding// to appease the bot. > + > +maintainers: > + - Hugues Fruchet > + - Alain Volmat > + > +properties: > + compatible: > + const: st,stm32mp13-dcmipp > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: kclk Can drop the items: here since you only have one. The name is also pretty pointless when you only have one... > + > + resets: > + maxItems: 1 > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + DCMIPP supports a single port node with parallel bus. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + bus-type: > + enum: [5, 6] > + default: 5 > + > + bus-width: > + enum: [8, 10, 12, 14] > + default: 8 > + > + pclk-sample: true > + hsync-active: true > + vsync-active: true > + > + required: > + - pclk-sample > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + dcmipp: dcmipp@5a000000 { Neither of the labels here are used AFAICT, please remove them. Thanks, Conor. > + compatible =3D "st,stm32mp13-dcmipp"; > + reg =3D <0x5a000000 0x400>; > + interrupts =3D ; > + resets =3D <&rcc DCMIPP_R>; > + clocks =3D <&rcc DCMIPP_K>; > + clock-names =3D "kclk"; > + > + port { > + dcmipp_0: endpoint { > + remote-endpoint =3D <&mipid02_2>; > + bus-width =3D <8>; > + hsync-active =3D <0>; > + vsync-active =3D <0>; > + pclk-sample =3D <0>; > + }; > + }; > + }; > + > +... > --=20 > 2.25.1 >=20 --qG2kGaJAeSU28rCp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZO4H9gAKCRB4tDGHoIJi 0k1GAP9lydVZqmkBXhnoBL4BwByU5Brn+WCt7/lNlnhMjoZjLwEAz9Li2WbAIuFZ FJmcvAGQQsR170zfmTSMHhYOcIbPVAw= =rxYo -----END PGP SIGNATURE----- --qG2kGaJAeSU28rCp-- --===============4929571974653073725== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4929571974653073725==--