From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B971C83F12 for ; Tue, 29 Aug 2023 12:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RwnkNWBQwgczMfCxUUofTgbg2IR9TEWc3kszYiWXp/c=; b=nDddxYCOqiU8D1 nqRxmalkzkeiEqxRGNq5XelhzHhGhfoQ3NoXXoNn1mp0na61KuUxj5hZLgidSWZ7MYwx14+vyEqnU w7254yOnHpzo5TzkQ0ZsliPJruCskq7KeFnQuT2eeTxnzzRGebvaHx/9eLYBJUtQ+RVtNjQWDCkDv x+7cLrHUSYAsEUETMwfN084C84p3u5IPuRpF/T4j5V8UwcA/8jSsfRQUumIDxALyZ+XcT4qv69Qi1 RJ6yeOJI1HH9wg8QoG1r9kGLs0rNptIXAV1oc4Rs6DAVbonj5cgbSxwraqsYfGjb7NoQ2Dn8x4ejR 40UFNL7wTBJgrsUzd6JA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qayHk-00BYFo-1I; Tue, 29 Aug 2023 12:57:32 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qayHi-00BYFV-2M for linux-arm-kernel@lists.infradead.org; Tue, 29 Aug 2023 12:57:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AD5864976; Tue, 29 Aug 2023 12:57:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9BAFC433C7; Tue, 29 Aug 2023 12:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693313849; bh=Hsop6h3Mj4t+MJnbkOYMg9H8IkpBGz7yjfKDTfG844Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UxRI0aQI6SwZyAQCt0ae/Pb/jejYo2s3zpx32WuQTiwcN5vj36W51XEGjqmCd1hAR g8MoIHtH96g732d8+LekGobzWyqyKAexM5JA4b+5hhMfRE+5VqgeEiC5sQNLbBkACe uPqLJqO7bySAZ48ZwqaJUIe4AsZPpP8ABJnMrIgpBxQKo+Jo0l0BwZGUu0Y8Sh9fNa WJMjsAme19lkRN55aILbdpnOZod7tg2tG4sH2R3CK93Dc8V3W84cdNmdZ1yZ8FtfUH AnkhFgN233Zw8aqPMtCbJzBGAowi127w0AfpEUR4W+92SK16NoZxrlEEpOn/7vMKAC TR0L/9RdALo0g== Date: Tue, 29 Aug 2023 14:57:20 +0200 From: Andi Shyti To: Yann Sionneau Subject: Re: [PATCH RESEND] i2c: at91: Use dev_err_probe() instead of dev_err() Message-ID: <20230829125720.jqk52g3lsbfvodk4@intel.intel> References: <20230825143234.38336-1-yann@sionneau.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230825143234.38336-1-yann@sionneau.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_055730_831166_A2749E3E X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, Claudiu Beznea , linux-i2c@vger.kernel.org, Codrin Ciubotariu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Yann, On Fri, Aug 25, 2023 at 04:32:34PM +0200, Yann Sionneau wrote: > Change > if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); } > into > return dev_err_probe() > > Also, return the correct error instead of hardcoding -ENODEV > This change has also the advantage of handling the -EPROBE_DEFER situation. > > Signed-off-by: Yann Sionneau Reviewed-by: Andi Shyti Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel