From: Andi Shyti <andi.shyti@kernel.org>
To: Yann Sionneau <yann@sionneau.net>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-i2c@vger.kernel.org,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND] i2c: at91: Use dev_err_probe() instead of dev_err()
Date: Tue, 29 Aug 2023 15:00:04 +0200 [thread overview]
Message-ID: <20230829130004.tx45hldmp7balxr6@intel.intel> (raw)
In-Reply-To: <20230829125720.jqk52g3lsbfvodk4@intel.intel>
BTW...
> > Change
> > if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); }
> > into
> > return dev_err_probe()
> >
> > Also, return the correct error instead of hardcoding -ENODEV
> > This change has also the advantage of handling the -EPROBE_DEFER situation.
> >
> > Signed-off-by: Yann Sionneau <yann@sionneau.net>
>
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
for the next time, please, if you make changes to the patch,
starting from the commit title, commit message, patch body, you
need to increment the versioning and note the change in the
changelog.
Use resend only if the patch is taken and sent as it is without
any change, anywhere.
This should have been [PATCH v2].
Andi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-29 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 14:32 [PATCH RESEND] i2c: at91: Use dev_err_probe() instead of dev_err() Yann Sionneau
2023-08-28 8:03 ` Nicolas Ferre
2023-08-28 10:29 ` Yann Sionneau
2023-08-29 12:57 ` Andi Shyti
2023-08-29 13:00 ` Andi Shyti [this message]
2023-08-30 19:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829130004.tx45hldmp7balxr6@intel.intel \
--to=andi.shyti@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=codrin.ciubotariu@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yann@sionneau.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).