From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C3EBC83F12 for ; Tue, 29 Aug 2023 13:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JEVPsry/KH6O9B1SAtjVKrbdEQSXg4xvD7MV31KqxMA=; b=yBDKCHTojVQcdP NIJMbAEaEGBgVdgPuGU0AZ7wpJNcTibRpgmqbmEcYHDTB4MHgs3eVhWmu9PpjF9d3vKUiLP1E1k1i aSn6upgp6YMHgK8eaMJfN46QR3OgmkhAo+unSYwHUuAXwt1hD+rjyCBxWAXyihCsjmPBYshGt4Jpy XomU9m2QeQY6XvBC2dEIf2OS378TM8/ydRMiWJrHzXF5hdINOhIc5rLYzYNuUMcwO5tR/Ljne2WYB 46JrTx53L5nUi9p8I4J14CDXrByfrp8xIXIc50R6RVRJ04XtD1wr+5dXLHy9fMjctFAWS/3TCaYGx 904KoWpCCd49ZSp5CN0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qayKK-00BYVf-0T; Tue, 29 Aug 2023 13:00:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qayKH-00BYV3-2R for linux-arm-kernel@lists.infradead.org; Tue, 29 Aug 2023 13:00:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AB2161376; Tue, 29 Aug 2023 13:00:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A376BC433C9; Tue, 29 Aug 2023 13:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693314008; bh=k02n8H/pMA/2kxbcumIZSPEHc62SYzyV55gFzonZl7M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OoY82y9T92qWO1tGbT8KzEsY1f9Gxs0bdfJw07827vw/O4pDOB8b9eky4FDaOJDxZ nNopPpx46xa787BpymXdvh6dNsOS8MFbtvRRyFOfOeaAv+TuGd0pLWds+6Fn2GJj2+ liAzppz6R0dgO3q3UHdb/6LOS+WYzw3i67u0wEqgnrQND8ifudybM1JTl6gAwHjdrH 152pWIJRPigSn/xZkpYHXDxnM6o7zpDnAZs52KbRo7lRXSRbKx1+yHoGfwuZSZ5j9b A7Lv+8JVqxkZI5UNMCQCS5epYRqbkZk2AnhhPcSWsZ+TYDRfWagj4TU31oslzf7CmL Lc1xTrtlJE0Lw== Date: Tue, 29 Aug 2023 15:00:04 +0200 From: Andi Shyti To: Yann Sionneau Subject: Re: [PATCH RESEND] i2c: at91: Use dev_err_probe() instead of dev_err() Message-ID: <20230829130004.tx45hldmp7balxr6@intel.intel> References: <20230825143234.38336-1-yann@sionneau.net> <20230829125720.jqk52g3lsbfvodk4@intel.intel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230829125720.jqk52g3lsbfvodk4@intel.intel> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_060009_840689_6F9D38C6 X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, Claudiu Beznea , linux-i2c@vger.kernel.org, Codrin Ciubotariu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org BTW... > > Change > > if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); } > > into > > return dev_err_probe() > > > > Also, return the correct error instead of hardcoding -ENODEV > > This change has also the advantage of handling the -EPROBE_DEFER situation. > > > > Signed-off-by: Yann Sionneau > > Reviewed-by: Andi Shyti for the next time, please, if you make changes to the patch, starting from the commit title, commit message, patch body, you need to increment the versioning and note the change in the changelog. Use resend only if the patch is taken and sent as it is without any change, anywhere. This should have been [PATCH v2]. Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel