From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86E41C83F14 for ; Wed, 30 Aug 2023 10:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tNJQKgDwFezsx2lThXv9TUsA2+2q4M3w03p6Zt7KAYA=; b=QjBb82PA04RAKp qVlwD2u5EIwjp6wytcGh3Yvr8rSN2Ra+OorB7G16x2pNFD3AzvpudgbLy04ozX5+tsxTu2lcaL4dS WdN+gzVFStPXLgLE4TScccH9pr7Fuyv736yGsf+fr3q92io4rT3z6qlv7I7a2Sm+VUhDyk9F9kYvB 9cpp35He5gWDd7qE6PWPsNJaMrU01gsFg3T/3T1X9Hofu7qG2o6L93mj6pI6GJ8neb6qxdE/DnjMM Lqwu+orVLxVDUpc0tp/1ieYbc0GekavQ/W607k159q44HKddV3GsB22+ZFRyb0csLm2eH7+9iISgs bgrmL9UnZ7SGtCT8owLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbIoP-00DLID-2l; Wed, 30 Aug 2023 10:52:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbIoN-00DLHt-1y for linux-arm-kernel@lists.infradead.org; Wed, 30 Aug 2023 10:52:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12BDB2F4; Wed, 30 Aug 2023 03:53:12 -0700 (PDT) Received: from bogus (unknown [10.57.36.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7AF933F64C; Wed, 30 Aug 2023 03:52:31 -0700 (PDT) Date: Wed, 30 Aug 2023 11:51:34 +0100 From: Sudeep Holla To: Oza Pawandeep Cc: catalin.marinas@arm.com, will@kernel.org, rafael@kernel.org, lenb@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v3] cpuidle, ACPI: Evaluate LPI arch_flags for broadcast timer Message-ID: <20230830105134.dskqqq55npsclibq@bogus> References: <20230829201101.3330337-1-quic_poza@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230829201101.3330337-1-quic_poza@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230830_035235_742674_154DA5A3 X-CRM114-Status: GOOD ( 23.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 29, 2023 at 01:11:01PM -0700, Oza Pawandeep wrote: > Arm=AE Functional Fixed Hardware Specification defines LPI states, > which provide an architectural context loss flags field that can > be used to describe the context that might be lost when an LPI > state is entered. > = > - Core context Lost > - General purpose registers. > - Floating point and SIMD registers. > - System registers, include the System register based > - generic timer for the core. > - Debug register in the core power domain. > - PMU registers in the core power domain. > - Trace register in the core power domain. > - Trace context loss > - GICR > - GICD > = > Qualcomm's custom CPUs preserves the architectural state, > including keeping the power domain for local timers active. > when core is power gated, the local timers are sufficient to > wake the core up without needing broadcast timer. > = > The patch fixes the evaluation of cpuidle arch_flags, and moves only to > broadcast timer if core context lost is defined in ACPI LPI. > = > Reviewed-by: Sudeep Holla > Signed-off-by: Oza Pawandeep > = > diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h > index bd68e1b7f29f..0d455b02971e 100644 > --- a/arch/arm64/include/asm/acpi.h > +++ b/arch/arm64/include/asm/acpi.h > @@ -9,6 +9,7 @@ > #ifndef _ASM_ACPI_H > #define _ASM_ACPI_H > = > +#include > #include > #include > #include > @@ -42,6 +43,26 @@ > #define ACPI_MADT_GICC_SPE (offsetof(struct acpi_madt_generic_interrupt= , \ > spe_interrupt) + sizeof(u16)) > = > +/* > + * Arm=AE Functional Fixed Hardware Specification Version 1.2. > + * Table 2: Arm Architecture context loss flags > + */ > +#define CPUIDLE_CORE_CTXT BIT(0) /* Core context Lost */ > + > +#ifndef arch_update_idle_state_flags > +static __always_inline void _arch_update_idle_state_flags(u32 arch_flags, > + unsigned int *sflags) > +{ > + if (arch_flags & CPUIDLE_CORE_CTXT) > + *sflags |=3D CPUIDLE_FLAG_TIMER_STOP; > +} > +#define arch_update_idle_state_flags _arch_update_idle_state_flags > +#endif > + > +#define CPUIDLE_TRACE_CTXT BIT(1) /* Trace context loss */ > +#define CPUIDLE_GICR_CTXT BIT(2) /* GICR */ > +#define CPUIDLE_GICD_CTXT BIT(3) /* GICD */ > + > /* Basic configuration for ACPI */ > #ifdef CONFIG_ACPI > pgprot_t __acpi_get_mem_attribute(phys_addr_t addr); > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > index 9718d07cc2a2..420baec3465c 100644 > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -1221,8 +1221,7 @@ static int acpi_processor_setup_lpi_states(struct a= cpi_processor *pr) > strscpy(state->desc, lpi->desc, CPUIDLE_DESC_LEN); > state->exit_latency =3D lpi->wake_latency; > state->target_residency =3D lpi->min_residency; > - if (lpi->arch_flags) > - state->flags |=3D CPUIDLE_FLAG_TIMER_STOP; > + arch_update_idle_state_flags(lpi->arch_flags, &state->flags); > if (i !=3D 0 && lpi->entry_method =3D=3D ACPI_CSTATE_FFH) > state->flags |=3D CPUIDLE_FLAG_RCU_IDLE; > state->enter =3D acpi_idle_lpi_enter; > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index d584f94409e1..d49488fdbc49 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > @@ -1471,6 +1471,10 @@ static inline int lpit_read_residency_count_addres= s(u64 *address) > } > #endif > = > +#ifndef arch_update_idle_state_flags > +#define arch_update_idle_state_flags do {} while (0); I think I suggested it in v2 as without that you will get the warnings the kernel build bot has posted now. #define arch_update_idle_state_flags(af, sf) do {} while (0) Add the parameters and drop the leading ';'. -- = Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel