From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B88C4C6FA8F for ; Wed, 30 Aug 2023 11:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z+nVonwz50ju56qG2h8NDVMnqHDVcIC+odzC42pvSb0=; b=cCLM4x9NuM3TT8 RkfwKm25J11TDrFZPUq5p6ZVkUpoDnSer+Yv2uGJQk65s14RyXg4DOtEC+n1Pn2VXBvjhDmOoLuTQ 77sj6WIH2HXIFQlMx0zh20WUS1tNaWVvPfk5RfpO05h0c+poIcAnus+8sQh+vjy7XDD34kEYh0Xxn cjh02J8IeqGtc01XUnWN+6rgkfsAg8s39R1sG0zPl9oemGZs8c/0lZSjuUps1NhG0cqXUzi0/bQdY z1/0u2vSFvRNbbuox8gTnYEZjM/0sJruby7ssASM1SsCWCxWpBdxTee2WSrd3brXCj8WSbf3GYZwX vd7AB8LeD4iDgNshmyWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbJiK-00DQrR-2t; Wed, 30 Aug 2023 11:50:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbJiH-00DQqr-0o for linux-arm-kernel@lists.infradead.org; Wed, 30 Aug 2023 11:50:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 118872F4; Wed, 30 Aug 2023 04:50:59 -0700 (PDT) Received: from bogus (unknown [10.57.36.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E29423F738; Wed, 30 Aug 2023 04:50:15 -0700 (PDT) Date: Wed, 30 Aug 2023 12:49:18 +0100 From: Sudeep Holla To: Ricardo Neri Cc: x86@kernel.org, Andreas Herrmann , Catalin Marinas , Sudeep Holla , Chen Yu , Len Brown , Radu Rendec , Pierre Gondois , Pu Wen , "Rafael J. Wysocki" , Srinivas Pandruvada , Will Deacon , Zhang Rui , stable@vger.kernel.org, Ricardo Neri , "Ravi V. Shankar" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/3] cacheinfo: Allocate memory for memory if not done from the primary CPU Message-ID: <20230830114918.be4mvwfogdqmsxk6@bogus> References: <20230805012421.7002-1-ricardo.neri-calderon@linux.intel.com> <20230805012421.7002-2-ricardo.neri-calderon@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230805012421.7002-2-ricardo.neri-calderon@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230830_045021_397341_B4DCA6C8 X-CRM114-Status: GOOD ( 23.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 04, 2023 at 06:24:19PM -0700, Ricardo Neri wrote: > Commit 5944ce092b97 ("arch_topology: Build cacheinfo from primary CPU") > adds functionality that architectures can use to optionally allocate and > build cacheinfo early during boot. Commit 6539cffa9495 ("cacheinfo: Add > arch specific early level initializer") lets secondary CPUs correct (and > reallocate memory) cacheinfo data if needed. > > If the early build functionality is not used and cacheinfo does not need > correction, memory for cacheinfo is never allocated. x86 does not use the > early build functionality. Consequently, during the cacheinfo CPU hotplug > callback, last_level_cache_is_valid() attempts to dereference a NULL > pointer: > > BUG: kernel NULL pointer dereference, address: 0000000000000100 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not present page > PGD 0 P4D 0 > Oops: 0000 [#1] PREEPMT SMP NOPTI > CPU: 0 PID 19 Comm: cpuhp/0 Not tainted 6.4.0-rc2 #1 > RIP: 0010: last_level_cache_is_valid+0x95/0xe0a > > Allocate memory for cacheinfo during the cacheinfo CPU hotplug callback if > not done earlier. > > Cc: Andreas Herrmann > Cc: Catalin Marinas > Cc: Chen Yu > Cc: Len Brown > Cc: Radu Rendec > Cc: Pierre Gondois > Cc: Pu Wen > Cc: "Rafael J. Wysocki" > Cc: Sudeep Holla > Cc: Srinivas Pandruvada > Cc: Will Deacon > Cc: Zhang Rui > Cc: linux-arm-kernel@lists.infradead.org > Cc: stable@vger.kernel.org > Acked-by: Len Brown > Fixes: 6539cffa9495 ("cacheinfo: Add arch specific early level initializer") Not sure if we strictly need this(details below), but I am fine either way. > Signed-off-by: Ricardo Neri > --- > The motivation for commit 5944ce092b97 was to prevent a BUG splat in > PREEMPT_RT kernels during memory allocation. This splat is not observed on > x86 because the memory allocation for cacheinfo happens in > detect_cache_attributes() from the cacheinfo CPU hotplug callback. > > The dereference of a NULL pointer is not observed today because > cache_leaves(cpu) is zero until after init_cache_level() is called (also > during the CPU hotplug callback). Patch2 will set it earlier and the NULL- > pointer dereference will be observed. Right, this is the information I have been asking in the previous versions. This clarifies a lot. The trigger is in the patch 2/3 which is why it didn't make complete sense to me without it when you posted this patch independently. Thanks for posting it together and sorry for the delay(both reviewing this and in understanding the issue). Given the trigger for NULL pointer dereference is in 2/3, I am not sure if it is really worth applying this to all the stable kernels with the commit 5944ce092b97 ("arch_topology: Build cacheinfo from primary CPU"). That is the reason why I asked to drop fixes tag if you agree with me. It is simple fix, so I am OK if you prefer to see that in the stable kernels as well. Since there are x86 changes and patch 2/3 triggers NULL pointer dereference without this patch, I prefer you route all 3 via x86. So, Reviewed-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel