From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C37D3C83F29 for ; Thu, 31 Aug 2023 04:21:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bsik7I5/ENLd8UwFGXcOmglOzJ1xRteuxIQ5vIJ/SBI=; b=fFG/ctFEuhXlyw g7ThQ2b4Vi3CJNdETXwJe2XtbS1a62apBVTGSjNAzqWpcsk0//8Ne46PnOjP3Dtiw/U35bvV7JWe6 nc0B93js/PaDNYnjk2CMkKS7ghntMRrTsnmEU8ZkLiyvWckZYbhqDd2mPDQyt8XeM0njwK7Dpw1M0 fn5xsqTOOIUSaJQjjKXGe2GdOZqpHsmJXgZu1aAVMy8nCsvchfB1SlVZe4AybgBvK3Eji4slLAAWQ duTz/D2DEWhz+RbipMuCKRLOFs/G8mah1y9by4FL0Vd2HiTyxa9FGcCR522pXZOeorTIUl7b0mfDu w1Zate29h0bBskI+OMBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbZAc-00Eca8-1W; Thu, 31 Aug 2023 04:20:38 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbZAZ-00EcZc-2N for linux-arm-kernel@lists.infradead.org; Thu, 31 Aug 2023 04:20:37 +0000 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-68bec3a1c0fso301827b3a.1 for ; Wed, 30 Aug 2023 21:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693455634; x=1694060434; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=THKot3DyoPDc0V9Z4riR189lVwannjnrUDVHPF85Luk=; b=Ee2u1qDlvCroOAZ0ayXev1BMc1H9APz6/PE7ujBQxlKlUxCKflCPRv7NJwqgyAm/uA 97AfdYfl0sXIvwGzoKYr67+9e50dPM293bagUwgxuqErRaO590aooANlj6J948JZZ2hI XywtMqSZ/xENpBnAvShZ+MmksWM5T2dzLA0K1baggITAGmvyRUknrZITvTMhIqLG63ns 8y65ukPfaMh24UlPwFYehX/GGTNyuCD1xvtr/aN0w4FB0xMFGb+MWDpqs/F+t0PGhg4w UUDqZYflrSMKar5CYF/6Fyk689/jinhWYK/IC6RIbawzjtkSjkG9DNVSAcy32dG8lWii unyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693455634; x=1694060434; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=THKot3DyoPDc0V9Z4riR189lVwannjnrUDVHPF85Luk=; b=ia4AKQiFTuI/7rv7rf+Bxz7NW+R+W1pzt9yq+Vlqv4u6uKhmwKmrkuvd+RdEY9aT8j jeFRZ+06WZwQZPQCxfAVFBig4qRtBAcjZS+R89BeepD1o//kV5DnL9BxdtHsVZVAlsiF 1lczxUI1zqrJ3JLtldzxemj/Py4+SgrCkXls+Wjmo3RI7fMzUaZRm03Ko85OuNpaH6W4 iue/rnHrWQmy7kTD0uNeezW3ZgQQ8TYofqPh6Wx2IszZRHIGQjM2/K7NxkUqRVRrDH1x BY7Unc6AHxQyX58YeruOEm0RIcf9fXzTDVA8pUBt6d3rAW0MQRRJhTPfCrukEqMQjLHx +oaQ== X-Gm-Message-State: AOJu0Yz5bpL8cTw83jxj7H1QMIqHDFuPpCMcBDO4KU5X2OVHSMqcJdaB hh33yh9EurkNgTOCv7jJEio= X-Google-Smtp-Source: AGHT+IHzlwTkkkiEvX8Y3Jxqf+MA2n1F4tOPt5P33LGlL0agKNv2bgY3taZ70nCL457VBx5kSuEnBQ== X-Received: by 2002:a05:6a20:7f94:b0:14b:b42c:349b with SMTP id d20-20020a056a207f9400b0014bb42c349bmr5595932pzj.1.1693455634113; Wed, 30 Aug 2023 21:20:34 -0700 (PDT) Received: from atom0118 ([2405:201:6815:d8ef:8c0f:e11:eef0:3e00]) by smtp.gmail.com with ESMTPSA id y11-20020a1709027c8b00b00198d7b52eefsm305172pll.257.2023.08.30.21.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Aug 2023 21:20:32 -0700 (PDT) Date: Thu, 31 Aug 2023 09:50:23 +0530 From: Atul Kumar Pant To: Michal Simek Cc: shubhrajyoti.datta@amd.com, sai.krishna.potthuri@amd.com, bp@alien8.de, tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shuah@kernel.org Subject: Re: [PATCH v1] drivers: edac: Drop unnecessary error check for debugfs_create_dir Message-ID: <20230831042023.GA76997@atom0118> References: <20230815203826.51792-1-atulpant.linux@gmail.com> <723e803b-6f8b-ceb3-e987-4a6f83d89222@amd.com> <20230828133547.GA58271@atom0118> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230830_212035_802012_85F72F20 X-CRM114-Status: GOOD ( 35.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 28, 2023 at 04:00:41PM +0200, Michal Simek wrote: > > > On 8/28/23 15:35, Atul Kumar Pant wrote: > > On Fri, Aug 25, 2023 at 09:31:54AM +0200, Michal Simek wrote: > > > > > > > > > On 8/15/23 22:38, Atul Kumar Pant wrote: > > > > This patch removes the error checking for debugfs_create_dir. > > > > > > Avoid using "This patch". > > > > Thanks for pointing this out. I'll remember this. > > > > > > > > > Even if we get an error from this function, other debugfs APIs will > > > > handle the error value and doesn't crash in that case. Hence caller can > > > > safely ignore the errors that occur during the creation of debugfs nodes. > > > > > > First of all which issue do you have? Did you see that folder is not created? > > > > I have not seen any issue as such. But going by the comments before > > the debugfs_create_dir API (https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L583), > > we can ignore safely ignore the return value from this API. > > > > > > > > I am not quite sure if this is the right behavior. > > > In the code there is > > > 135 if (!parent) > > > 136 parent = edac_debugfs; > > > > > > It means you are right that if creating ocm folder can fail and properties > > > will be still created under edac_debugfs but is this the right behavior? > > > > > > altera_edac/armada_xp_edac/i10nm/i5100/igen6/others are checking return > > > value that's why I can't see any reason to remove this checking from one > > > driver. > > > > > > If you want to fix all please send patch for all but I don't think it will > > > improve situation and it will just hide different issue if creating folder > > > fails. > > > > Understood your point. Are you suggesting that we should keep these > > checks as it is, or should I fix for all the drivers and upload the > > patch ? > > Up to Boris to decide but I would say keep it as is. Even debugfs is not > stable interface I would like to be informed if something fails. But just > 2c. Thanks you Michal. I'll wait for the reply from Boris. > > Thanks, > Michal > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel